Sat, 06 Dec 2008 14:24:50 +0000 Cleanups in group and program
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:50 +0000] rev 681
Cleanups in group and program The missing super call in group prevented the scope from being set as it should be. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:24:26 +0000 Added a new create regexp in urls for just scope_path
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:26 +0000] rev 680
Added a new create regexp in urls for just scope_path Now that scope_path is properly defined we can add a url matching just the scope path. This allows some other custom create regexps to be removed/rewritten. Note: It needs to be -after- the full key_name regexp, since for arbitrarily nested scopes it would always match as just scope_path, even if there are other fields needed after the scope. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:23:53 +0000 Introduce dynamic scope_path regexps
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:53 +0000] rev 679
Introduce dynamic scope_path regexps Instead of relying on scope_path's being "one slash deep", we should instead allow for either: 1. scope_paths that have a pre-defined depth 2. scope_paths that can be arbitrarily deep We achieve 1 by setting an entities scope_logic to another logic module. We then recursively call getScopeDepth until we get to the topmost entity (that is, an unscoped entity). A little different is the solution to 2, since some entities can have an arbitrarily deep scope (such as Documents), we need to have some way of signaling this to getScopePattern. A clean solution is to return None, rather than a number. If None is returned, the SCOPE_PATH_ARG_PATTERN is returned as regexp instead, which will match an arbitrarily deeply nested scope. The solution for 2 requires that we return None somewhere in the scope_logic chain, the most straight forward method to do so is to override getScopeDepth anywhere such a scope is needed and make it return None. A more elegant solution however, is to set the scope_logic to that module in all entities that require it. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:23:25 +0000 Added a linkable logic module
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:25 +0000] rev 678
Added a linkable logic module The linkable logic module is used to signal the fact that the scope of an entity can be any linkable. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 12:13:19 +0000 Fix scope lookup for unscoped entities
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:13:19 +0000] rev 677
Fix scope lookup for unscoped entities As scope_logic is now always set (since r1250), we need to check if it is None, rather than check if it exists. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 12:12:58 +0000 Swap the order of request key fields
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:12:58 +0000] rev 676
Swap the order of request key fields This will make it easier to remove scope_path as explicit key field at some point by having it as inplicit key field for all entities. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:53:26 +0000 Use key().name() instead of link_id
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:53:26 +0000] rev 675
Use key().name() instead of link_id This is now possible because key_name is constructed purely from the key fields of an entity. It is not sufficient to use just link_id, that works only for single-scoped entities (e.g., those that either do not have a scope, or that have a scope which itself does not have a scope). It would break if there was an entity that has a scoped scope (it would only include the scope's link_id in the url, which made it impossible to look up the scope as we missed the link_id of the scope's scope). Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:53:05 +0000 More DI on scope_logic
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:53:05 +0000] rev 674
More DI on scope_logic Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:31:08 +0000 Partial revert
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:31:08 +0000] rev 673
Partial revert Last commit contained some changes that did not belong there, revert them for now. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:26:15 +0000 Some more cleanups in base.Logic
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:26:15 +0000] rev 672
Some more cleanups in base.Logic Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:21:41 +0000 Apply DI on the scope logic
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:21:41 +0000] rev 671
Apply DI on the scope logic Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:21:01 +0000 Removed unused file path_link_name
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:21:01 +0000] rev 670
Removed unused file path_link_name Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:20:44 +0000 Remove unneeded method getSuffixValues
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:20:44 +0000] rev 669
Remove unneeded method getSuffixValues Patch by: Sverre Rabbelier
Fri, 05 Dec 2008 22:54:43 +0000 Some style and typo fixes in different modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:54:43 +0000] rev 668
Some style and typo fixes in different modules. Patch by: Pawel Solyga
Fri, 05 Dec 2008 22:27:04 +0000 Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:27:04 +0000] rev 667
Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module. Patch by: Pawel Solyga
Fri, 05 Dec 2008 22:25:57 +0000 Fix import sorting and docstring typos in soc.views.models.program module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:25:57 +0000] rev 666
Fix import sorting and docstring typos in soc.views.models.program module. Patch by: Pawel Solyga
Fri, 05 Dec 2008 22:25:08 +0000 Fix import sorting in soc.views.sitemap.build module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:25:08 +0000] rev 665
Fix import sorting in soc.views.sitemap.build module. Patch by: Pawel Solyga
Fri, 05 Dec 2008 12:24:02 +0000 Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 12:24:02 +0000] rev 664
Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template. Patch by: Pawel Solyga
Thu, 04 Dec 2008 10:09:38 +0000 Make base.View.create lookup the scope if appropriate
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 04 Dec 2008 10:09:38 +0000] rev 663
Make base.View.create lookup the scope if appropriate Also re-introduce the custom description of the list selection for the redirection. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 23:49:10 +0000 Make use of the new generic key_name by lookup up scope_path
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:49:10 +0000] rev 662
Make use of the new generic key_name by lookup up scope_path This way base classes do not have to look up the 'scope' property, instead they can rely on the base class to do it for them provided they define the 'scope_logic' param. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 23:48:33 +0000 Change the key name to not include entity type
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:48:33 +0000] rev 661
Change the key name to not include entity type This allows for direct lookup by scope_path, rather than having to do more complex things. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 23:48:10 +0000 Introduced django_extra_patterns
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:48:10 +0000] rev 660
Introduced django_extra_patterns This way no classes ever need to override the getDjangoURLPatterns, which results in less code, which is also more clear (that is, it is immediately obvious that a View adds an extra mapping if it sets the new django_extra_patterns value, or that it overrides the mapping when it sets django_patterns_defaults. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:28:16 +0000 Make scope_path required for program
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:28:16 +0000] rev 659
Make scope_path required for program Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:27:52 +0000 Factor out the Group part of Sponsor
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:52 +0000] rev 658
Factor out the Group part of Sponsor This makes it possible to reuse the Group logic. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:27:27 +0000 Rename role.RoleView to role.View
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:27 +0000] rev 657
Rename role.RoleView to role.View Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:27:01 +0000 Cleanups in the views module
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:01 +0000] rev 656
Cleanups in the views module Mainly rename from original_params to new_params (so that the keyword argument in the __init__ method is the same for all). Also use super(View, self) where appropriate. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:26:16 +0000 Cleanups to the logic module
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:26:16 +0000] rev 655
Cleanups to the logic module Mainly converting to super(Logic, self) and adding some missing empty lines while at it. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:05:13 +0000 Fixed the 'New Host' link
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:05:13 +0000] rev 654
Fixed the 'New Host' link Also removed the 'Invite Host' button from the Sponsor view now that the link is working. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:04:38 +0000 Make the 'select entity' View generic
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:04:38 +0000] rev 653
Make the 'select entity' View generic This allows the selection of any entity from an arbitrary View by specifying the 'target view' and the redirect function. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:04:15 +0000 Cleanups in preparation of general selector view
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:04:15 +0000] rev 652
Cleanups in preparation of general selector view Renamed LIST... to DEF_LIST since it is a global definition. Renamed getCreateProgramRedirect to getCreateRedirect since it will work on all entities as it uses params. Added a getParams method to base.View Updated selectSponsor as appropriate. Patch by: Sverre Rabbelier
(0) -300 -100 -50 -30 +30 +50 +100 +300 +1000 tip