Thu, 16 Oct 2008 17:34:10 +0000 Make page argument required for errorResponse and requestLogin functions in simple.py and update affected files. Some keyword argument changes to in user/profile.py. All the changes are based on comments to r817.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 17:34:10 +0000] rev 361
Make page argument required for errorResponse and requestLogin functions in simple.py and update affected files. Some keyword argument changes to in user/profile.py. All the changes are based on comments to r817. http://code.google.com/p/soc/source/detail?r=817 Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 16 Oct 2008 17:30:58 +0000 Rename 'group' to 'entity' in the Django templates
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 17:30:58 +0000] rev 360
Rename 'group' to 'entity' in the Django templates This allows for generic use of these templates. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed
Thu, 16 Oct 2008 16:05:08 +0000 DeadlineExceededError in the recent version of AppEngine lives only in one place so there is no need to try import it from both runtime (deployed) and runtime.apiproxy_errors (dev server) modules anymore.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 16:05:08 +0000] rev 359
DeadlineExceededError in the recent version of AppEngine lives only in one place so there is no need to try import it from both runtime (deployed) and runtime.apiproxy_errors (dev server) modules anymore. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 16 Oct 2008 15:22:41 +0000 Add page=None parameter to all views. Information from page argument (which is soc.logic.site.page.Page object) is going to be used later in views code and for some context values. Fix some indentions in __doc__ strings. Add proper __doc__ string for all() function in sponsor/list.py module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 15:22:41 +0000] rev 358
Add page=None parameter to all views. Information from page argument (which is soc.logic.site.page.Page object) is going to be used later in views code and for some context values. Fix some indentions in __doc__ strings. Add proper __doc__ string for all() function in sponsor/list.py module. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 16 Oct 2008 15:12:00 +0000 Some indention fixes in access.py module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 15:12:00 +0000] rev 357
Some indention fixes in access.py module. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 16 Oct 2008 13:18:59 +0000 Change name of login_request variable in access.py module to login_response.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:18:59 +0000] rev 356
Change name of login_request variable in access.py module to login_response. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 16 Oct 2008 13:16:46 +0000 Change name of getUserFromLinkNameOrDie function to getUserFromLinkNameOr404 and apply changes to affected files.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:16:46 +0000] rev 355
Change name of getUserFromLinkNameOrDie function to getUserFromLinkNameOr404 and apply changes to affected files. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 16 Oct 2008 13:14:13 +0000 Fix mistakes in docs and comments in logic/models/base.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:14:13 +0000] rev 354
Fix mistakes in docs and comments in logic/models/base.py. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 16 Oct 2008 09:14:26 +0000 Log Fix not working after click the "Site Settings" in home page. templete wasn't updated when soc/app/soc/logic/site/map.py was update.
Chen Lunpeng <forever.clp@gmail.com> [Thu, 16 Oct 2008 09:14:26 +0000] rev 353
Log Fix not working after click the "Site Settings" in home page. templete wasn't updated when soc/app/soc/logic/site/map.py was update. Patch by: Chen Lunpeng Review by: to-be-reviewed
Thu, 16 Oct 2008 09:05:02 +0000 Remove #docsummary class from css file as it is not used anymore. Add #createdby class in css file. Fix typo in docs/profile.html template. Put document content in <div class='content'>.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 09:05:02 +0000] rev 352
Remove #docsummary class from css file as it is not used anymore. Add #createdby class in css file. Fix typo in docs/profile.html template. Put document content in <div class='content'>. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 16 Oct 2008 04:37:13 +0000 Eliminate the Work.abstract property and move the Document.content property
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:37:13 +0000] rev 351
Eliminate the Work.abstract property and move the Document.content property to Work.content instead. Update affected views, and re-base some classes that were deriving from Document just to get Document.content to now be derived from Work instead. The Document class now has a "pass" body with no additional properties. It is debatable whether Work should become Document, since I am not sure that we plan to be able to generically display, say, a Quiz or a Question (which are Works) on the home page (which can only specifically display a Document, or now, the basic Work entity...). Patch by: Todd Larsen Review by: to-be-reviewed
Thu, 16 Oct 2008 04:30:26 +0000 "new" is a little bit redundant in the short_name of sidebar menu items that
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:30:26 +0000] rev 350
"new" is a little bit redundant in the short_name of sidebar menu items that already begin with "Create...", since that implies the result will be something new. Patch by: Todd Larsen Review by: to-be-reviewed
Thu, 16 Oct 2008 04:27:07 +0000 A quick-and-dirty way to create non-link sub-menu dividers, plus a TODO on
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:27:07 +0000] rev 349
A quick-and-dirty way to create non-link sub-menu dividers, plus a TODO on how this should be formalizes to not be so hacky. This change was inspired by the ever-growing "Site" sidebar menu. Patch by: Todd larsen Review by: to-be-reviewed
Wed, 15 Oct 2008 21:31:36 +0000 Should have been part of recent r806.
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:31:36 +0000] rev 348
Should have been part of recent r806. Patch by: Todd Larsen Review by: to-be-reviewed
Wed, 15 Oct 2008 21:27:47 +0000 First phase of making the / (site/home) view generic enough to use it for
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:27:47 +0000] rev 347
First phase of making the / (site/home) view generic enough to use it for Sponsor "home" page, Program "home" page, Organization "home" page, etc. when combined with HomeSettings. First phase of addressing this issue: http://code.google.com/p/soc/issues/detail?id=64 by factoring "Site Settings" apart from the site/home stuff. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1405
(0) -300 -100 -15 +15 +100 +300 +1000 tip