Add missing ugettext_lazy for string in soc.views.user.profile module. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix missing keyword argument in soc.views.user.profile.create() function when calling edit(). Patch by: Pawel Solyga Review by: to-be-reviewed

Change Sponsor delete url from /site/sponsor/profile/<link_name>/delete to /site/sponsor/profile/delete/<link_name> to match convention used in Document delete url. Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed not working to edit a doc that selected from the docs list view. soc/templates/soc/docs/list/docs_row.html not full updated. Patch by: Chen Lunpeng Review by: to-be-reviewed

Change the "Site home page Document is missing" default text to give instructions similar to those in the Site Settings form. Patch by: Todd Larsen Review by: to-be-reviewed

Remove another now-empty templates directory. Patch by: Todd Larsen Review by: to-be-reviewed

Nothing left in this templates directory, so remove it. Patch by: Todd Larsen Review by: to-be-reviewed

Refactor various site views into more generic locations, in preparation for using access permissions to decide the fuctionality in the view, instead of having lots of cut-and-paste copies of the same view functions. site/home.py into more generic home.py site/settings.py into more generic settings.py site/docs/list.py into more generic docs/list.py site/docs/edit.py into more generic docs/edit.py Patch by: Todd Larsen Review by: to-be-reviewed

Add a style that appears in form error lists produced by Django Forms and make it match the style of the existing td.formfielderror used by the field_as_table_row helper. Patch by: Todd Larsen Review by: to-be-reviewed

Create package for soon-to-be-refactored group/home.py and group/settings.py packages. Patch by: Todd Larsen Review by: to-be-reviewed

Add the Page object to the context of each view. Update templates to make use of the newly-available page.long_name and page.short_name. Patch by: Todd Larsen Review by: to-be-reviewed

Add the Page object to the context of each view method. Also, add some missing Arg: sections to __doc__ strings and fix the missing context issue in editPost() and editGet(). Patch by: Todd Larsen Review by: to-be-reviewed

Formalize the concept of a NonPage that can appear in the site-map, useful for non-clickable sidebar menu divisions, for example. Convert "hacky" fake Pages into NonPages in the site-map. Also, pass page=self to every view as a keyword argument when generating the Django urlpatterns. Patch by: Todd Larsen Review by: to-be-reviewed

Add a relative symlink pointing at ../rietveld/upload.py in thirdparty/chromium so that gcl.py can import the thirdparty/rietveld/upload.py module. Patch by: Todd Larsen Review by: to-be-reviewed

Replace missing: from google.appengine.api import users that appears to have been removed by r824. Needed by call in the edit() view to users.get_current_user(). Patch by: Todd Larsen Review by: to-be-reviewed

Replace GROUP_TYPE_PLURAL and GROUP_TYPE_SHORT constants in Group models with more generic TYPE_NAME, TYPE_NAME_SHORT, TYPE_NAME_PLURAL names and apply changes in affected files. Use ugettext_lazy for TYPE_NAME and TYPE_NAME_PLURAL constants. This approach is similar to the upcoming refactor of views. Patch by: Pawel Solyga Review by: to-be-reviewed

Move TODO about isDeletable Sponsor logic method to sponsor.py module and extend a little bit doc string. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove not needed request argument in view decorator. Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed not working after click the "List Site Sponsors" in site menu bar. due to wrongly imported modules. Patch by: Chen Lunpeng Review by: to-be-reviewed

Create decorators module in view/helper and add view decorator that catches exceptions like DeadlineExceededError, MemoryError, AssertionError (this code is being moved from respond function). Add view decorator to all view functions. In addition remove not needed imports from all affected files and fix too long lines. Patch by: Pawel Solyga Review by: to-be-reviewed

Last commit missed the new __init__.py file

Add a framework for generic views This commit does not enable the new code, as such there should be no change in functionality. In order to use the new code the maps.py file should be updated to point at the new views/models/sponsor.py module. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

entity_type is not the same as entity_type_short The previous commit wrongfully assumed this. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Make page argument required for errorResponse and requestLogin functions in simple.py and update affected files. Some keyword argument changes to in user/profile.py. All the changes are based on comments to r817. http://code.google.com/p/soc/source/detail?r=817 Patch by: Pawel Solyga Review by: to-be-reviewed

Rename 'group' to 'entity' in the Django templates This allows for generic use of these templates. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

DeadlineExceededError in the recent version of AppEngine lives only in one place so there is no need to try import it from both runtime (deployed) and runtime.apiproxy_errors (dev server) modules anymore. Patch by: Pawel Solyga Review by: to-be-reviewed

Add page=None parameter to all views. Information from page argument (which is soc.logic.site.page.Page object) is going to be used later in views code and for some context values. Fix some indentions in __doc__ strings. Add proper __doc__ string for all() function in sponsor/list.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Some indention fixes in access.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Change name of login_request variable in access.py module to login_response. Patch by: Pawel Solyga Review by: to-be-reviewed

Change name of getUserFromLinkNameOrDie function to getUserFromLinkNameOr404 and apply changes to affected files. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix mistakes in docs and comments in logic/models/base.py. Patch by: Pawel Solyga Review by: to-be-reviewed

Log Fix not working after click the "Site Settings" in home page. templete wasn't updated when soc/app/soc/logic/site/map.py was update. Patch by: Chen Lunpeng Review by: to-be-reviewed

Remove #docsummary class from css file as it is not used anymore. Add #createdby class in css file. Fix typo in docs/profile.html template. Put document content in <div class='content'>. Patch by: Pawel Solyga Review by: to-be-reviewed

Eliminate the Work.abstract property and move the Document.content property to Work.content instead. Update affected views, and re-base some classes that were deriving from Document just to get Document.content to now be derived from Work instead. The Document class now has a "pass" body with no additional properties. It is debatable whether Work should become Document, since I am not sure that we plan to be able to generically display, say, a Quiz or a Question (which are Works) on the home page (which can only specifically display a Document, or now, the basic Work entity...). Patch by: Todd Larsen Review by: to-be-reviewed

"new" is a little bit redundant in the short_name of sidebar menu items that already begin with "Create...", since that implies the result will be something new. Patch by: Todd Larsen Review by: to-be-reviewed

A quick-and-dirty way to create non-link sub-menu dividers, plus a TODO on how this should be formalizes to not be so hacky. This change was inspired by the ever-growing "Site" sidebar menu. Patch by: Todd larsen Review by: to-be-reviewed

Should have been part of recent r806. Patch by: Todd Larsen Review by: to-be-reviewed

First phase of making the / (site/home) view generic enough to use it for Sponsor "home" page, Program "home" page, Organization "home" page, etc. when combined with HomeSettings. First phase of addressing this issue: http://code.google.com/p/soc/issues/detail?id=64 by factoring "Site Settings" apart from the site/home stuff. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1405

Add the empty directory where site/home/edit.html is moving, to see if this fixes a problem with gcl.py.

Update TinyMCE wiget code according to r783. I hope I did it correctly this time. http://code.google.com/p/soc/source/detail?r=783 Patch by: Pawel Solyga Review by: to-be-reviewed

Change verbose_name of founder property in Group model from "Created by" to "Founded by". Add GROUP_TYPE_SHORT and GROUP_TYPE_PLURAL for all models that inherit from Group and use that values in templates and contexts. Assume that group_type, group_type_short and group_type_plural are defined in context and remove not needed ifs in templates. Rename "Linkname" to "Link name" in list/group_heading.html template. Patch by: Pawel Solyga Review by: to-be-reviewed

Remov "founder" text from the first line of edit.py, this is fix to r799 commit. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove the proposed WorksAuthors many:many relation and promote the "founder" property from Document up to Work. Update all subclasses of Work and any affected views accordingly. This addresses review comments here: http://code.google.com/p/soc/source/detail?r=786 Patch by: Todd Larsen Review by: to-be-reviewed

Fixed the evil black logo.

Make this file excutable by default.

Define the Models for implementing Quizzes (collections of Questions) and their Responses (collections of Answers to those Questions). These Models would form the basis of storage for such items as: Terms of Service (Quiz) Question ("I agree...") Response -> Answer (answer to "I agree..." confirmation) solution ("Yes" Answer to the "I agree..." Question) Mentor and Student surveys (Quiz) Questions (including "Pay this student?") Response -> Answers solution ("Yes" Answer to the "Pay this student?" Question) Organization applications Student Proposal review, comment, and scoring system GHOP task tracking (a specific task list item would be a Quiz) Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Chen Lunpeng Review URL: http://codereviews.googleopensourceprograms.com/1403

Show "Created by" read-only field in Document Edit view. Update size of TinyMCE widget in Document Edit/Create views. Change user property name to founder in Document model and update files according to this change (now founder is used in Group and Document models). Remove not used variables and imports in views/site/docs/edit.py. Refactor EditForm and CreateForm in views/site/docs/edit.py so that EditForm inherits from CreateForm and just extends it. Patch by: Pawel Solyga Review by: to-be-reviewed

Show "Created by" read-only field in Sponsor Edit view. Fix function keyword arguments in sponsor/list.py to follow our PythonStyleGuide. Sponsor founder property is not updated anymore when editing Sponsor profile, it's just saved once when creating Sponsor profile. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix not working docs show view. Document show view wasn't updated when the logic refactor was made. Patch by: Pawel Solyga Review by: to-be-reviewed

Changes to TinyMCE widget that enable to pass mce_settings in the class constructor and that way update default settings if needed. Patch by: Pawel Solyga Review by: to-be-reviewed

Add nameHomeSettings function to key_name module. Add HomeSettings logic. Patch by: Pawel Solyga Review by: to-be-reviewed

Update comments in models/group.py (changed Optional to Required). Add verbose_name to founder property in Group model. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix bug that caused Lookup user by User Account not to work properly. Basically wrong parameter to models.user.logic.getFromFields(). Patch by: Pawel Solyga Review by: to-be-reviewed

Add deleted in r732 (don't know why) functionality that displays custom Error page when linkname in Developer User Profile url doesn't exist (/site/user/profile/<not_existing_linkname>). Patch by: Pawel Solyga Review by: to-be-reviewed

Add underscore in two word div class names in templates (nick_name, short_name, partial_path). Patch by: Pawel Solyga Review by: to-be-reviewed

Add is_featured boolean property to the Work model, so that Works can be designated as "featured" items in various places in the UI. This will be used to allow Sponsors, Programs, and Organizations to select Documents that should be included in their sidebar menus. Perhaps featured "site" Documents, such as site-wide Terms of Service, should probably be listed below the "User (sign-out)" menu, since the User will have to read and agree to these before being allowed to use the site. A collapsable Javascript sidebar is probably going to be needed soon... Patch by: Todd Larsen Review by: to-be-reviewed

Add missing blank lines, clean up the doc string and remove white spaces at the end of the lines in reflistprop. Patch by: Pawel Solyga Review by: to-be-reviewed

Move <div id='notice'> into notice block in base.html template. Change formatting of notice block to make it much easier to "parse" visually. This patch is based on comments to r722. http://code.google.com/p/soc/source/detail?r=722 Patch by: Pawel Solyga Review by: to-be-reviewed

Add a third-party ReferenceListProperty class. This is going to be used to contain the references to Questions that make up a Quiz. Patch by: Todd Larsen Review by: to-be-reviewed

Fix some defects for lookup user view. More information about the patch can be found under the link below. http://groups.google.com/group/melange-soc-dev/browse_thread/thread/5d378c8d3679945f/d1e7cc3a53adda4e Patch by: Chen Lunpeng Review by: Pawel Solyga