Sun, 25 Jan 2009 12:28:26 +0000 Added Club Members to SoC.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 12:28:26 +0000] rev 980
Added Club Members to SoC. Every user can request to become a Club Member. Club Admins can invite users. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sun, 25 Jan 2009 12:22:53 +0000 Added checkCanMakeRequestToGroup to access.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 12:22:53 +0000] rev 979
Added checkCanMakeRequestToGroup to access.py. Note that states for a group have not been implemented yet, so a TODO has been added for this check. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sun, 25 Jan 2009 12:20:35 +0000 Moved getGroupEntityFromScopePath to logic/models/role.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 12:20:35 +0000] rev 978
Moved getGroupEntityFromScopePath to logic/models/role.py. Also removed a TODO that has been done :). Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sun, 25 Jan 2009 11:44:25 +0000 Have /entity/pick return a JSON object instead of a user view
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 11:44:25 +0000] rev 977
Have /entity/pick return a JSON object instead of a user view This is in preparation of a patch that will add a more fancy picker with JS. Patch by: Sverre Rabbelier
Sun, 25 Jan 2009 11:31:40 +0000 Add simplejson folder to build.sh script.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 25 Jan 2009 11:31:40 +0000] rev 976
Add simplejson folder to build.sh script. Patch by: Pawel Solyga Reviewed by: to-be-reviewed
Sun, 25 Jan 2009 11:31:15 +0000 Add simplejson library to app folder.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 25 Jan 2009 11:31:15 +0000] rev 975
Add simplejson library to app folder. Patch by: Pawel Solyga Reviewed by: to-be-reviewed
Sun, 25 Jan 2009 09:10:23 +0000 Removed unused method from access.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 09:10:23 +0000] rev 974
Removed unused method from access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sun, 25 Jan 2009 00:04:11 +0000 Do not pass around request anymore in buildSidebar
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 00:04:11 +0000] rev 973
Do not pass around request anymore in buildSidebar It is no longer needed since checkAccess doesn't require it. Patch by: Sverre Rabbelier
Sun, 25 Jan 2009 00:02:41 +0000 Remove the request and arg parameter from the checkAccess call
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 00:02:41 +0000] rev 972
Remove the request and arg parameter from the checkAccess call They are obsolete with the introduction of kwargs (args was never needed in the first place). Patch by: Sverre Rabbelier
Sun, 25 Jan 2009 00:01:19 +0000 Use getSingleton in getUniversalContext
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 00:01:19 +0000] rev 971
Use getSingleton in getUniversalContext Patch by: Sverre Rabbelier
Sat, 24 Jan 2009 23:56:34 +0000 Use ugettext instead of ugettext_lazy
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 24 Jan 2009 23:56:34 +0000] rev 970
Use ugettext instead of ugettext_lazy Reports from Matthew Wilkes indicate that the regular form of ugettext works just fine. The downside of ugettext_lazy is that it prevents pages containing ugettext_lazy-ed text cannot be memcached, since they cannot be pickled. Patch by: Sverre Rabbelier
Sat, 24 Jan 2009 21:38:28 +0000 Brown paper bag fix.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 21:38:28 +0000] rev 969
Brown paper bag fix. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 20:51:51 +0000 Fixed a bug in _editPost for club_admin and host.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 20:51:51 +0000] rev 968
Fixed a bug in _editPost for club_admin and host. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 20:44:32 +0000 Changed clean_url to work with dynaform.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 20:44:32 +0000] rev 967
Changed clean_url to work with dynaform. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 20:17:35 +0000 Fixed a bug in _oncreate in soc/logic/models/club.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 20:17:35 +0000] rev 966
Fixed a bug in _oncreate in soc/logic/models/club.py. Non-existing fields were set. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 18:21:50 +0000 Changed user_logic call to it's convenience function getForCurrentAccount.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 18:21:50 +0000] rev 965
Changed user_logic call to it's convenience function getForCurrentAccount. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 17:09:02 +0000 Coding style fix in views/models/role.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 17:09:02 +0000] rev 964
Coding style fix in views/models/role.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 17:07:26 +0000 Parameterized patterns in role.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 17:07:26 +0000] rev 963
Parameterized patterns in role.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 16:39:34 +0000 Added request creation and processing to role.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 16:39:34 +0000] rev 962
Added request creation and processing to role.py. This is used if you want to request to become a certain role for a group. For instance becoming a club member. The process request view will also be used to cancel outstanding invites might this be necessary. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 14:14:14 +0000 Add Madhusudan.C.S to AUTHORS. Fix docstring parameters list in soc.logic.models.base module Base class getForFields method.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 14:14:14 +0000] rev 961
Add Madhusudan.C.S to AUTHORS. Fix docstring parameters list in soc.logic.models.base module Base class getForFields method. Patch by: Madhusudan.C.S Reviewed by: Pawel Solyga
Sat, 24 Jan 2009 14:14:11 +0000 Added checkCanProcessRequest in access.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 14:14:11 +0000] rev 960
Added checkCanProcessRequest in access.py. This is used in the upcoming Request patch. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 12:54:59 +0000 Some style guide fixes, docstring fixes and removal of unused imports in different modules. Rename acceptInvite view variable to accept_invite in soc.views.models.host module to comply to our style guide.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:54:59 +0000] rev 959
Some style guide fixes, docstring fixes and removal of unused imports in different modules. Rename acceptInvite view variable to accept_invite in soc.views.models.host module to comply to our style guide. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 12:51:47 +0000 Fix some missing dots in access and club_admin modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:51:47 +0000] rev 958
Fix some missing dots in access and club_admin modules. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 12:50:59 +0000 Add missing parameter description to docstring of soc.views.models.base module methods.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:50:59 +0000] rev 957
Add missing parameter description to docstring of soc.views.models.base module methods. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 12:47:21 +0000 Make select link in _as_table_row.html a nice button instead of <a href>.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:47:21 +0000] rev 956
Make select link in _as_table_row.html a nice button instead of <a href>. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 12:45:57 +0000 Remove extra whitespaces and fix too long lines in soc.logic.helper.request module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:45:57 +0000] rev 955
Remove extra whitespaces and fix too long lines in soc.logic.helper.request module. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 11:25:15 +0000 Remove unused imports from soc.models.club_admin model.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:25:15 +0000] rev 954
Remove unused imports from soc.models.club_admin model. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 11:24:45 +0000 Remove extra blank lines in soc.views.models.request module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:24:45 +0000] rev 953
Remove extra blank lines in soc.views.models.request module. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 11:24:07 +0000 Rename acceptInvite view variable to accept_invite to comply to our style guide. Remove unused imports. Add missing blank lines in soc.views.models.club_admin module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:24:07 +0000] rev 952
Rename acceptInvite view variable to accept_invite to comply to our style guide. Remove unused imports. Add missing blank lines in soc.views.models.club_admin module. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 11:12:07 +0000 Rename processInvite view variable to process_invite to comply to our style guide. Remove some not needed whitespaces. Fix listSelf method parameters docstring in soc.views.models.request module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:12:07 +0000] rev 951
Rename processInvite view variable to process_invite to comply to our style guide. Remove some not needed whitespaces. Fix listSelf method parameters docstring in soc.views.models.request module. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 11:10:22 +0000 Added missing dot to access.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 11:10:22 +0000] rev 950
Added missing dot to access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 11:07:16 +0000 Check if timeline exists and when somebody tries to edit non existing timelime display error message. Add TODO regarding error message customization for Timeline. Add support for calendar widget in timeline for both gsoc and ghop programs (gsoc was hardcoded before).
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:07:16 +0000] rev 949
Check if timeline exists and when somebody tries to edit non existing timelime display error message. Add TODO regarding error message customization for Timeline. Add support for calendar widget in timeline for both gsoc and ghop programs (gsoc was hardcoded before). Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 11:04:15 +0000 Add missing blank lines and remove unused checkIsInvited function from soc.views.helper.access module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:04:15 +0000] rev 948
Add missing blank lines and remove unused checkIsInvited function from soc.views.helper.access module. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 10:59:28 +0000 Rename soc/request/list/row.html template column class "to" to "for" since the name changed in header template.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 10:59:28 +0000] rev 947
Rename soc/request/list/row.html template column class "to" to "for" since the name changed in header template. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 10:57:53 +0000 Add missing dots in soc.views.helper.redirects module function docstrings.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 10:57:53 +0000] rev 946
Add missing dots in soc.views.helper.redirects module function docstrings. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 10:56:18 +0000 Little change in soc.logic.hlper.request module completeRequestForRole function docstring.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 10:56:18 +0000] rev 945
Little change in soc.logic.hlper.request module completeRequestForRole function docstring. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 24 Jan 2009 10:19:17 +0000 Refactored invite system from club_admin to role to make the system work with host as well.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 10:19:17 +0000] rev 944
Refactored invite system from club_admin to role to make the system work with host as well. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 10:18:30 +0000 Fixed an access related bug in checkIsClubAdminForClub.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 10:18:30 +0000] rev 943
Fixed an access related bug in checkIsClubAdminForClub. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 00:27:36 +0000 Fixed bug in access.py concerning host checks.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 00:27:36 +0000] rev 942
Fixed bug in access.py concerning host checks. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Sat, 24 Jan 2009 00:07:34 +0000 Add a warning about discarding unsaved changes
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 24 Jan 2009 00:07:34 +0000] rev 941
Add a warning about discarding unsaved changes Also set the colspan of the label (on seperate row) to max. Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 23:42:07 +0000 Changed the access checks to comply with state in request.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 23:42:07 +0000] rev 940
Changed the access checks to comply with state in request. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Fri, 23 Jan 2009 22:57:10 +0000 Make reference picker work for create too
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 22:57:10 +0000] rev 939
Make reference picker work for create too Caveat, it only works for one reference atm. Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 22:20:20 +0000 Brown paper bag fix
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 22:20:20 +0000] rev 938
Brown paper bag fix Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 22:17:49 +0000 Do not crash if an invalid field name is entered
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 22:17:49 +0000] rev 937
Do not crash if an invalid field name is entered Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 21:22:09 +0000 Enable pick links for all the references we have
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:22:09 +0000] rev 936
Enable pick links for all the references we have Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 21:20:33 +0000 Adust the as_table tag to render a pick link if appropriate
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:20:33 +0000] rev 935
Adust the as_table tag to render a pick link if appropriate The templates are adjusted to pass on a 'reference' value, which is the url_name of the view from which the entity should be picked. The as_table (and related) function(s) construct and then pass on this argument and enable takes_contex so that we have access to the context of the enclosing template. We only extract ReferenceProperties that end with '_link_id' since that is how all RP's are currently named. It is not possible to create a field with the same name as the RP, as GAE will try to interpret it's contents as the key of an entity before even calling any function we can override. Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 21:18:39 +0000 Add a 'pick' view to the appropriate views
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:18:39 +0000] rev 934
Add a 'pick' view to the appropriate views Only views that represent entities that are pointed to by a ReferenceProperty at some point are considered 'appropriate'. Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 21:17:01 +0000 Added a 'pick' view
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:17:01 +0000] rev 933
Added a 'pick' view This view can be used to pick a specific document and then redirect to another view. Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 21:15:16 +0000 Add redirects for the new pick view
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:15:16 +0000] rev 932
Add redirects for the new pick view Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 21:04:45 +0000 Add a simple access check for a picker
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:04:45 +0000] rev 931
Add a simple access check for a picker The picker page should not be accessible if the required GET args are not present. Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 17:51:35 +0000 Added missing changes from r1522.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 17:51:35 +0000] rev 930
Added missing changes from r1522. Eclipse found it funny not to save resources ^_^. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Fri, 23 Jan 2009 17:41:30 +0000 Renamed redirect methods to comply with the rest of the module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 17:41:30 +0000] rev 929
Renamed redirect methods to comply with the rest of the module. Added use for getInviteAcceptedRedirect in the soc/views/models/request.py process_invite view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Fri, 23 Jan 2009 17:07:54 +0000 Replaced the boolean properties in soc/models/request.py with a state property.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 17:07:54 +0000] rev 928
Replaced the boolean properties in soc/models/request.py with a state property. new : new Request group_accepted : The group has accepted this request completed : This request has been handled either following a creation of the role entity rejected : This request has been rejected by either the user or the group ignored : The request has been ignored by the group and will not give the user access to create the role Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Fri, 23 Jan 2009 16:54:46 +0000 Restore context in deny() page
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 16:54:46 +0000] rev 927
Restore context in deny() page Now that we know when the sidebar is doing the access checks we can safely construct a new context in deny (without having to worry that it will try to do more access checks that result in deny, which will call for a new context... etc). Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 16:53:19 +0000 Bugfixes to last commit
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 16:53:19 +0000] rev 926
Bugfixes to last commit Access rights for 'home' pages and an errornous endif tag. Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 16:23:01 +0000 Removed club property from club_admin model.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 16:23:01 +0000] rev 925
Removed club property from club_admin model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed
Fri, 23 Jan 2009 16:21:28 +0000 Generate proper html instead of having nested <td> tags
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 16:21:28 +0000] rev 924
Generate proper html instead of having nested <td> tags Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 15:32:58 +0000 Hook up the 'home' view for site and program
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 15:32:58 +0000] rev 923
Hook up the 'home' view for site and program Also point to it in the sidebar's "home" link. Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 15:31:13 +0000 Generate the 'edit settings' link dynamically
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 15:31:13 +0000] rev 922
Generate the 'edit settings' link dynamically We used to point to '/site/edit', which is rather lame for a generic presence template (especially since site has it's own template). Patch by: Sverre Rabbelier
Fri, 23 Jan 2009 15:29:42 +0000 Create a new 'home' view for Presences
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 15:29:42 +0000] rev 921
Create a new 'home' view for Presences This also restores the 'show' view for Presences as there is no need to hide it with the 'home' view anymore. Patch by: Sverre Rabbelier
(0) -300 -100 -60 +60 +100 +300 +1000 tip