Added a generic user page

Preparation for generic user views Added a getSuffixValues method that is meant to allow for having a non-public field as key_name. Also added support for a key-name field being embeded in the form so that if the key-fields change the old key_name is not lost.

Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.

Fixed a typo in id_user

Fix create redirect

Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.

Minor fix to sponsor missing from the site restructure

Add a Google Maps property to Site Settings Patch by: Lennard de Rijk <ljvderijk@gmail.com> Reviewed by: Sverre Rabbelier

Fixes to {Site,Home}Settings Also improved help text on HomeSettings partial_path and link_name.

Fixing the string for the default home page

Making the docs template prettier

Allowing + and - to be clicked in the menu

Fix not working former_ids. Add support for "Invalid accounts". Now when id from former_ids tries to create a profile "This account is invalid." error message is displayed. Compare emails in lower cases to prevent changing User email to the same email with different character casing (needs some more testing). Patch by: Pawel Solyga

Some indention fixes and remove not needed variable in soc.logic.models.base module. Patch by: Pawel Solyga

Refactoring of {site/home}_settings to make them use base.View This makes the way for deleting the key_name.py module

Major site restructuring, also deleting of many unused or obsolete documents The new structure is as follows: <entity>/list - list all <entitie>s <entity>/create - create a new <entity> <entity>/show/<key fields> - public page for <entity> <entity>/edit/<key fields> - edit a <entity> <entity>/delete/key fields> - delete a specific entity

Fix sponsor key field extraction When extracting key field there is no sponsor or user object, instead only their link names are known.

Implements base.Logic functions in home_settings, site_settings and work This patch implements the base.Logic funtions needed for making logic/key_name.py obsolete. This patch defines the needed functions in home_settings, site_settings and work. All modules in logic/models now have these functions defined. logic/models/site_settings.py now inherits from logic/models/home_settings.py because of their similar connection in the corresponding models. Please note that the self._keyName for these two modules still points to logic/key_name.py since entity_type is still used in views/home.py. A partial_path and link_name were added to HomeSettings as requested by SRabbelier.

Fix wrong redirect when changing partial path or link name. Remove an unnecessary assignment in logic/models/base.py that would generate an error when an entity did not exist. Patch by: Lennard de Rijk Review by: Pawel Solyga

Fix not working former ids feature of User Profile Developer Edit view. Add missing Error exception class to soc.logic.models.base module. Patch by: Pawel Solyga

Third-party Javascript that should have been part of r891. Same license as JQuery. Patch by: Todd Larsen

Minor fixes needed for generic key name We no longer try to retreive an entity when there are unset fields. This sort of makes 'getIfFields' obsolete, since we check if fields now anyway. This is needed because getKeyFieldsFromDict expects the fields to be set. Also a minor fix in a Django template so that the generic 'edit' page has a working delete button again.

Quick fix to fix user profile creation This change will be obsolete when User refactoring is finished, but it will fix the build untill then.

Django Fix according to code.djangoproject.com/attachement/ticket/9115/check_for_unlink_in_temp.patch

Add missing TODOs to soc.logic.models classes. Fix comments format in base.Logic class. Changes based on comments to r972. http://code.google.com/p/soc/source/detail?r=972 Patch by: Pawel Solyga

Refactor out the abundance of dictionary (un)packing Instead, keep the dict packed once packed, and only unpack it when needed.

Added key field definitions to the User logic This is the first part of making the User views generic.

Add a getForFields method It allows for generic queries with restrictions specified in a dictionary.

Add a generic method for getting a Keyname This patch will make logic/key_name.py obsolete in the future when everything is compliant with base.logic. This also makes the naming of already compliant logic modules generic and also fixes the _name field to be consistent with the naming in key_name.py. Note: This does not use Group/Sponsor, Group/School, Group/Organisation or Group/Club. Patch by: "Lennard de Rijk" <rijk0214@gmail.com> Reviewed by: Sverre Rabbelier

Added a missing 'pass' statement

Create a Site Settings sub-menu

Fixed typo in e-mail address Instead of 'sverre@rabbelier.nl' everything read 'sverer@rabbelier.nl'

Fixed typo in access check Instead of checking for 'public' the rights for 'edit' were checked.

The pretty blue triangles from Google Code! Patch by: Todd Larsen

Add tooltips style display of help_text, instead of widening the form with another (often ridiculously large) column. Also, version the .css and .js files so that browsers won't display the wrong cached one when we change something. Patch by: Dmitri Gaskin, Todd Larsen Review by: Todd Larsen

Change Site and User sub-menus so that the "header" entry for those sub-menus is not a clickable link, but instead just a placeholder. Patch by: Todd Larsen

Use nice "plus" and "minus" symbols from Google Code, instead of current triangles, for sidebar menu. Patch by: Todd Larsen

Add javascript expandable menus. Patch by: Dmitri Gaskin Review by: Augie Fackler

Add jQuery. Patch by: Dmitri Gaskin Review by: Augie Fackler

Remove bogus import from a previous iteration.

Remove newlines in sidebar

Start a test system for the webapp itself.

Always check if a user filled in a user profile Also, if there is no checks defined, still do the general checks.

Do not include attributes which are inherited. Also some extra comments. Review URL: http://codereviews.googleopensourceprograms.com/1603

Run with Python 2.5

Fix typo in models/public.html template. Changes in Host Public Profile template (new header title and deletion of some fields). Patch by: Pawel Solyga Review by: to-be-reviewed

Fix mistakes in Host List templates. Change Host List second row to Sponsor name instead of Sponsor link name. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename Host list templates from group_<something> to host_<something> and move then to soc/host/list folder. Update affected files with new paths. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix Sponsor profile edit/create template. Don't show "View Sponsor Public Profile" link and Delete button in Create Sponsor view. Patch by: Pawel Solyga Review by: to-be-reviewed

Addresses comments to r866. http://code.google.com/p/soc/source/detail?r=866 Patch by: Pawel Solyga Review by: to-be-reviewed

Moved all key_name related things to the logic modules Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Addressed comments by Pawel and Todd Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Inherit from BaseForm in all forms instead of from DbModelForm. This change doesn't include changes to templates and usage of as_table everywhere (work in progress). Patch by: Pawel Solyga Review by: to-be-reviewed

Fix not working Create views (committed in r864). Check if entity exist in constructKeyNameSuffix funtion and apply changes to affected files. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix some wrong paths to templates (committed in r864). Patch by: Pawel Solyga Review by: to-be-reviewed

Add Google Analytics support to Site Settings. The reason I created additional SettingsValidationForm is because you cannot inherit from Form that has already defined Meta class, so it's sort of workaround for that. I didn't want to have same validation functions in both Form classes. Patch by: Pawel Solyga Review by: to-be-reviewed

Added a Host profile and generalized some views Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Some more improvements to the generic view code Namely getEmptyKeyFields and constructKeyNameSuffix, some whitespace issues, and a few extra fields in the context. Patch by: Sverre Rabbelier Reviewd by: to-be-reviewed

Incorperated suggestions by Todd Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Make use of the new generic views Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Added a generic version of the Document views Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Various improvements to the generic View code Among others: * Added the 'page' argument to the simple.errorResponse call * Pass the result of getEmptyKeyFields to edit() in create() * Fix typo's in error responses * Fixed a todo to properly redirect on create * Made editPost return something when the form is not valid * Added an _editGet hook Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Rename 'existing_doc' and 'document' to entity Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Remove the google search box and the google analytics page These are left over from the mockups (removed because they caused long wait times when no internet connection is available).

Improve the error message for getIfFields Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Add documentation in response to Pawel's comments: http://code.google.com/p/soc/source/detail?r=832 Patch by: Todd Larsen Review by: to-be-reviewed

Add BaseForm class to soc.views.helper.forms module (work in progress). This changes the way as_table function displays the form (for more information have a look into doc string). BaseForm is going to be used for all forms in Melange in future. Right now it's still missing custom form errors labels and "required" text in 3rd column, but that's added as TODO and I'm working on it. Patch by: Pawel Solyga Review by: to-be-reviewed

Add colon after label in _field_as_table_row template for consistency reasons with form.as_table output. Patch by: Pawel Solyga Review by: to-be-reviewed

Add "View Sponsor Public Profile" to Sponsor Edit view template. Remove not needed <p> in home/public.html template. Add missing '$' at the end of some urls in site/map.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Address comments to r844 and r845. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove unused imports, fix too long lines and indentions. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix identions, too long lines, unused imports and some other mistakes. Patch by: Pawel Solyga Review by: to-be-reviewed

Add pylint configuration file (pylintrc) and do_pylint.sh script which runs pylint checkers on Melange code using pylintrc file as config. do_pylint.sh as default shows additional information like reports, TODOs, code similarities and unused imports, but you can run it in silent mode (--silent) which disables all of that. The only problem with unused imports in pylint right now is that it doesn't work in the situation described in last example at http://code.google.com/p/soc/wiki/PythonStyleGuide#Packages, so sometimes we get unused import soc when we actually shouldn't. However this can be fixed by writing pylint plugins (our own checkers) in future. Patch by: Pawel Solyga Review by: to-be-reviewed

Addressed comments by Todd on r822 Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Fix identions in reflistprop module. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove not used imports in models. Fix missing spaces in models when operator not preceded by a space. Add missing ugettext_lazy import to Proposal model. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing ugettext_lazy for string in soc.views.user.profile module. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix missing keyword argument in soc.views.user.profile.create() function when calling edit(). Patch by: Pawel Solyga Review by: to-be-reviewed

Change Sponsor delete url from /site/sponsor/profile/<link_name>/delete to /site/sponsor/profile/delete/<link_name> to match convention used in Document delete url. Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed not working to edit a doc that selected from the docs list view. soc/templates/soc/docs/list/docs_row.html not full updated. Patch by: Chen Lunpeng Review by: to-be-reviewed

Change the "Site home page Document is missing" default text to give instructions similar to those in the Site Settings form. Patch by: Todd Larsen Review by: to-be-reviewed

Remove another now-empty templates directory. Patch by: Todd Larsen Review by: to-be-reviewed

Nothing left in this templates directory, so remove it. Patch by: Todd Larsen Review by: to-be-reviewed

Refactor various site views into more generic locations, in preparation for using access permissions to decide the fuctionality in the view, instead of having lots of cut-and-paste copies of the same view functions. site/home.py into more generic home.py site/settings.py into more generic settings.py site/docs/list.py into more generic docs/list.py site/docs/edit.py into more generic docs/edit.py Patch by: Todd Larsen Review by: to-be-reviewed

Add a style that appears in form error lists produced by Django Forms and make it match the style of the existing td.formfielderror used by the field_as_table_row helper. Patch by: Todd Larsen Review by: to-be-reviewed

Create package for soon-to-be-refactored group/home.py and group/settings.py packages. Patch by: Todd Larsen Review by: to-be-reviewed

Add the Page object to the context of each view. Update templates to make use of the newly-available page.long_name and page.short_name. Patch by: Todd Larsen Review by: to-be-reviewed

Add the Page object to the context of each view method. Also, add some missing Arg: sections to __doc__ strings and fix the missing context issue in editPost() and editGet(). Patch by: Todd Larsen Review by: to-be-reviewed

Formalize the concept of a NonPage that can appear in the site-map, useful for non-clickable sidebar menu divisions, for example. Convert "hacky" fake Pages into NonPages in the site-map. Also, pass page=self to every view as a keyword argument when generating the Django urlpatterns. Patch by: Todd Larsen Review by: to-be-reviewed

Add a relative symlink pointing at ../rietveld/upload.py in thirdparty/chromium so that gcl.py can import the thirdparty/rietveld/upload.py module. Patch by: Todd Larsen Review by: to-be-reviewed

Replace missing: from google.appengine.api import users that appears to have been removed by r824. Needed by call in the edit() view to users.get_current_user(). Patch by: Todd Larsen Review by: to-be-reviewed

Replace GROUP_TYPE_PLURAL and GROUP_TYPE_SHORT constants in Group models with more generic TYPE_NAME, TYPE_NAME_SHORT, TYPE_NAME_PLURAL names and apply changes in affected files. Use ugettext_lazy for TYPE_NAME and TYPE_NAME_PLURAL constants. This approach is similar to the upcoming refactor of views. Patch by: Pawel Solyga Review by: to-be-reviewed

Move TODO about isDeletable Sponsor logic method to sponsor.py module and extend a little bit doc string. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove not needed request argument in view decorator. Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed not working after click the "List Site Sponsors" in site menu bar. due to wrongly imported modules. Patch by: Chen Lunpeng Review by: to-be-reviewed

Create decorators module in view/helper and add view decorator that catches exceptions like DeadlineExceededError, MemoryError, AssertionError (this code is being moved from respond function). Add view decorator to all view functions. In addition remove not needed imports from all affected files and fix too long lines. Patch by: Pawel Solyga Review by: to-be-reviewed

Last commit missed the new __init__.py file

Add a framework for generic views This commit does not enable the new code, as such there should be no change in functionality. In order to use the new code the maps.py file should be updated to point at the new views/models/sponsor.py module. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

entity_type is not the same as entity_type_short The previous commit wrongfully assumed this. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Make page argument required for errorResponse and requestLogin functions in simple.py and update affected files. Some keyword argument changes to in user/profile.py. All the changes are based on comments to r817. http://code.google.com/p/soc/source/detail?r=817 Patch by: Pawel Solyga Review by: to-be-reviewed

Rename 'group' to 'entity' in the Django templates This allows for generic use of these templates. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

DeadlineExceededError in the recent version of AppEngine lives only in one place so there is no need to try import it from both runtime (deployed) and runtime.apiproxy_errors (dev server) modules anymore. Patch by: Pawel Solyga Review by: to-be-reviewed

Add page=None parameter to all views. Information from page argument (which is soc.logic.site.page.Page object) is going to be used later in views code and for some context values. Fix some indentions in __doc__ strings. Add proper __doc__ string for all() function in sponsor/list.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Some indention fixes in access.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Change name of login_request variable in access.py module to login_response. Patch by: Pawel Solyga Review by: to-be-reviewed

Change name of getUserFromLinkNameOrDie function to getUserFromLinkNameOr404 and apply changes to affected files. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix mistakes in docs and comments in logic/models/base.py. Patch by: Pawel Solyga Review by: to-be-reviewed

Log Fix not working after click the "Site Settings" in home page. templete wasn't updated when soc/app/soc/logic/site/map.py was update. Patch by: Chen Lunpeng Review by: to-be-reviewed

Remove #docsummary class from css file as it is not used anymore. Add #createdby class in css file. Fix typo in docs/profile.html template. Put document content in <div class='content'>. Patch by: Pawel Solyga Review by: to-be-reviewed

Eliminate the Work.abstract property and move the Document.content property to Work.content instead. Update affected views, and re-base some classes that were deriving from Document just to get Document.content to now be derived from Work instead. The Document class now has a "pass" body with no additional properties. It is debatable whether Work should become Document, since I am not sure that we plan to be able to generically display, say, a Quiz or a Question (which are Works) on the home page (which can only specifically display a Document, or now, the basic Work entity...). Patch by: Todd Larsen Review by: to-be-reviewed

"new" is a little bit redundant in the short_name of sidebar menu items that already begin with "Create...", since that implies the result will be something new. Patch by: Todd Larsen Review by: to-be-reviewed

A quick-and-dirty way to create non-link sub-menu dividers, plus a TODO on how this should be formalizes to not be so hacky. This change was inspired by the ever-growing "Site" sidebar menu. Patch by: Todd larsen Review by: to-be-reviewed

Should have been part of recent r806. Patch by: Todd Larsen Review by: to-be-reviewed

First phase of making the / (site/home) view generic enough to use it for Sponsor "home" page, Program "home" page, Organization "home" page, etc. when combined with HomeSettings. First phase of addressing this issue: http://code.google.com/p/soc/issues/detail?id=64 by factoring "Site Settings" apart from the site/home stuff. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1405

Add the empty directory where site/home/edit.html is moving, to see if this fixes a problem with gcl.py.

Update TinyMCE wiget code according to r783. I hope I did it correctly this time. http://code.google.com/p/soc/source/detail?r=783 Patch by: Pawel Solyga Review by: to-be-reviewed

Change verbose_name of founder property in Group model from "Created by" to "Founded by". Add GROUP_TYPE_SHORT and GROUP_TYPE_PLURAL for all models that inherit from Group and use that values in templates and contexts. Assume that group_type, group_type_short and group_type_plural are defined in context and remove not needed ifs in templates. Rename "Linkname" to "Link name" in list/group_heading.html template. Patch by: Pawel Solyga Review by: to-be-reviewed

Remov "founder" text from the first line of edit.py, this is fix to r799 commit. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove the proposed WorksAuthors many:many relation and promote the "founder" property from Document up to Work. Update all subclasses of Work and any affected views accordingly. This addresses review comments here: http://code.google.com/p/soc/source/detail?r=786 Patch by: Todd Larsen Review by: to-be-reviewed

Fixed the evil black logo.