Todd Larsen <tlarsen@google.com> [Thu, 22 Jan 2009 22:54:46 +0000] rev 910
Change build.sh to create a build/ output directory (rather than release/).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 22 Jan 2009 22:35:41 +0000] rev 909
Move make_release.sh to build.sh.
This script creates a "build" really, not a release. A separate release.sh
script should be written to automate the current manual release process (at
some point...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:04:00 +0000] rev 908
Remove unused decorators import from soc.views.models.role module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:03:32 +0000] rev 907
Fix idention in soc.views.models.club module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:02:40 +0000] rev 906
Fix missing dots in soc.views.helper.decoratos module docstrings.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:01:16 +0000] rev 905
Rename clean_existing_user_not_equal_to_current function to clean_users_not_same in soc.logic.cleaning module and fix affected files.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 17:26:14 +0000] rev 904
Hide the 'link_id' field for site
Also construct the scope_path from the fields in case the entity
has not yet been created.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 17:23:17 +0000] rev 903
Rename "site/settings" to "site"
The "/site/settings" view is not about the Site Settings an sich, but
more about the "site presence singleton". In this context it does not
make sense to call it "site/settings".
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 16:05:49 +0000] rev 902
Fixed one style error and one typo.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:04:48 +0000] rev 901
Presence is now a 'abstract' View, pull in members from program
This is signified by the removal of params['name'] and other values
that are required by params.py, but also by the removal of the 'view'
definition at the bottom of the file.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:03:17 +0000] rev 900
Extend dicts.merge to be (optionally) recursive
This is very useful when dealing for views that expect to be
inhereted from but wish to provide default values.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:01:51 +0000] rev 899
Fix form errors and hidden form errors
The conversion to django left out the 'prettyfying' of form and
hidden form errors, as these could occur when running live, restore
this behavior.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 13:50:25 +0000] rev 898
Added a cleaning method for a LinkProperty Field.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 00:07:36 +0000] rev 897
Fixed wrong conditional in soc/views/models/club_app.py.
Notifications will now be send again.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 00:03:28 +0000] rev 896
Fixed import sorting and indentation in soc/views/models/club.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 23:44:02 +0000] rev 895
Even developers need to agree to the terms of service for Melange
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 23:43:16 +0000] rev 894
Corrected the list index parameters in soc/views/models/club_app.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 23:18:39 +0000] rev 893
Added Ignored applications to the list view.
Also restored the New Club notification upon application acceptance. That broke in r1483.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 22:47:22 +0000] rev 892
Replaced boolean properties in soc/models/group_app with status property.
This property has 5 choices ['accepted','rejected','ignored','needs review','completed']
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 22:21:40 +0000] rev 891
Move getToSLink() to soc.views.helper.redirects.getToSRedirect().
Fixes a circular import problem that prevented the site-wide ToS link from
being displayed by checkAgreesToSiteToS(). This is now completely implemented.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:41:36 +0000] rev 890
Tighten more checkIsUser() access to checkAgreesToSiteToS() instead.
Update the checkIsHost() comment.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:32:51 +0000] rev 889
Make checkAgreesToSiteToS() the default access check for many other checks.
Replace checkIsUser() with the more-strict checkAgreesToSiteToS(). Also, add
missing args and kwargs parameters to checkAgreesToSiteToS() that were missed
in the merge right before commit.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:25:18 +0000] rev 888
Add checkAgreesToSiteToS() (partially implemented until circular import fixed).
Need to fix a circular import problem before the alternate message will
include a link to the site-wide ToS Document.
Also, fixed the descriptions in the first few check...() functions.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:09:52 +0000] rev 887
Take advantage of new "from ... import ... as ..." rules in the style guide.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 20:25:07 +0000] rev 886
Added clean_existing_user_not_equal_to_current to clean the backup Administrator field in an application.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:53:23 +0000] rev 885
Changed the redirect in club application overview to the correct page.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:45:13 +0000] rev 884
Changed checkIsClubAppAccepted into a more generic checkIsApplicationAccepted.
Also fixed a minor bug in club_app view.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:40:39 +0000] rev 883
Changed the collection name and help text for Organization member template.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:32:00 +0000] rev 882
Added club_app model and logic.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 18:50:22 +0000] rev 881
Added created and last modified timestamps to the group_app model.
Also edited the templates to show some extra information. The review template has the names for the new properties hard coded because the auto_add and auto_add_now datetimeproperties don't show up in the fields of the entity.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 18:25:37 +0000] rev 880
Fixed typo in r1446.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 16:13:51 +0000] rev 879
Changes in Role model.
Clarified that we are asking for a shipping adress. Also moved Agrees to ToS to the bottom.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:13:18 +0000] rev 878
Fix trailing whitespace and apply decorators
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:13:03 +0000] rev 877
Fix whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:48 +0000] rev 876
Make use of the new decorators in all applicable views
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:31 +0000] rev 875
Renamed showReviewOverview to review_overview and reviewOverview
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:16 +0000] rev 874
Fixed two trivial bugs
A "kwargs=kwargs" instead of **kwargs
Missing 'and entity' check
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:01 +0000] rev 873
Added a merge_params and check_access decorator
The merge_params decorator is very simple and takes self._params and
merges it with params. It's main purpose is to explicitly mark the
views in which it is intended that self._params is merged raw.
The check_access decorator factors out the access checking process
and passes args and kwargs to the access checking methods.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:11:47 +0000] rev 872
Prepare access to receive args and kwargs as argument
Also use two "magic values" when the sidebar is doing the access
checks, this might be useful later.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:35:10 +0000] rev 871
Reverted r1457.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:29:58 +0000] rev 870
Changed link in club_app accepted notification.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:11:45 +0000] rev 869
Added a new view to help with application -> group process.
The applicant view is available only when there is an accepted application present. This will be checked by the access checker in an upcoming patch. The view uses a special form so that certain fields cannot be edited by the user. These fields correspond to important fields filled in during the application process.
Create access for a club has now been set to Host level.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 14:57:12 +0000] rev 868
onCreate for a Club now marks any application for the same club as completed and invites the admins.
This is useful for when the club has been created without using the application.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 14:36:44 +0000] rev 867
Edited the method used to clean link_id in params.py.
Removed the clean_new_link_id from the logic/cleaning.py module because this is not used anymore.
This method should be replaced by a method that is used after all the fields have been cleaned so that the actual key_name of an entity can be constructed.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 13:55:06 +0000] rev 866
Fixed a typo in the comments of soc/views/helper/forms.py
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:39:29 +0000] rev 865
Fix missing import identified by pylint.
************* Module app.soc.logic.models.user
E0602: 99:Logic.agreesToSiteToS: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:37:43 +0000] rev 864
Fix missing import identified by pylint.
************* Module app.soc.logic.models.presence
E0602: 56:Logic.getToS: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:34:43 +0000] rev 863
Fix missing import identified by pylint.
************* Module app.soc.views.helper.responses
E0602:187:getToSLink: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:31:55 +0000] rev 862
Add agreesToSiteToS() logic method to indicate if User accepts site-wide ToS.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:18:07 +0000] rev 861
Give error messages more room in the existing form field "as_table" templates.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:14:05 +0000] rev 860
Add a clean_agrees_to_tos() validator that requires "Yes" if ToS exists.
Also, more user_logic.logic => user_logic fixes. If you are going to import
"as", you might as well make the renaming worthwhile. Maybe we need to add
a section on "import ... from ... as ..." in the style guide?
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:32:05 +0000] rev 859
Change "Show" to "Export" missed in r1446 commit.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:27:39 +0000] rev 858
Add an export() view, and implement it as text/text for Document.
For every Model except Document, the public() view is displayed for any
attempts to access the export() view.
Currently, the permissions for export() are the same as for public(). This
seems reasonable for Document, since anyone could extract the raw HTML from
the page source anyway. The permissions should probably be different for
other types of exports, such as vCard or iCard exports of profiles, CSV
exports of lists, etc.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:13:03 +0000] rev 857
If a site-wide ToS exist, display the User profile "Agrees to ToS" checkbox.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:01:24 +0000] rev 856
Set agrees_to_tos example text to link to site-wide ToS (or a warning message).
Also, since a renaming import statement is being used already, change
user_logic.logic to just user_logic.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:33:43 +0000] rev 855
Do not crash on *every* page load if there is no ToS Document.
'tos' ReferenceProperty might be present, but still be None.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:30:21 +0000] rev 854
A better way to add site-wide ToS link to *all* pages on the site.
getUniversalContext() already fetches a copy of the Site settings, so use that
to see if the site-wide ToS exist and produce a link.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:21:32 +0000] rev 853
Linux /bin/sh (GNU) is not the same as OS X /bin/sh (BSD), so use /bin/bash.
Fixes:
scripts/pylint/do_pylint.sh: 27: Syntax error: "(" unexpected
on Ubuntu (and possibly other Linux distros).
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 22:01:02 +0000] rev 852
Replace css class 'notice' that is used in User profile template field help text with new 'fieldhelptext' class. Notice is part of CSS for notification bar and we want width limit just for field help text not for notification bar text.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:48:28 +0000] rev 851
Add getSingleton() method to return the Site settings entity.
There is always only one Site entity, referred to by DEF_SITE_LINK_ID.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:37:30 +0000] rev 850
Return the ToS Document of the supplied Presence entity, if there is one.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:26:34 +0000] rev 849
Support HTML tags in form field example_text column.
Improve the Program Model example_text as an example.
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 21:00:55 +0000] rev 848
Disable R0801 messages in pylintrc. R0801 messages indicates that a set of similar lines has been detected among multiple file. This usually means that the code should be refactored to avoid this duplication but in our case it's useless since it shows a lot of imports code or authors.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 20:52:12 +0000] rev 847
Add calendar widget support for timeline fields. Fix docstring typo in soc.views.models.timeline module. Add timeline edit template which loads necessary javascript files for datetimepicker widget.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 20:49:49 +0000] rev 846
Remove member_template from extra_dynaexclude in soc.views.models.club since member_template is only available in Organization as of recent commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 20:16:07 +0000] rev 845
Add the agrees_to_tos property to Roles (as its own changeset this time...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 20:04:21 +0000] rev 844
Make getToSLink() an actual method for re-use by others.
Uses the views.helper.redirects module to create the /document/show path,
instead of hard-coding it as a format string.
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 19:40:41 +0000] rev 843
Fixed EOL and whitespace damage
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 17:56:10 +0000] rev 842
This file should not have been included in r1428. Reverting...
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 17:53:36 +0000] rev 841
Changing ReadOnlyBool to type "text" makes it display "True" or "False".
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 17:41:47 +0000] rev 840
When constructing the sidebar don't overide 'sidebar'
Instead specify 'sidebar_additional' and include it even if there
is a 'sidebar' defined.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:31:53 +0000] rev 839
Add datetimepicker javascript widget files and css file.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:27:36 +0000] rev 838
Set notice width to 450px. It was way too long. Notice is displayed with help text on yellow background in User profile.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:12:55 +0000] rev 837
Add missing blank line in soc.views.helper.params module. Fix docstring typo in soc.views.models.role module. Add missing dots at the end of sentences in soc.logic.cleaning and soc.view.models.user_self modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:10:04 +0000] rev 836
Add missing 'of' word to list description strings in soc.views.models.club_app module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:09:09 +0000] rev 835
Add missing blank lines and dots in soc.views.helper.templatetags.forms_helpers module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:08:16 +0000] rev 834
Move member_template property from Group to Organization model since it's Organization specific property.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:03:55 +0000] rev 833
Disable R0201 message in pylintrc since we allow for that kind of methods. R0201 tells us that method could be a function. Used when a method doesn't use its bound instance, and so could be written as a function.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:00:19 +0000] rev 832
Fix typo in settings.py (missing '>' character).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 15:59:07 +0000] rev 831
Add missing dots in docstrings. Add sendNotification parameters description to docstring in soc.logic.helper module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 20 Jan 2009 14:12:54 +0000] rev 830
Added missing import to views/models/notification.py
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 20 Jan 2009 14:09:39 +0000] rev 829
Users now have the right to delete their own notifications.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 13:19:45 +0000] rev 828
Load /Users/solydzajs/Downloads/google_appengine into
trunk/thirdparty/google_appengine.
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 01:12:43 +0000] rev 827
Split the notification list in read/unread
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:48:49 +0000] rev 826
Add an unread count indication next to the notification link
Similar to how this is done in gmail.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:48:30 +0000] rev 825
Use 'from .. import .. as ..' in user_self
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:48:16 +0000] rev 824
Fixed whitespace and EOL damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:11:38 +0000] rev 823
Add a 'pending/accepted/denied' seperation to club_app list
This is not only to make it easier to see which applictions have been
accepted, but also to make it possible to redirect to /club/create
for the accepted applications, rather than to /club_app/edit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:11:21 +0000] rev 822
Fixed whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:26:09 +0000] rev 821
Send a notifcation if a club application is accepted
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:25:49 +0000] rev 820
Factor out sendNotification from sendInviteNotification
This makes it easier to create different types of notifications,
such as a sendNewClubNotification.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:25:36 +0000] rev 819
Fixed whitespace and EOL damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:25:23 +0000] rev 818
Fixed whitespace damage
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 19 Jan 2009 16:23:37 +0000] rev 817
Added club_admin templates.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 16 Jan 2009 17:54:46 +0000] rev 816
Added Mario Ferraro to the AUTHORS list.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 16 Jan 2009 17:52:42 +0000] rev 815
Tooltips now properly disappear when another text box with a tooltip has been highlighted.
Also known as Issue 132.
Patch by: Mario Ferraro
Reviewed by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 15 Jan 2009 17:01:15 +0000] rev 814
Implement the checkIsClubAppAccepted function
Also added a stub for checkIsClubAdminForClub.
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 22:37:05 +0000] rev 813
Display state (but dis-allow edits) of User's agrees_to_tos boolean Property.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 22:30:24 +0000] rev 812
Add read-only boolean form field widget.
Developers should be able to view, but not change, the User's agrees_to_tos
state.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 22:02:39 +0000] rev 811
Add "agrees to site-wide Terms of Service" boolean property for all Users.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:56 +0000] rev 810
Hide 'tos' pull-down selector from Program profile forms.
Until a way to select Documents for use as the Terms of Service for a Program
exists (see http://code.google.com/p/soc/issues/detail?id=151), there is no
point in hacking in scope_path and link_id fields here. The per-Program ToS
feature will just be unavailable until an appropriate Document selector
exists.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:47 +0000] rev 809
Hide 'tos' pull-down selector from Group profile forms.
Until a way to select Documents for use as the Terms of Service for a Group
exist (see http://code.google.com/p/soc/issues/detail?id=151), there is no
point in hacking in scope_path and link_id fields here. The per-Group ToS
feature will just be unavailable until an appropriate Document selector
exists.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:34 +0000] rev 808
Hide 'tos' pull-down selector from Site Settings forms.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:24 +0000] rev 807
Hack in tos_scope_path and tos_link_id to select Terms of Service Document.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:05:15 +0000] rev 806
Show Terms of Service link in footer if tos_link is defined in the context.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:05:05 +0000] rev 805
Add a ReferenceProperty pointing to a Terms of Service Document.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 19:11:34 +0000] rev 804
Fixed a bug that was triggered on manual club creation without an application.
Now also sets the application_completed flag upon club creation.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 18:56:54 +0000] rev 803
Fixed missing params in views/models/club_app.py.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:18:10 +0000] rev 802
Added Club Admin model, logic, and view
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:17:44 +0000] rev 801
Invite (backup-)admin when creating a club
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:17:30 +0000] rev 800
Added a create method that uses an existing application
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:17:16 +0000] rev 799
Construct names automatically from base name.
Saves a lot of typing for the common case
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 14:49:45 +0000] rev 798
Fixed a wrong method being called when accepting/declyning an application.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 14:44:04 +0000] rev 797
Added basic review functionality for club applications.
The access rights are open for discussion.
The review page uses GET data to determine the decision made by the user.
For convenience the Review Club Applications button directs you to a multi-list view so you can see the state of different applications.
The review state will reset whenever the application has been changed using the edit form.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 14:14:38 +0000] rev 796
Fixed a typo in the comment in helper/access.py.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 13:50:41 +0000] rev 795
Added control fields to group_app.
Moved unnecessary fields containing questions about past participation from group_app to org_app.
Updated the club_app public page to show the correct information using twoline layout.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 13:28:04 +0000] rev 794
Added _readonly_field_as_twoline_table_row .
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 08 Jan 2009 21:44:03 +0000] rev 793
Resolved a bug when editing a timeline.
Scope path is now set correctly when editing a timeline.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:24:36 +0000] rev 792
Fixed line-ending and whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:24:27 +0000] rev 791
Added the club_app view, logic and model
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:24:10 +0000] rev 790
Removed unneeded params from club
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:52 +0000] rev 789
Moved the member_template field to app and removed 'optional'
Also shortened the verbose_name of the member_template field.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:42 +0000] rev 788
Factored out the clean_existing_user method
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:33 +0000] rev 787
Fix login link
Without the leading slash the link does not work on appspot.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:24 +0000] rev 786
Fixed a typo in the group_app model
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:15 +0000] rev 785
Added a twoline_edit.html page
An as_twoline_edit template tag was added for this purpose. This tag
renders the label field on a seperate line.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 08 Jan 2009 20:27:21 +0000] rev 784
Fix missing dots at the end of sentences in docstring and fix wrong import sorting in soc.logic.helper.notifications module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 08 Jan 2009 20:09:24 +0000] rev 783
Extract BSD license text into a separate file to make it easier to find.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 08 Jan 2009 17:22:37 +0000] rev 782
Fixed missing files in r1364.
Patch by: Lennard de Rijk
Augie Fackler <durin42@gmail.com> [Thu, 08 Jan 2009 15:31:41 +0000] rev 781
Fix the setup of the test environment, including clearing the datastore
between tests.
Augie Fackler <durin42@gmail.com> [Thu, 08 Jan 2009 15:31:33 +0000] rev 780
Add support for coverage to our testing system.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 07 Jan 2009 22:09:52 +0000] rev 779
Added support for creating clubs.
Patch by : Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 07 Jan 2009 21:58:43 +0000] rev 778
Added support for mutliple edit forms based on entity type
This makes it possible to have different edit forms in timeline based
on which workflow type is used.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 07 Jan 2009 21:57:48 +0000] rev 777
Added an 'edit timeline' button to the program edit page
Also made the create timeline functionality use the logic modules
introduced in the previous commit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 07 Jan 2009 21:57:12 +0000] rev 776
Started on edit timeline
Added a gsoc timeline logic module. Also added a scope_path as the
key_field to timeline. Updated the django_paterns to only include
the edit field and removed link_id as dynafield.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 07 Jan 2009 20:56:50 +0000] rev 775
Fixed missing import in soc/models/organization.py.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 07 Jan 2009 20:30:38 +0000] rev 774
Add hard-coded GroupApplication and OrgApplication Models.
These are being hard-coded because the "real" Question/Answer/Quiz/Response
implementation will not be ready any time soon.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 07 Jan 2009 20:24:38 +0000] rev 773
Mailing list EmailProperty should be StringProperty instead, so that it is
possible, for example, to supply a Google Group URL for sign-up purposes.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 07 Jan 2009 19:38:29 +0000] rev 772
Add IRC channel and mailing list properties to the Group and Organization
Models.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 07 Jan 2009 16:49:16 +0000] rev 771
Typo and style fixes.
Patch by: Pawel Solyga and Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 06 Jan 2009 21:21:09 +0000] rev 770
Fixed a bug where a new timeline would get created on every edit of an existing program.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 06 Jan 2009 20:56:48 +0000] rev 769
Added an elementary workflow choosing method to program creation.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 17:26:06 +0000] rev 768
Added logic and view classes for the Timeline model
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 17:25:54 +0000] rev 767
Sorted build.py's sitemap.addPages lines
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 16:55:27 +0000] rev 766
Made Program reference Timeline
Also made Timeline inherit from base like it should.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 16:01:16 +0000] rev 765
Copy/paste fix
Typo fix: s/founder/program
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 00:14:32 +0000] rev 764
Added a basic Timeline model
The timeline model will contain the deadlines and time ranges for the
individual programs.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Dec 2008 18:51:36 +0000] rev 763
Set no_create_with_key_fields paramater to True for Notifications.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 18 Dec 2008 09:52:20 +0000] rev 762
Revert "Overwrite default patterns in views/models/notification.py to disallow certain URL's."
This should instead be done by setting the no_create_with_key_fields
parameter to True.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 18 Dec 2008 09:52:04 +0000] rev 761
Allow disabling of the create url with key_fields
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 18 Dec 2008 07:02:48 +0000] rev 760
Overwrite default patterns in views/models/notification.py to disallow certain URL's.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 22:27:55 +0000] rev 759
Fixed a too long line in logic/helper/notifications.py
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 22:25:16 +0000] rev 758
Added base template for notification messages.
This makes the messages a bit more friendly by including a greeting and signature.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 22:15:21 +0000] rev 757
Added email message when receiving a notification.py
At the moment this only triggers when the new notification is your first unread message. Also fixed an url bug in the invite notification.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 19:33:03 +0000] rev 756
Changed invitation email and into a notification.
Also changed the public template for Notification to allow HTML code.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:15:32 +0000] rev 755
Remove unused imports and variables in different soc.views.models modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:13:07 +0000] rev 754
Remove unused import in soc.views.hlper.templatetags.forms_helpers module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:12:28 +0000] rev 753
Since DbModelForm has been renamed to BaseForm change super() call from BaseForm to djangoforms.ModelForm in soc.views.helper.forms module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:11:12 +0000] rev 752
Some docstring fixes and unused import removal in soc.logic.models.site module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:10:32 +0000] rev 751
Fix inheritance in soc.models.base module. FieldsProxy inherited from DbModelForm which was deleted in previous commits (replace that with BaseForm).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:08:16 +0000] rev 750
Fix too long lines in soc.logic.helper.notifications module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:07:18 +0000] rev 749
Remove unused import in soc.logic.accounts module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:06:13 +0000] rev 748
Remove unused imports in models modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:34:46 +0000] rev 747
In soc.views.models.notification module remove unused imports, add missing white space, change list() method definition to comply with base View list() method declaration. Add missing Meta class docstring.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:24:24 +0000] rev 746
Fix import sorting in soc.views.helper.access module and rename 'host' to 'Program Administrator'.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:22:50 +0000] rev 745
Remove not used TYPE_NAME, TYPE_NAME_SHORT and TYPE_NAME_PLURAL consts in all Group models.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:21:26 +0000] rev 744
Add missing dots, fix imports sorting and too long lines in different modules. Add TODO in soc.views.models.host module.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:51:03 +0000] rev 743
Have user/edit.html use the as_table tag as well
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:50:49 +0000] rev 742
Removed unused template
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:33:59 +0000] rev 741
Converted as_table to be a template tag
This allows us to move all the HTML from python code (which made it
extremely icky and unreadable) to Django templates, which is _a lot_
more readable, and makes it feasable for HTML/CSS experts to change
the way these tables are generated.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:33:41 +0000] rev 740
Added some example_text to program
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:33:29 +0000] rev 739
Added support for example texts
Initial patch by Benjamin, some minor fixes by Sverre.
Patch by: Benjamin Lyaunzbe, Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 18:21:35 +0000] rev 738
Brown-paper-bag fix in notification.py
Was missing a leading slash in the redirect.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 13 Dec 2008 14:55:00 +0000] rev 737
Notification property has_been_read changed into unread
Due to comments on r1309.
Patch By: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:28:01 +0000] rev 736
No override needed in notifications.py
The only downside is that the ?s=0 parameter will still be appended
but is not handled in list(). The right solution would be to update
list() so that it does say "Message Sent" or such, to give the user
an indication that their message was sent succesfully.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:27:40 +0000] rev 735
Make it possible to redirect anywhere after editPost
This makes it possible to not include the suffix in the redirect by
making it a named parameter.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:09:06 +0000] rev 734
Make the place of the rights declaration consistent
Other code places it at the top, so we should do that in notification
as well.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:08:45 +0000] rev 733
Remove custom override of django_patterns_defaults
Instead restrict access to the edit method, also, there is no need to
set the default access to allow.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:08:23 +0000] rev 732
Fix whitespace and EOL damage in notifcation.py
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:49:57 +0000] rev 731
Make use of readonly_field_as_table_row
Instead of manually typing out the <br /> etc.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:49:34 +0000] rev 730
Fix EOL-damage
We use \n for line endings, so remove the \r from public.html
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:49:11 +0000] rev 729
Make checkIsMyInvitation use Django to parse the URL
Using django is more reliable and makes the code easier to read as
there is no knowledge of the url layout required.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:48:49 +0000] rev 728
Added a readonly_multiline_field_as_table_row tag
This is useful when a field is allowed to include newlines.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 13 Dec 2008 11:02:08 +0000] rev 727
Using getForCurrentAccount where possible due to comments on r1309.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 12 Dec 2008 23:28:18 +0000] rev 726
Added Notifications.
Notifications will primarily be used to serve the user information message like "New Request Pending". The system can be expanded later on to a messaging system.
If you are a developer you can create message by going to notification/create . This has been done so the system can easily be tested. But will of course be visible in an easy-to-access location when the transition to a message system has been made.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:35:51 +0000] rev 725
Filter the "list Hosts" view
This way only those Hosts are shown that belong to a Sponsor the
user is a host for.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:35:28 +0000] rev 724
Allows a user object to be passed to accounts.isDeveloper
This saves a trip to the database if the user object has already
been retrieved.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:35:08 +0000] rev 723
Make getForFields use the db.Query API
While at it, add support for the IN statement in the form of a value
of the list type.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:34:39 +0000] rev 722
Added getForCurrentAccount to user.Logic
It returns the user entity associated with the currently logged in
user.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:34:12 +0000] rev 721
Added a filter method to dicts
The best way to explain this is probably with an example:
>>> split({'foo':'bar', 'bar':['one', 'two'], 'baz': ['three', 'four']})
[{'bar': 'one', 'foo': 'bar', 'baz': 'three'},
{'bar': 'two', 'foo': 'bar', 'baz': 'three'},
{'bar': 'one', 'foo': 'bar', 'baz': 'four'},
{'bar': 'two', 'foo': 'bar', 'baz': 'four'}]
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Dec 2008 20:54:22 +0000] rev 720
Make it possible to invite another Host as Host
We do this by asking Django to resolve the current url for us, then
reshufle that url and ask Django (again) to resolve that new url.
From that resolved url we know the appropriate view, and as such we
know which rights dictioanry to pass to access.checkAccess.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Dec 2008 20:53:57 +0000] rev 719
Added a trivial unzip method, counterpart to zip
Patch by: Sverre Rabbelier
Augie Fackler <durin42@gmail.com> [Thu, 11 Dec 2008 04:23:42 +0000] rev 718
Add some ignore properties for when we get working coverage support.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 10 Dec 2008 07:38:56 +0000] rev 717
Fixed missing header in site settings.
Also known as Issue 146.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 09 Dec 2008 15:43:56 +0000] rev 716
Changed "Sponsor" to "Program Owner"
Changed "Host" to "Program Administrator"
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 08 Dec 2008 17:31:33 +0000] rev 715
Adds the removal of requests from the datastore when a new role entity is created.
This uses the classname from the role entity as the type of role in the request.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 07 Dec 2008 20:25:50 +0000] rev 714
Add missing dots in docstrings, proper sorting of imports and small docstring typo fixes.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 20:02:40 +0000] rev 713
Thinkofix in access.checkIsInvited
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 20:02:17 +0000] rev 712
Some forgotten changes with the access_type commit
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 07 Dec 2008 19:18:24 +0000] rev 711
Program Name column showed link_id instead of name, replace link_id with name in soc/program/list/row.html template.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 19:02:41 +0000] rev 710
Add explicit access_types from the url
This does two things, it reduces the amount of repeated data (e.g.,
the checkAccess used to repeat the access_type that was already
specified in the url). At the same time, it allows for example the
'create' page to push its access_type to 'edit'.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 19:02:02 +0000] rev 709
Add checkIsHost in access
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 19:01:35 +0000] rev 708
Some cleanups in role.py and site.py and create()
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 17:26:59 +0000] rev 707
Changed template for home/public.html to show last modified in the top-right corner.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 17:02:32 +0000] rev 706
Add site scoped documents to the Site menu
This allows for featured documents that belong to the Site scope to
show up in the 'Site' menu.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 17:02:10 +0000] rev 705
Move document sidebar entries extraction to document.View
This way other modules can benefit from the same logic. Also make use
of the sidebar.getSidebarMenu method so that getMenusForScope is no
longer specific to full menu's.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 17:01:44 +0000] rev 704
Factor out sidebar entry construction
This makes it possible to reuse this logic in other modules as well,
preventing code duplication. While at it, move additional_sidebar
merging before the other entries (additional entries should go first,
since the other entries are mostly dev-only etc).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:29:37 +0000] rev 703
Rename getSidebarLinks to getSidebarMenus
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:29:10 +0000] rev 702
Remove bogus scope from Site
This makes Site an unscoped entity (similar to how User and Sponsor
do not have a scope).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:28:36 +0000] rev 701
If an entity is unscoped, do not try to retrieve a scope
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:02:29 +0000] rev 700
Dynamically add sidebar items for programs
This adds sidebar items for programs as appropriate. From the docstring:
A menu item is generated for each program that is currently
running. The public page for each program is added as menu item,
as well as all public documents for that program.
Additionally, we allow access to a program's public page to everyone,
even if the user is not logged in.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:02:03 +0000] rev 699
Add and use a placeholder for checkIsDocumentPublic
We should somehow decide whether a document is publically viewable.
This should of course be dependant on what the document is, e.g. the
FAQ of a program should be allow(), whereas a student's application
should be checkIsMentor().
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:01:31 +0000] rev 698
Added a public redirect
Also some minor cleanups in the redirects code.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 13:49:22 +0000] rev 697
Prepare for callbacks that return more than one menu
This paves the way for callbacks that dynamically construct their
menu based on in-db content, such as Programs and Documents.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 13:38:53 +0000] rev 696
Make use of the 'sidebar' param for user_self
Instead of overriding getSidebarLinks we use the sidebar param since
user_self is now in it's own View.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 13:06:26 +0000] rev 695
Fixed email adress in urls.py.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 12:41:28 +0000] rev 694
Fixes 'module' object has no attribute 'handler500' and 404 on instances where debug is False.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 10:23:10 +0000] rev 693
Fixed the header on the List Programs page.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 22:34:25 +0000] rev 692
Reset the RELEASE_TAG to None (unreleased) now that the 0.1a20081206 release candidate branch has been created.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 22:18:21 +0000] rev 691
Set RELEASE_TAG to 0.1a20081206rc for release candidate 06/12/2008.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 21:32:36 +0000] rev 690
Fix imports sorting in soc.views.models.organization.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 21:27:47 +0000] rev 689
Add missing dots in docstrings in modules.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 21:05:17 +0000] rev 688
Changed generic_name to group_label in models/program.py.
Also I've updated the comments and help text to explain the meaning of this field.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 19:25:01 +0000] rev 687
Updated to the latest version of upload.py
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 16:52:21 +0000] rev 686
Load ../../google_appengine_1.1.7/ into
trunk/thirdparty/google_appengine.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 14:50:45 +0000] rev 685
Comment fixes for state in group and role model.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:46:19 +0000] rev 684
Fix for randomely ocurring bug
The bug and it's fix are described by the first comment from Guido
in http://code.google.com/p/googleappengine/issues/detail?id=772.
Patch by: Guido van Rossum
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 14:44:02 +0000] rev 683
Changed state property for models/group.py to be optional as the description states.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:25:24 +0000] rev 682
Added organizations
Really basic for now, next stop is to have a proper document selector
for the Presences.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:50 +0000] rev 681
Cleanups in group and program
The missing super call in group prevented the scope from being set
as it should be.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:26 +0000] rev 680
Added a new create regexp in urls for just scope_path
Now that scope_path is properly defined we can add a url matching
just the scope path. This allows some other custom create regexps to
be removed/rewritten.
Note: It needs to be -after- the full key_name regexp, since for
arbitrarily nested scopes it would always match as just scope_path,
even if there are other fields needed after the scope.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:53 +0000] rev 679
Introduce dynamic scope_path regexps
Instead of relying on scope_path's being "one slash deep", we should
instead allow for either:
1. scope_paths that have a pre-defined depth
2. scope_paths that can be arbitrarily deep
We achieve 1 by setting an entities scope_logic to another logic
module. We then recursively call getScopeDepth until we get to the
topmost entity (that is, an unscoped entity).
A little different is the solution to 2, since some entities can have
an arbitrarily deep scope (such as Documents), we need to have some
way of signaling this to getScopePattern. A clean solution is to
return None, rather than a number. If None is returned, the
SCOPE_PATH_ARG_PATTERN is returned as regexp instead, which will
match an arbitrarily deeply nested scope.
The solution for 2 requires that we return None somewhere in the
scope_logic chain, the most straight forward method to do so is to
override getScopeDepth anywhere such a scope is needed and make it
return None. A more elegant solution however, is to set the
scope_logic to that module in all entities that require it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:25 +0000] rev 678
Added a linkable logic module
The linkable logic module is used to signal the fact that the scope
of an entity can be any linkable.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:13:19 +0000] rev 677
Fix scope lookup for unscoped entities
As scope_logic is now always set (since r1250), we need to check if
it is None, rather than check if it exists.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:12:58 +0000] rev 676
Swap the order of request key fields
This will make it easier to remove scope_path as explicit key field
at some point by having it as inplicit key field for all entities.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:53:26 +0000] rev 675
Use key().name() instead of link_id
This is now possible because key_name is constructed purely from the
key fields of an entity. It is not sufficient to use just link_id,
that works only for single-scoped entities (e.g., those that either
do not have a scope, or that have a scope which itself does not have
a scope). It would break if there was an entity that has a scoped
scope (it would only include the scope's link_id in the url, which
made it impossible to look up the scope as we missed the link_id of
the scope's scope).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:53:05 +0000] rev 674
More DI on scope_logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:31:08 +0000] rev 673
Partial revert
Last commit contained some changes that did not belong there, revert
them for now.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:26:15 +0000] rev 672
Some more cleanups in base.Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:21:41 +0000] rev 671
Apply DI on the scope logic
Patch by: Sverre Rabbelier