Sat, 06 Dec 2008 11:21:41 +0000 Apply DI on the scope logic
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:21:41 +0000] rev 671
Apply DI on the scope logic Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:21:01 +0000 Removed unused file path_link_name
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:21:01 +0000] rev 670
Removed unused file path_link_name Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:20:44 +0000 Remove unneeded method getSuffixValues
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:20:44 +0000] rev 669
Remove unneeded method getSuffixValues Patch by: Sverre Rabbelier
Fri, 05 Dec 2008 22:54:43 +0000 Some style and typo fixes in different modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:54:43 +0000] rev 668
Some style and typo fixes in different modules. Patch by: Pawel Solyga
Fri, 05 Dec 2008 22:27:04 +0000 Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:27:04 +0000] rev 667
Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module. Patch by: Pawel Solyga
Fri, 05 Dec 2008 22:25:57 +0000 Fix import sorting and docstring typos in soc.views.models.program module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:25:57 +0000] rev 666
Fix import sorting and docstring typos in soc.views.models.program module. Patch by: Pawel Solyga
Fri, 05 Dec 2008 22:25:08 +0000 Fix import sorting in soc.views.sitemap.build module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:25:08 +0000] rev 665
Fix import sorting in soc.views.sitemap.build module. Patch by: Pawel Solyga
Fri, 05 Dec 2008 12:24:02 +0000 Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 12:24:02 +0000] rev 664
Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template. Patch by: Pawel Solyga
Thu, 04 Dec 2008 10:09:38 +0000 Make base.View.create lookup the scope if appropriate
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 04 Dec 2008 10:09:38 +0000] rev 663
Make base.View.create lookup the scope if appropriate Also re-introduce the custom description of the list selection for the redirection. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 23:49:10 +0000 Make use of the new generic key_name by lookup up scope_path
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:49:10 +0000] rev 662
Make use of the new generic key_name by lookup up scope_path This way base classes do not have to look up the 'scope' property, instead they can rely on the base class to do it for them provided they define the 'scope_logic' param. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 23:48:33 +0000 Change the key name to not include entity type
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:48:33 +0000] rev 661
Change the key name to not include entity type This allows for direct lookup by scope_path, rather than having to do more complex things. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 23:48:10 +0000 Introduced django_extra_patterns
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:48:10 +0000] rev 660
Introduced django_extra_patterns This way no classes ever need to override the getDjangoURLPatterns, which results in less code, which is also more clear (that is, it is immediately obvious that a View adds an extra mapping if it sets the new django_extra_patterns value, or that it overrides the mapping when it sets django_patterns_defaults. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:28:16 +0000 Make scope_path required for program
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:28:16 +0000] rev 659
Make scope_path required for program Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:27:52 +0000 Factor out the Group part of Sponsor
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:52 +0000] rev 658
Factor out the Group part of Sponsor This makes it possible to reuse the Group logic. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:27:27 +0000 Rename role.RoleView to role.View
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:27 +0000] rev 657
Rename role.RoleView to role.View Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:27:01 +0000 Cleanups in the views module
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:01 +0000] rev 656
Cleanups in the views module Mainly rename from original_params to new_params (so that the keyword argument in the __init__ method is the same for all). Also use super(View, self) where appropriate. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:26:16 +0000 Cleanups to the logic module
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:26:16 +0000] rev 655
Cleanups to the logic module Mainly converting to super(Logic, self) and adding some missing empty lines while at it. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:05:13 +0000 Fixed the 'New Host' link
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:05:13 +0000] rev 654
Fixed the 'New Host' link Also removed the 'Invite Host' button from the Sponsor view now that the link is working. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:04:38 +0000 Make the 'select entity' View generic
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:04:38 +0000] rev 653
Make the 'select entity' View generic This allows the selection of any entity from an arbitrary View by specifying the 'target view' and the redirect function. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:04:15 +0000 Cleanups in preparation of general selector view
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:04:15 +0000] rev 652
Cleanups in preparation of general selector view Renamed LIST... to DEF_LIST since it is a global definition. Renamed getCreateProgramRedirect to getCreateRedirect since it will work on all entities as it uses params. Added a getParams method to base.View Updated selectSponsor as appropriate. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:03:46 +0000 Remove the logic parameter from getListContent
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:03:46 +0000] rev 651
Remove the logic parameter from getListContent Now that params always has a 'logic' attribute, we can use that instead of requiring that it is passed as argument. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 20:14:14 +0000 Changed clean_link_id to convert the input to lower characters for user comfort.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 02 Dec 2008 20:14:14 +0000] rev 650
Changed clean_link_id to convert the input to lower characters for user comfort. It has been changed in a couple of files, most importantly in logic/cleaning.py wich will be used by future forms to do their cleaning. Patch by: Lennard de Rijk
Tue, 02 Dec 2008 20:10:23 +0000 Finish Program
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 20:10:23 +0000] rev 649
Finish Program Added some fields, and made TinyMCE the editor for the description field. Also updated the public page to show these new fields. We really need generic public views... Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 18:48:42 +0000 Brown paperbag fix in recent cycle breaking
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 18:48:42 +0000] rev 648
Brown paperbag fix in recent cycle breaking Self is no longer used, 'error' should be used instead. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 17:59:44 +0000 Swap order of merged params to fix sponsor select view
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 17:59:44 +0000] rev 647
Swap order of merged params to fix sponsor select view The sponsor select view (in 'create new program') was showing the wrong information (and also using the wrong list template) because the order in which the params were merged was wrong way around. This fixes that and at the same time fixes the 'instruction_text' attribute, which should be named 'list_description' instead. At the same time we lookup and set Sponsor as the scope of the newly created program. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 17:14:18 +0000 Remove cyclic imports by moving response method of out_of_band.Error class to soc.views.helper.responses module as errorResponse function. Apply changes to affected files.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Dec 2008 17:14:18 +0000] rev 646
Remove cyclic imports by moving response method of out_of_band.Error class to soc.views.helper.responses module as errorResponse function. Apply changes to affected files. Patch by: Pawel Solyga
Tue, 02 Dec 2008 11:20:08 +0000 Remov unused import from Quiz model and add missing blank line.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Dec 2008 11:20:08 +0000] rev 645
Remov unused import from Quiz model and add missing blank line. Patch by: Pawel Solyga
Tue, 02 Dec 2008 10:44:56 +0000 Remove Great Britain from country list. Great Britain was included as a country, although it has a country code (.gb) it's not a state. United Kingdom is correct and remains in the list.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Dec 2008 10:44:56 +0000] rev 644
Remove Great Britain from country list. Great Britain was included as a country, although it has a country code (.gb) it's not a state. United Kingdom is correct and remains in the list. Patch by: Matthew Wilkes Review by: Pawel Solyga
Mon, 01 Dec 2008 21:38:25 +0000 Added programs
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 01 Dec 2008 21:38:25 +0000] rev 643
Added programs Currently the programs are somewhat of empty, but due to the ease with which we can add new fields later, it is acceptable to commit it in it's current form. Patch by: Sverre Rabbelier
Mon, 01 Dec 2008 21:37:27 +0000 Allow for extra dynamic fields for the create form
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 01 Dec 2008 21:37:27 +0000] rev 642
Allow for extra dynamic fields for the create form Also some minor cleanups, such as making base.Logic inherit from object, as per the style guide. Patch by: Sverre Rabbelier
Mon, 01 Dec 2008 21:30:01 +0000 Fixed a styling error.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 01 Dec 2008 21:30:01 +0000] rev 641
Fixed a styling error. Patch by: Lennard de Rijk
Mon, 01 Dec 2008 21:03:20 +0000 Added User welcome message.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 01 Dec 2008 21:03:20 +0000] rev 640
Added User welcome message. Added templates/soc/mail/welcome.html as a template for the message. Also fixed a cyclic import that was about to happen in notifications.py.
Mon, 01 Dec 2008 12:37:16 +0000 Some docstring fixes in few modules (soc.views.helper soc.views.models.base).
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Dec 2008 12:37:16 +0000] rev 639
Some docstring fixes in few modules (soc.views.helper soc.views.models.base). Patch by: Pawel Solyga
Mon, 01 Dec 2008 12:35:56 +0000 Add missing dot and correctly sort imports in soc.logic.helper.notifications module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Dec 2008 12:35:56 +0000] rev 638
Add missing dot and correctly sort imports in soc.logic.helper.notifications module. Patch by: Pawel Solyga
Mon, 01 Dec 2008 12:34:55 +0000 Some docstring and missing blank lines fixes in soc.views.sitemap modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Dec 2008 12:34:55 +0000] rev 637
Some docstring and missing blank lines fixes in soc.views.sitemap modules. Patch by: Pawel Solyga
Sun, 30 Nov 2008 22:30:01 +0000 Sponsor name now shows in List Hosts.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 22:30:01 +0000] rev 636
Sponsor name now shows in List Hosts. Patch by: Lennard de Rijk
Sun, 30 Nov 2008 22:15:39 +0000 Moved sendInviteMessage to a new module in logic/helper/notifications.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 22:15:39 +0000] rev 635
Moved sendInviteMessage to a new module in logic/helper/notifications.py. Renamed sendInviteMessage to sendInviteNotification. Removed the now obsolete imports in logic/models/request.py. This has been done to keep the models/logic modules clean.
Sun, 30 Nov 2008 21:49:14 +0000 Changed email address in logic/models/base.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 21:49:14 +0000] rev 634
Changed email address in logic/models/base.py. Patch by: Lennard de Rijk
Sun, 30 Nov 2008 21:28:25 +0000 Allow developers access to anything that does a checkIsInvited.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 21:28:25 +0000] rev 633
Allow developers access to anything that does a checkIsInvited. Patch by: Lennard de Rijk
Sun, 30 Nov 2008 17:37:06 +0000 Remove unused imports from some modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:37:06 +0000] rev 632
Remove unused imports from some modules. Patch by: Pawel Solyga
Sun, 30 Nov 2008 17:35:48 +0000 Fix typo and too long lines in soc.logic.models.request module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:35:48 +0000] rev 631
Fix typo and too long lines in soc.logic.models.request module. Patch by: Pawel Solyga
Sun, 30 Nov 2008 17:35:05 +0000 Add missing import, remove unused import and add missing parameters to methods in soc.views.models.user_self module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:35:05 +0000] rev 630
Add missing import, remove unused import and add missing parameters to methods in soc.views.models.user_self module. Patch by: Pawel Solyga
Sun, 30 Nov 2008 17:06:32 +0000 Add missing dots and fix too long line in soc.views.helper.dynaform module. Remove unused imports in soc.views.models.document module. Fix too long lines. Add missing docstring for Meta classes.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:06:32 +0000] rev 629
Add missing dots and fix too long line in soc.views.helper.dynaform module. Remove unused imports in soc.views.models.document module. Fix too long lines. Add missing docstring for Meta classes. Patch by: Pawel Solyga
Sun, 30 Nov 2008 16:46:32 +0000 Add module docstring and license for soc, soc.models, soc.views.helper.templatetags.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:46:32 +0000] rev 628
Add module docstring and license for soc, soc.models, soc.views.helper.templatetags. Patch by: Pawel Solyga
Sun, 30 Nov 2008 16:44:27 +0000 Remove python-graph from thirdparty, remove check_includes script and graph folder from scripts. This functionality is (cyclic imports check) is supported by pylint automatically so we don't need that any more.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:44:27 +0000] rev 627
Remove python-graph from thirdparty, remove check_includes script and graph folder from scripts. This functionality is (cyclic imports check) is supported by pylint automatically so we don't need that any more. Patch by: Pawel Solyga Review by: Sverre Rabbelier
Sun, 30 Nov 2008 16:39:18 +0000 Fix too long lines in soc.views.models.request, remove unused imports and change pending requests list description. Remove unused imports from soc.logic.path_link_name module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:39:18 +0000] rev 626
Fix too long lines in soc.views.models.request, remove unused imports and change pending requests list description. Remove unused imports from soc.logic.path_link_name module. Patch by: Pawel Solyga
Sun, 30 Nov 2008 16:36:17 +0000 Add missing dots in soc.logic.lists module. Change method names to comply with Style Guide. Make class variable protected by adding "_" to the name of variable. Update lists templates respectively (methods name change).
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:36:17 +0000] rev 625
Add missing dots in soc.logic.lists module. Change method names to comply with Style Guide. Make class variable protected by adding "_" to the name of variable. Update lists templates respectively (methods name change). Patch by: Pawel Solyga
Sun, 30 Nov 2008 16:32:23 +0000 Remove unused imports in soc.views.models role, host and site modules. Add missing parameter in getDjangoURLPatters method.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:32:23 +0000] rev 624
Remove unused imports in soc.views.models role, host and site modules. Add missing parameter in getDjangoURLPatters method. Patch by: Pawel Solyga
Sun, 30 Nov 2008 16:29:48 +0000 Remove unused imports in soc.views.models.user and soc.views.models.sponsor modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:29:48 +0000] rev 623
Remove unused imports in soc.views.models.user and soc.views.models.sponsor modules. Patch by: Pawel Solyga
Sun, 30 Nov 2008 15:25:31 +0000 Remove unused import in soc.models.task.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 15:25:31 +0000] rev 622
Remove unused import in soc.models.task. Patch by: Pawel Solyga
Sun, 30 Nov 2008 15:25:07 +0000 Fix too long lines in soc.model.work.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 15:25:07 +0000] rev 621
Fix too long lines in soc.model.work. Patch by: Pawel Solyga
Sat, 29 Nov 2008 23:51:24 +0000 Put the redirects in the views/helper/redirects.py module.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 23:51:24 +0000] rev 620
Put the redirects in the views/helper/redirects.py module. Changed the getCreateRequestRedirect to comply with the new signature. Also changed it's docstring to a more suitable one. Fixed a useless merge in views/models/role.py in the process.
Sat, 29 Nov 2008 22:48:15 +0000 Style fixes for previous commit
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 22:48:15 +0000] rev 619
Style fixes for previous commit We also need to run pylint. Patch by: Sverre Rabbelier
Sat, 29 Nov 2008 22:36:51 +0000 Added invitation received message upon creating a new invite.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 22:36:51 +0000] rev 618
Added invitation received message upon creating a new invite. Moved the inviteAcceptedRedirect into the logic code. Added a TODO for further user notification upon creating a request. Patch by: Lennard de Rijk
Sat, 29 Nov 2008 21:58:34 +0000 Now invited users can create a new Host profile
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:58:34 +0000] rev 617
Now invited users can create a new Host profile Before the invited user had to be a developer for this to work. Now, instead the default checkIsDeveloper check for the 'edit Host', a custom checkIsInvite check is used. Patch by: Sverre Rabbelier
Sat, 29 Nov 2008 21:21:04 +0000 Fixed requests not working anymore
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:21:04 +0000] rev 616
Fixed requests not working anymore We really need a test suite. Patch by: Sverre Rabbelier
Sat, 29 Nov 2008 21:04:09 +0000 Fixed a bug in latest commit
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:04:09 +0000] rev 615
Fixed a bug in latest commit Patch by: Sverre Rabbelier
Sat, 29 Nov 2008 19:45:19 +0000 Moved getSidebarLinks to sitemap.sidebar
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:45:19 +0000] rev 614
Moved getSidebarLinks to sitemap.sidebar This is the fourth, and final patch, that attempts to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier
Sat, 29 Nov 2008 19:44:48 +0000 Moved getDjangoURLPatterns to sitemap.sitemap
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:44:48 +0000] rev 613
Moved getDjangoURLPatterns to sitemap.sitemap Third commit in a series that aims to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier
Sat, 29 Nov 2008 19:00:03 +0000 Moved checkAccess and getCleanedFields into access and forms
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:00:03 +0000] rev 612
Moved checkAccess and getCleanedFields into access and forms A second patch in an effort to increase the cohesion in the base.View class. Patch by: Sverre Rabbelier
(0) -300 -100 -60 +60 +100 +300 +1000 tip