Add missing blank lines, clean up the doc string and remove white spaces at the end of the lines in reflistprop. Patch by: Pawel Solyga Review by: to-be-reviewed

Move <div id='notice'> into notice block in base.html template. Change formatting of notice block to make it much easier to "parse" visually. This patch is based on comments to r722. http://code.google.com/p/soc/source/detail?r=722 Patch by: Pawel Solyga Review by: to-be-reviewed

Add a third-party ReferenceListProperty class. This is going to be used to contain the references to Questions that make up a Quiz. Patch by: Todd Larsen Review by: to-be-reviewed

Fix some defects for lookup user view. More information about the patch can be found under the link below. http://groups.google.com/group/melange-soc-dev/browse_thread/thread/5d378c8d3679945f/d1e7cc3a53adda4e Patch by: Chen Lunpeng Review by: Pawel Solyga

Add missing import in soc/views/site/sponsor/list.py which caused exception when app was deployed and first site you visited was "List Site Sponsors". Update files according to recent django update and django backwards incompatibility (for example newforms is changed to forms). Patch by: Pawel Solyga Review by: to-be-reviewed

Load ../vendor/django into trunk/app/django.

Fixed imports sorting based on comments for r751. http://code.google.com/p/soc/source/detail?r=751 Patch by: Pawel Solyga Review by: to-be-reviewed

Some indentations fixes. Changed all the email=id function arguments to email=id.email(). Patch by: Pawel Solyga Review by: to-be-reviewed

Some indentations fixes and ugettext_lazy() wrap up for DEF_DEV_LOGOUT_LOGIN_MSG_FMT in access.py. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename soc/logic/models/settings.py to model site_settings.py and apply import name change to soc/views/site/home.py Patch by: Pawel Solyga Review by: to-be-reviewed

Fix typos in doc string in sponsor.py and settings.py Patch by: Pawel Solyga Review by: to-be-reviewed

Remove spaces between dict key name and colon. Fix some typos based on comments http://code.google.com/p/soc/source/detail?r=739. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines between imports and sort all of the imports. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines between imports in access.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Rearrange imports in home.py so they apply to new discussed format (separate "from ..." and "import ..." blocks). Add Delete Document functionality. Patch by: Pawel Solyga Review by: to-be-reviewed

Bugfixes to the latest revision Some pages did not work due to missing imports, or wrongly imported modules. Patch by: Chen Lunpeng Reviewd by: Sverre Rabbelier

Added missing models/__init__.py and removed empty logic/model directory Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Dictionaries need String values for keys The cleanup patch earlier mistakenly used raw names as keys to the dictionary (such as one would do in a function call). This fixes that mistake. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Removed now-obsolete code from model.py and __init__.py Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Made the existing code use the new soc.logic.models Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Added invididual model logic files Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Also removed helper directory Which somehow did not get removed with the last commit Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Removed obsolete logic directories and added one for model The model/ directory will contain the Base logic classes. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Minor style and import fixes Incorperated changes as suggested by Todd and Pawel. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Missing changes to soc.views.helper.access Due to having to manually do the 'svn mv' of logic to helper, the changes to access.py got lost, this commit fixes that. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Moved soc/logic/helper/access to soc/views/helper/access Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Fix not working delete Sponsor functionality after recent commit. Add delete() method to Base class. Make soc.views.site.sponsor.delete() request handler use this method. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix not working isIdDeveloper() function after recent commit. There is still confusion within getFormFields method (email is not id), but this change doesn't address that problem. Patch by: Pawel Solyga Review by: to-be-reviewed

Changed location of the svn command in svn_load_dirs.pl script from '/usr/bin/svn' to 'svn'. That makes the script more universal and it should work on Linux, Windows and Mac OS X if the svn is in the PATH. Patch by: Pawel Solyga Review by: to-be-reviewed

Refactor nearly all the soc.logic code to use the Base class Instead of having a lot of duplicate code, this patch aims to reduce this duplication by introducing a Base abstraction. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Replace almost all occurences of linkname with link_name In an attempt to have some atomicness in these commits this patch does a rename for the sake of consistency. Not all were changed, but the next commit will address that. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Load /Users/solydzajs/Downloads/google_appengine/ into trunk/thirdparty/google_appengine.

Add missing __init__.py to soc/logic/helper folder (Caused home page not to work).

Removed now-obsolete getAltResponse* methods from simple.py The getAltResponse* methods have been replaced by the check* methods in soc.logic.helper.access. Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen Reviewed at: http://codereviews.googleopensourceprograms.com/1601 Review id: 1601

Refactor existing code to use the new access module Instead of ending up with many different ways to do access control, we end up having only one centralized place wher access control is done. Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen Reviewed at: http://codereviews.googleopensourceprograms.com/1601 Review id: 1601

Add an access control module The module's purpose is to check access requirements, (such as being logged in), and raise an exception containing a authentication request when the requirement is not met. Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen Reviewed at: http://codereviews.googleopensourceprograms.com/1601 Review id: 1601

Enable recently commited delete Sponsor request handler (added to map.py) and Delete button in Sponsor edit view. Still missing "Are you sure ?" question box. Patch by: Pawel Solyga Review by: to-be-reviewed

Create a submit_buttons blocks in all edit view templates and put submit buttons in separate html table (not as part of the fields table anymore). Patch by: Pawel Solyga Review by: to-be-reviewed

Create a submit_buttons block in group edit profile template so that submit buttons can be customized. Replace submit_message usage with new notice block (still work in progress in Lookup User views). Add customized edit profile template for Sponsor with delete button (not used yet, upcoming commit). Add delete Sponsor request handler. Patch by: Pawel Solyga Review by: to-be-reviewed

Add notification bar block in base.html template. Patch by: Pawel Solyga Review by: to-be-reviewed

Add #notice class declaration in soc.css for upcoming notification bar. Patch by: Pawel Solyga Review by: to-be-reviewed

Update indexes in index.yaml file. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix typo in getSponsorFromLinkName (key_name variable name instead of sponsor_key_name). Add deleteSponsor function for deleting Sponsor entities from datastore.

Style fix, as requested by Todd to dict usage Use "dict['key'] = value" instead of "dict.update({'key' : 'value'})" when updating only one key.

Call soc.logic.site.map.getDjangoUrlPatterns() to construct the urlpatterns from the site map, rather than explicitly listing them in app/urls.py. Patch by: Todd Larsen Review by: to-be-reviewed

Update soc/logic/site/sidebar.py to use parts of the "site map" in soc/logic/site/map.py to generate portions of the sidebar menu. Patch by: Todd Larsen Review by: to-be-reviewed

A site layout ("site map") of the web application, including URL regular expression patterns, Django views, and metadata for constructing sidebar menus and (eventually) breadcrumbs. One function, soc.logic.site.map.getDjangoUrlPatterns(), converts these details into urlpatterns for use by Django. Patch by: Todd Larsen Review by: to-be-reviewed

Url and Page classes used to encapsulate the "site map" information (URL regular expressions, Django views, menu item names, etc.) and the relation between pages in the site map. There are still lots of TODOs in this first pass. Patch by: Todd Larsen Review by: to-be-reviewed

urllib.quote() is needed by the soc/logic/site/map.py work, so import it from the Python 2.5.2 sources. The entire urllib.py is not supported by Google App Engine (yet?), since it relies on 'import socket' (App Engine provides a separate urlfetch module instead). Patch by: Todd Larsen Review by: to-be-reviewed

Remove now-empty soc/views/helpers (everything has moved to soc/views/helper). Patch by: Todd Larsen Review by: to-be-reviewed

Add create() wrapper views that simply call the existing edit() views, to produce unique view names in preparation for the soc/logic/site/map.py code. Patch by: Todd Larsen Review by: to-be-reviewed

Speed up average case by appending remainder of original choices list unchanged (avoiding remaining str -> int type conversions) once the insertion point is found. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/html_menu.py to helper/html_menu.py, to clear out soc/views/helpers for deletion. Patch by: Todd Larsen Review by: to-be-reviewed

A specialized SortedDict used by soc/logic/site/page.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/forms_helpers.py to helper/forms.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/templatetags to helper/templatetags. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/response_helpers.py to helper/responses.py. Patch by: Todd Larsen Review by: to-be-reviewed

Replace helpers/custom_widgets.py with helper/widgets.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/template_helpers.py to helper/templates.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/request.py to helper/requests.py to avoid conflict with common local variable name "request". Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/list.py to helper/lists.py to avoid conflict with built-in type name "list". Patch by: Todd Larsen Review by: to-be-reviewed

Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py and replace uses of request_helpers. with helpers.request. instead. Patch by: Todd Larsen Review by: to-be-reviewed

Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change uses from list_helpers. to helpers.list. instead. Patch by: Todd Larsen Review by: to-be-reviewed

List views should have a selectable pagination "page" length: http://code.google.com/p/soc/issues/detail?id=59 Patch by: Chen Lunpeng and Todd Larsen Review by: Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/1201

Change to imports to follow the style guide: http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports Specifically: "Use from x import y only when x is a package and y is a module."

Make findNearestUsers() code in soc/logic/site/id_user.py more generic and move it to soc/logic/model.py. Orginal findNearest...() functions in id_user.py are now convenience wrappers. Add typed-query string construction functions to model.py. Move getFulLClassName() from key_name.py model.py, since it has more to do with Model types than key names. Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also, stop adding 1 inside the ...ForLimitAndOffset() functions and make the callers do it (since it was being added for a very UI-specific reason of whether or not to display a "Next>" link). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1401

Factor out an isIdAvailable() function from EditForm.clean_id() in soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py. Addresses some comments on r614. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1202

Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.

Fix typo in recent validate.py changes (r682). Patch by: Chen Lunpeng Review by: Todd Larsen

Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format). Patch by: Pawel Solyga Review by: to-be-reviewed

Add Sponsor logic functions. Patch by: Pawel Solyga Review by: to-be-reviewed

Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove excluded field inheritance_line, since the User model does not inherit from PolyModel (at this time).

Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.

Fix missing blank line to follow PythonStyleGuide in model.py.

Add links in sidebar for upcoming Sponsor views. Patch by: Pawel Solyga Review by: to-be-reviewed

Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules. Patch by: Pawel Solyga Review by: to-be-reviewed

Move path and link_name related functions and regex patterns to a new soc/logic/path_linkname.py module, and fix all dependencies. path/link_name functionality is becoming the generic way to identify entities in the Datastore in a URL-compatible way.

Make form field components use a smaller font, without shrinking the font of all text in the page body.

Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank line to follow PythonStyleGuide in document.py

Fixed typo in DEF_CREATE_NEW_DOC_MSG.

Shrink the sidebar menu separately from the main body text.

Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc). Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed models based on output from graph.py script and comments on http://groups.google.com/group/melange-soc-dev/browse_thread/thread/fb532a7db1f19ea7

Tool to graph the data model.

Some TODOs on access control that I didn't want to forget.

Matching just /docs created a very small namespace, since any other path parts would match the Document path. So, append /show after /docs for the display view. This makes other views like /docs/edit possible later.

URL pattern changes that were missed by r671.

Some styles used by r671, the simplistic Document view.

A very simplistic Document viewer.

Implements a Site (Developer) generic Document editor form.

Changes to make breadcrumbs match page title. This is mostly to see how it looks, since the new soc/logic/site/map.py code is going to implement the breadcrumbs and page title contents in a similar way.

Start using "Site" instead of "Developer" in the UI.

Implement a Developer list view of all Documents. Patch by: Todd Larsen Review by: to-be-reviewed

Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.

Fix some style guide issues: keyword arguments are supposed to always be supplied using the keyword argument name=value. http://code.google.com/p/soc/wiki/PythonStyleGuide#Default_Argument_Values

Directory for up-coming /site/docs/list and /site/docs/edit templates.

Fix typo in findNearestUsersOffset() __doc__ string missed in r661.

Show link to /site/user/list on /site/user/lookup when User is not found. http://code.google.com/p/soc/issues/detail?id=61 Patch by: Chen Lunpeng Review by: Todd Larsen (with modifications)

Add placeholder for future (to-be-implemented) getPreferredListPagination() function.

Remove a TODO that should have been removed for r658.

Update some of the URL patterns to get their link_name parsing from the new patterns in key_name.py. (Using it like this in urls.py is why key_name.py needs to not depend on other modules...)

Add functions to soc/logic/document.py for dealing with partial_paths combined with link_names. Add getWorksForOffsetAndLimit() to query for Documents for the /site/docs/list view.

Hide PolyModel inheritance_line bookkeeping property from the User Profile form.

Use the LINKNAME_PATTERN from its new home in key_name.py. Also, add some missing blank lines that are required by the style guide.

Add lots of new functions to key_name.py, including path/link_name processing. Copy various link_name related regex patterns to key_name.py and use them. Add error checking that raises a key_name.Error exception when name...() functions are given empty arguments. Hard-code class names, since they match what was typed into the module.class.__name__ to get the name anyway. This eliminates dependencies on any modules by key_name.py.

Add sidebar menu items for /site/docs/list and /site/docs/edit. They do not currently have view functions attached, but there are other links in the mock-up portion of the sidebar that don't currently work, either. The goal is to commit the /site/docs/list and /site/docs/edit changes in small bits that don't break anyone else.

Add partial_path property explicitly to the Work model.

Should have been part of the r650 commit.

Directory for upcoming /site/docs views.

Add "Last updated" footer to front page body text, using the modified Property from the Work entity.

Change _readonly_field_as_table_row <td> tag class names to match those used in _field_as_table_row. That should actually go into previous commit. Patch by: Pawel Solyga Review by: to-be-reviewed

Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view. Patch by: Pawel Solyga Review by: to-be-reviewed

Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.

Add key naming function for Sponsor, School, Organization, Club key_names. Patch by: Pawel Solyga Review by: to-be-reviewed

Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'. Patch by: Pawel Solyga Review by: to-be-reviewed

Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.

Replaced context.update call to simple value assignment in site.user.profile.create view function.

Load ../../google_appengine/ into trunk/thirdparty/google_appengine.

Take advantage of the Model inheritance provided by polymodel.PolyModel to have Club, School, Sponsor, and Organization actually inherit from the Group Model class, rather than being composed via ReferenceProperties. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/606

Take advantage of the Model inheritance provided by polymodel.PolyModel to have create a class hierarchy rooted at Person. Also, add some missing Role classes, such as Role, (Organization) Mentor, (Club) Member, (School) Student. Make (Organization) Administrator be a Reviewer like Mentor is. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/607

Make use of PolyModel for Works, Documents, etc. Add some (but not all) of the missing Models related to Documents. Refactor site settings to be useful for any "/home" page view. Make the resulting home settings store a reference to the Document, rather than looking up the Document by a hard-code key name. This is to set the stage for Document editing being generic, and then being able to select from some existing documents which one to use as the "/home" static content. This makes it possible to pre-edit several Documents, have them Reviewed, and then quickly change the "/home" page content as a setting, rather than editing the Document in the settings form (though settings forms might still embed the current document into their form for convenience). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1001

Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName(). Patch by: Pawel Solyga Review by: to-be-reviewed

Add ModelWithFieldAttributes *before* PolyModel, so that everything does not become a "ModelWithFieldAttributes" in the Datastore. The way PolyModel works, each Model class hierarchy is stored in the Datastore as the class that directly inherited from PolyModel. So, we do not want to insert ModelWithFieldAttributes *after* PolyModel by inheriting *from* PolyModel, or everything would just be a ModelWithFieldAttributes in the Datastore, instead of Person, Work, Group, etc.

Add the third-party PolyModel class. This class supports inheritance in Google App Engine Datastore Model classes.

A key_name controller module to collect all of the name...() functions that compose Model entity key names, plus some minor changes to other controller modules to illustrate the proposed use. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/804 Review URL: http://codereviews.googleopensourceprograms.com/804

Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.

Replace mock-up of sidebar with first draft of dynamic sidebar functionality.

Minor tweaks to Site menu item names to make them more descriptive.

Major refactoring, to switch from using inheritance from soc.logic.menu classes to an envelope-letter model instead.

Sidebar-building controller, with a TODO remaining to implement marking the current page as "selected".

Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes more closely related. This is part of some refactoring in my working copy to keep soc/logic/site/sidebar.py from having to deal with html_menu classes (which is like having view code in the controller, which is bad).

Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce HTML renderings of such lists.

Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere in the code.

Note 'groups' back-reference from 'founder' property in soc.models.group.Group.

Simple MenuItem and Menu classes for keeping track of ordered menus.

These changes should have been in r620, but somehow I did not save them, or saved over them with an old copy in the editor. Not sure...

Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module, since they are (mainly) used to manipulate parts of an HTTP request.

Split out HTTP request manipulation functions from template_helpers.py, which is in danger of becoming a "misc" or "util" module unnecessarily.

Changes in TinyMCE widget in custom_widgets.py based on review comments. Patch by: Pawel Solyga Review url: http://code.google.com/p/soc/source/detail?r=550

Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.

Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add list_helpers functions that are going to be used when rendering list views like (Users List, Sponsors List etc). Add list default templates and CSS classes. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add support for changing User id (Google Account email) in User Profile Developer view. Now user profile developer edit view includes hidden key_name field. Fix typo in user/profile.py. Show former user ids in lookup and edit User Profile Developer views. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Small change to unescape function in template_helpers (move replace('&amp;', '&') at the end).

Add rounded corners graphics. Add .notice class and rounded corners classes to soc.css file, those will be used to better visualize submit_message like "Profile saved.".

Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models. Patch by: Pawel Solyga Reviewed by: Todd Larsen Review issue: 801 Review URL: http://codereviews.googleopensourceprograms.com/801

Two changes to ease CI: 1) If pysvn is missing, the tests for svn_helper don't run and pollute the output 2) svn_helper no longer depends on being located at trunk/scripts/ Patch by: Augie Fackler Review by: Todd Larsen Review Issue: 802 Reviewed URL: http://codereviews.googleopensourceprograms.com/802

Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.

Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)

Testing buildbot. Sorry about the noise.

Testing buildbot. Sorry about the noise.

Make django.zip in release/, instead of in app/ with a symlink in release/. This allows debugging into app/django source code, which the presence of app/django.zip was blocking. Tested with both: dev_appserver.py release and dev_appserver.py app

A rough draft of the Group Model, to be merged with Pawel's current effort in his working copy. This is *very* incomplete...

First pass (from some old code notes) of a School Model (a form of Group).

First pass (from some old code notes) of a Club Model (a form of Group).

Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").

Add /site/user/profile Developer view for editing arbitrary User entities. Update /user/profile edit() view to fix TODO about updating the URL when a POST of the form changes the link_name of the User. Add a Create New User link to the base.html sidebar mock-up.

Fix off-by-one corner case discovered during testing of /user/profile.

Added getSingleIndexedParamValue() that retrieves an index into a list of values from the named query parameter, and then indexes into the supplied list of values to return the corresponding value from the list. Used to convert numeric index query parameters passed by POST to the GET redirect target, so that the GET code can display messages, etc. (without passing the message itself as a query argument and having to escape it or have silly people pass in their own...).

Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to implement the TODO in the User profile views where the link name portion of the URL needs to change when the link_name Property is updated by the form.

Fixed too long lines and deleted unused imports in id_user.py.

New default values for page title, header title and body of site home page.

Documentation updates and one typo fix.

Add a td.formfielderrorlabel style, to highlight field labels that have errors.

Swap field value and "required" columns to make more columns for field errors.

Add a verbose_name and help_text to the User.id Property.

Explain why pushd and popd are needed when making tiny_mce.zip.

Use zip to compress tiny_mce, and use zipserve to serve it in Google App Engine.

Updated make_release.sh docs and added way for person invoking the script to override script variables such as RELEASE using something like "RELEASE=../testing_release ./make_release.sh".

Add recently-moved feedparser and tiny_mce to APP_DIRS.

Oops, this should have been part of the r580 commit.

Oops, this should have been part of the r577 commit.

Move third-party TinyMCE out of soc/content/js and into the application image root, like other third-party code. Update the app.yaml.template to add /tiny_mce as a source of static content.

Add README files to explain how third-party code is maintained in these directories.

Discourage third-party code from being embedded in the soc framework.

Move third-party feedparser.py out of the soc framework package into its own package (similar to django).

Changed ZIPFILE variable to DJANGO_ZIPFILE in make_release.sh script and added 'cd $APP_FOLDER' before we zip django.

Load ../google_appengine into trunk/thirdparty/google_appengine.

upload.py customized to work with codereviews.googleopensourceprograms.com.

Pristine initial commit of upload.py script from http://code.google.com/p/rietveld (r310).

gcl.py customized to work with codereviews.googleopensourceprograms.com and the melange-soc-dev@googlegroups.com mailing list.

Pristine initial commit of gcl.py script from chromium.org.

Release shell script and associated changes. Set svn:ignore property on /app/django.zip file and /release folder. Patch by: Pawel Solyga, Augie Fackler Review by: Todd Larsen, review-after-commit Review issue: 363 Review URL: http://codereviews.googleopensourceprograms.com/363

FIxed documentation in soc/logic/document.py for getDocumentFromPath function Patch by: Christian López Espínol Reviewed by: Pawel Solyga Reviewed via: discussion on melange-soc-dev group

Forgot to change widgets to custom_widgets import in home.py after changing the name of soc/views/helpers/widgets.py file.

Added Melange front page edit view where you can change title, content, feed url. Created SiteSettings and Document models and some logic for them. Added isFeedURLValid function in soc/logic/feed.py. Created some functions for handling datastore updates of different kinds of Models (soc/logic/model.py). Fixed some typos and too long lines of code. Patch by: Pawel Solyga Review by: to-be-reviewed

Added feedparser to soc/utils and modified svn:externals for vendor to include feedparser svn Patch by: Pawel Solyga Review by: to-be-reviewed

Add getAltResponseIfNotLoggedIn() and getAltResponseIfNotDeveloper() simple view helpers. These cannot go into response_helpers.py because they create a circular reference with simple.py, and Django view import fails. Review URL: http://codereviews.googleopensourceprograms.com/602

Improve the __doc__ string of isIdDeveloper() to explain better how it now functions.

Make isIdDeveloper() also able to check an is_developer Boolean property in User entities. Review URL: http://codereviews.googleopensourceprograms.com/601

Replace checkLinkNameForId() with isLinkNameAvailableForId(), and implement that new function in terms of only the existing doesLinkNameExist() and doesLinkNameBelongToId(). Patch by: Todd Larsen Review by: Pawel Solyga Review via: discussion of patches on melange-soc-dev mailing list

Fixed one typo in response_helpers which caused is_admin context variable not to work correctly. Created new checkLinkNameForId function that checks if link_name is correct when creating new user and modifying existing one. This is now used for validation instead of doesLinkNameBelongToId in UserForm clean_link_name function. The previous validation function didn't allow to create new users and modify linkname of existing ones. Additionally I created new doesLinkNameExist helper function.

Fixed wrong user variable in lookup.html template for edit link (was user should be found_user). There is no DeveloperForm in site/user/profile.py changed that to LookupForm.

gcl.py committed this file, when it should not have even existed.

Add a /site/user/lookup view that provides Developers with a form to look up User entities given email addresses or link names.

...

Updated the script to: * Include a comment describing what it does * Use variables for anything non-standard * Use the --parse-only flag of epydoc * Exclude all 'django' modules through --exclude= * Run on '../app' by default, no more arguments needed * Clean up the output directory before running

Bugfix, invalid syntax noticed by epydoc.

Updated docs in response_helpers. Patch by: Pawel Solyga Review by: to-be-reviewed

Created custom_widgets.py and added TinyMCE django widget that can be later used for particular form fields. Patch by: Pawel Solyga Review by: to-be-reviewed

Added TinyMCE to Melange in soc/content/js Patch by: Pawel Solyga Review by: to-be-reviewed

An emerging pattern with makeSiblingTemplatesList() is that views calling that function then append a known, default template "just in case". This change adds a default_template parameter to makeSiblingTemplatesList() to eliminate the extra "append a known default to the end" step for the caller. Patch by: Todd Larsen Review by: to-be-reviewed

Refactor soc/views/user/profile.py to make use of several of the new views available in soc/views/simple.py. Patch by: Todd Larsen Review by: to-be-reviewed

Fix an overlooked cut-and-paste error. Patch by: Todd Larsen Review by: to-be-reviewed

Add a public() convenience wrapper around templateWithLinkName() for the common public.html case. Add a requestLogin() view. Patch by: Todd Larsen Review by: to-be-reviewed

This CSS change belonged with soc/templates/soc/error.html committed in r454. Patch by: Todd Larsen Review by: to-be-reviewed

A default error.html template to go with the simple.errorResponse() view. Patch by: Todd Larsen Review by: to-be-reviewed

Add soc.views.simple containing (initially) two simple template views. templateWithLinkName() is a view that can replace most public() read-only views. errorResponse() is a view that renders an error page for out_of_band.ErrorResponse exceptions. Also, change response_helpers.respond() to accept keyword arguments to pass to http.HttpResponse(). (errorResponse() makes use of this new respond() feature.) Patch by: Todd Larsen Review by: to-be-reviewed

Clean up User Model and User profile edit view now that soc.logic.site.id_user module exists. Change usage of "user" to be "id" the variable refers to a Google Account and not a User entity. Patch by: Todd Larsen Review by: to-be-reviewed

Pawel and I were working on the same thing, apparently. My template_helpers.py is more complete, so I am removing this one (that Pawel appears to not have used yet). Patch by: Todd Larsen Review by: to-be-reviewed

Factor out a getUniversalContext() function so that views that do not call response_helpers.response() can benefit from the code that constructs shared template context variables common to many templates. Patch by: Todd Larsen Review by: to-be-reviewed

Create a package for controller modules that interact with User entities. Patch by: Todd Larsen Review by: to-be-reviewed

A collection of functions for determining the characteristics of the "system" on which a Melange application is running. Currently, this consists of only a boolean isDebug() function. Patch by: Todd Larsen Review by: to-be-reviewed

Helpers for manipulating templates and template search paths. Patch by: Todd Larsen Review by: to-be-reviewed

Consolidate functions dealing with Google Accounts and look-up of User entities into a single site-wide controller module. Tests will be added in a subsequent commit as soon as Google App Engine tests using mocker are figured out. Patch by: Todd Larsen Review by: to-be-reviewed

Exception classes used by controller logic to request an "out-of-band" response be displayed by the view instead of what the view would normally display. Patch by: Todd Larsen Review by: to-be-reviewed

Base classes for all Datastore Models in Melange. Patch by: Todd Larsen Review by: to-be-reviewed

Load ../../google_appengine into trunk/thirdparty/google_appengine.

Create directories to load project into. * trunk/thirdparty/google_appengine: New directory.

Move third-party code that is not required to be part of trunk/app into a trunk/thirdparty "sandbox". Patch by: Todd Larsen Review by: to-be-reviewed

Move third-party code that is not required to be part of trunk/app into a trunk/thirdparty "sandbox". Patch by: Todd Larsen Review by: to-be-reviewed

Remove the obsolete scripts left over from when trunk/app did not contain the entire Google App Engine image. Patch by: Todd Larsen Review by: to-be-reviewed

Add mocker 0.10.1 to trunk/thirdparty, so that it can be used to create mocks for testing the Google App Engine app itself. See also: http://blog.appenginefan.com/2008/06/unit-tests-for-google-app-engine-apps.html Patch by: Todd Larsen Review by: to-be-reviewed

Move LICENSE.django closer to the actual trumk/app/django code we are importing (that exists in trunk/app to be part of the Google App Engine image). LICENSE.django cannot go in trunk/app/django itself, because that directory is maintained from the /vendor/django svn external using svn_load_dirs.pl (so putting all the way into trunk/app/django gets it repeatedly removed). Patch by: Todd Larsen Review by: to-be-reviewed

Third-party packages that do not need to be part of trunk/app (because they are not part of a Google App Engine image upload).

Since google_appengine isn't part of the uploaded trunk/app, there is no reason why it couldn't be in a thirdparty directory, alongside mocker.

Create directories to load project into. * trunk/google_appengine: New directory.

Added public view support (not using controller yet) Changed Google Account variable from user to id in views and templates (no more confusions with Melange user). Added templates_helpers for makeSimblingTemplate function. Addded new template tag readonly_field_as_table_row used in public views Fixed one typo in roles.py

User Profile view (without controller yet). Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 386 Review URL: http://codereviews.googleopensourceprograms.com/386

Moved Proposal model from wiki to source code and updated ProposalModel wiki page. Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 362 Review URL: http://codereviews.googleopensourceprograms.com/362

Moved td.formfieldlabel to FORM TABLE FIELDS section.

Move soc/control to soc/logic, so that tab-completion doesn't keep matching soc/content instead.

nickname was moved from Person to User recently.

Add Roles template directory that was missing from r426 commit.

Create package for up-coming Role views.

Minor indentation fix.

Create package for standard Melange controller modules.

Reduce the indent to two spaces per hierarchy level, comment some groups of tags that are related, move #header down by #footer.

Some additional __doc__ comments (with some ideas for future plans) and removal of some unnecessary imports.

Clean up some deletions from previous rearranging that did not get committed.

Fix up the URLs mapping to soc.views.user.profile.edit() and make the site base template (mostly a mock-up) point to /user/profile instead of the old /usr/linkname/profile from the static mock-up.

Move soc.views.user.profile.profile() to soc.views.user.profile.edit().

Flesh out the user/roles placeholders a little bit more.

Created response helper respond() function that is used to generate base templates and it's child templates (handles sign in/out links, user name etc). Updated User model helper text. Added basic user profile view (not finished yet). Added css entries for buttons and added buttons background. Added /user/profile and /user/profile/linkname support in urls.py.

Create placeholders for User Roles prototype.

Moved soc/site/home.html to soc/site/home/public.html and updated default template for public() in home.py

Indents in css file are now 2 spaces long. Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 385 Review URL: http://codereviews.googleopensourceprograms.com/385

Home site templates and basic view. Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 385 Review URL: http://codereviews.googleopensourceprograms.com/385

Updated User and Person models. Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 382 Review URL: http://codereviews.googleopensourceprograms.com/382

Debug flag value depends now on App Engine environment. Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 381 Review URL: http://codereviews.googleopensourceprograms.com/381

Changed name of the custom logo file. Now file name describes better image content.

Added logo for Melange home site (this will be used soon)

Added 404 and 500 errors templates. You need to set DEBUG = False in Settings.py in order to see the pages.

Created robots.txtx and simple Melange favicon. Added favicon and robots.txt support in app.yaml template.

Make soc.googlecode.com serve up mock-up pages as text/html.

Add a mock-up of a previously-run (but not currently running) Program.

Re-arrange mock-up paths for program/docs so that they go from less-specific (e.g. ghop2008, gsoc2009 program linknames) to more-specific (tos, rules, faqs document linknames). This matches the pattern of all of the other view paths, from "view descriptors" (like program/docs) to the specific item (ghop2008/rules).

New mockup for User Roles page.

Relative URL path structure example for Organization admin role, for a specific Program. View mock-up form will be added later.

Fix some broken links in the GHOP 2008 Program home page mock-up.

Finished migrating the "proto" app (which only contained a Person profile edit form) to the new combined trunk/app layout. Also, moved the form template from profile.html to profile/edit.html, to follow the "one template per view" approach (rather than have read-write vs. read-only logic in a single template).

Move app.yaml to app.yaml.template and add app.yaml to svn:ignore in trunk/app. Each Google App Engine instance needs its own "application:" ID, and this should *not* be committed into the SoC SVN repository in trunk/app. (Individual deployment branches *will* have app.yaml files with Google App Engine application IDs in them, just not trunk/app.)

Remove last remnants of /thirdparty/.

Move tests/ to top level of trunk/. Fix tests to run from new location. Add missing __init__.py modules to make relative imports from tests work properly.

Finish moving the remaining "prototype" app pieces out of apps/proto, and then remove trunk/apps. There is still some editing to do in the newly-relocated files (now in trunk/app/soc and trunk/app/ghop).

Change the MIME type of the remaining .html files to text/html

Set svn:mime-type to text/css so that browsers will use it as CSS when loaded from http://soc.googlecode.com/svn/trunk/mockups/

Set svn:mime-type to text/html so that browser will render the page when viewed via the http://soc.googlecode.com/svn/trunk/mockups/ link.

Mockups for some of the Melange views, adapted from the existing GSoC web app (but in some cases significantly altered). All of the relative links assume /svn/trunk/mockups/ so that the pages will display properly when accessed from http://soc.googlecode.com/svn/trunk/mockups/.

HTML mockups of proposed Melange (generic), GSoC, and GHOP pages and forms. The HTML files in this directory are formatted to be viewed directly from svn via http://soc.googlecode.com/svn/trunk/mockups/. All of the paths will be relative (rooted at /svn/trunk/mockups/) and instructions will be added (in a mockups/README file) for configuring an Apache web server for previewing the pages from the svn working copy during development.

Make static content framework- and program-specific.

Remove the old "gsoc" and "ghop" apps directories (which now only contain a lingering __init__.py file anyway).

Major reorganization of the soc svn repo, to merge into a single App Engine image (to make development easier, now that only a single app will run all Google Open Source programs).

First step of restructuring /trunk/ into a single App Engine app, avoiding all of the complicated scripts.

Changes to address comments by Sverre about the previous commit. Patch by: Todd Larsen Review by: Sverre Rabbelier Review issue: 301 Review URL: http://codereviews.googleopensourceprograms.com/301

Changes to address comments by Sverre about the previous commit. Patch by: Todd Larsen Review by: Sverre Rabbelier Review issue: 341 Review URL: http://codereviews.googleopensourceprograms.com/341

Changes to address Sverre's comments about the previous commit. Patch by: Todd Larsen Review by: Sverre Rabbelier Review issue: 321 Review URL: http://codereviews.googleopensourceprograms.com/321

Changes to address Sverre's comments to the previous commit. Patch by: Todd Larsen Review by: Sverre Rabbelier Review issue: 281 Review URL: http://codereviews.googleopensourceprograms.com/281

Addressed Sverre's commits on the previous commit. Patch by: Todd Larsen Review by: Sverre Rabbelier Review issue: 282 Review URL: http://codereviews.googleopensourceprograms.com/282

Script to 'svn cp' /trunk/apps/<app>, /thirdparty/, /trunk/soc/ into a branch. Patch by: Todd Larsen TO BE REVIEWED Review issue: 341 Review URL: http://codereviews.googleopensourceprograms.com/341

Script to 'svn export' /trunk/apps/<app>, /thirdparty/, /trunk/soc/ to local filesystem. Patch by: Todd Larsen TO BE REVIEWED Review issue: 321 Review URL: http://codereviews.googleopensourceprograms.com/321

Module for new_branch.py and related scripts to manipulate Google App Engine "image" directories. Patch by: Todd Larsen TO BE REVIEWED Review issue: 282 Review URL: http://codereviews.googleopensourceprograms.com/282

New svn_helper.py functionality for new_branch.py and related scripts. Patch by: Todd Larsen TO BE REVIEWED Review issue: 301 Review URL: http://codereviews.googleopensourceprograms.com/301

New settings.py functionality for new_branch.py and related scripts. Patch by: Todd Larsen TO BE REVIEWED Review issue: 281 Review URL: http://codereviews.googleopensourceprograms.com/281

Updated version of proto.css that defines some "form field" table cell styles that was missed in the previous commit.

Empty index.yaml file created by dev_appserver.py, so that it will stop showing up as an unknown file in the 'svn status' output.

A {% field_as_table_row %} template tag to simplify custom forms. (This template file was missed in the r348 commit.) Patch by: Todd Larsen Review by: Pawel Solyga Review issue: 221 Review URL: http://codereviews.googleopensourceprograms.com/221

Major revamp of Person model, splitting up poorly-validated properties into StringProperties, etc. Patch by: Todd Larsen Review by: Pawel Solyga Review issue: 261 Review URL: http://codereviews.googleopensourceprograms.com/261

A {% field_as_table_row %} template tag to simplify custom forms. Patch by: Todd Larsen Review by: Pawel Solyga Review issue: 221 Review URL: http://codereviews.googleopensourceprograms.com/221

List of countries and territories used in addresses. Patch by: Todd Larsen Review by: Maarten Lankhorst Review issue: 241 Review URL: http://codereviews.googleopensourceprograms.com/241

DbModelForm class that fixes verbose_name and help_text handling for Django forms generated from App Engine Datastore models. Patch by: Todd Larsen Review by: Augie Fackler Review issue: 201 Review URL: http://codereviews.googleopensourceprograms.com/201

Replace verbose text in __doc__ string with link to wiki topic about using nosetests to run the tests.

Fix a typo in the {% extends %} example and add a section on Model-specific View template sub-directories.

Add customized proto/person/profile.html template that was missed in the original apps/proto commit, and follow the new <model>/<view>.html directory structure now used in soc/templates/soc.

Move soc/profile.html into soc/person/profile.html, to avoid collisions between similarly-named templates.

First iteration of a "prototype" Melange app, along with an initial Person Profile view. Patch by: Augie Fackler (with some additions by Todd Larsen) Review by: Todd Larsen Review issue: 46 Review URL: http://codereviews.googleopensourceprograms.com/46

Helper module used by utility and tool scripts to access svn repositories. Patch by: Todd Larsen Review by: Sverre Rabbelier Review issue: 105 Review URL: http://codereviews.googleopensourceprograms.com/105

settings.py module (and associated tests) for reading a settings file and combining it with command-line options, for SoC utility and tool scripts. Patch by: Todd Larsen Review by: Sverre Rabbelier Review issue: 145 Review URL: http://codereviews.googleopensourceprograms.com/145

Make the scripts and scripts/tests directories into packages by adding empty __init__.py files.

Create a sub-directory for tests of scripts and script helper modules.

Nest GHOP module directories in a ghop/ghop sub-directory to preserve the module namespace when /trunk/apps/ghop/ is branched into a Google App Engine image.

Moving gsoc and ghop Melange app directories into /trunk/apps/ per Pawel's recent suggestion.

Move the GSoC-specific module hierarchy into a sub-directory to simplify the branch-building scripts.

Move the GSoC-specific module hierarchy into a sub-directory to simplify the branch-building scripts.

Initial definition of the Review Model. Patch by: Sverre Rabbelier Review by: Todd Larsen Review issue: 162 Review URL: http://codereviews.googleopensourceprograms.com/162

Initial definition of the Documentation Model. Patch by: Sverre Rabbelier Review by: Todd Larsen Review issue: 25 Review URL: http://codereviews.googleopensourceprograms.com/25

Initial definition of the Answer Model. Patch by: Sverre Rabbelier Review by: Todd Larsen Review issue: 102 Review URL: http://codereviews.googleopensourceprograms.com/102

Initial definition of the Host Model. Patch by: Sverre Rabbelier Review by: Todd Larsen Review issue: 101 Review URL: http://codereviews.googleopensourceprograms.com/101

Initial definition of the Work Model. Patch by: Sverre Rabbelier Review by: Todd Larsen Review issue: 24 Review URL: http://codereviews.googleopensourceprograms.com/24

Per tlarsen, remove this externals reference to Django trunk.

Initial definition of the Work Model. Review: http://codereviews.googleopensourceprograms.com/63

Initial implementation of the Reviewer Model in the reviewer.py module. Review: http://codereviews.googleopensourceprograms.com/42

Initial implementation of the Contributor Model in the contributor.py module. Review: http://codereviews.googleopensourceprograms.com/61

Clarify back-reference relations the same way that they are documented for the User model in user.py. Review: http://codereviews.googleopensourceprograms.com/81

Initial implementation of the Author Model in the author.py module. Review: http://codereviews.googleopensourceprograms.com/41

Initial implementation of the Administrator Model in the administrator.py module. Reviewed-at: http://codereviews.googleopensourceprograms.com/21

Script to generate epydoc documents in wiki/html/epydoc. Contributed by Sverre Rabbelier.

Oops. The original scripts sub-directory was put in the wrong place.

Initial conversion of the Person Model from PersonModel.wiki to person.py.

Initial revision of the user.py module, containing the User Model, from the patch contributed by Sverre Rabbelier. Thanks, Sverre, for contributing our first external patch!

Add /trunk/ of Django using svn:externals.

Initial AUTHORS file. Each contributor is added when their first contribution is commmitted.

Create the package directory structure for the GSoC and GHOP Melange applications, since we know that these are going to be written for sure.

Add a "namespace-subdivided" Django templates directory for the SoC framework.

Create the soc.views sub-package for modules that implement Views.

Define the soc package and the soc.models sub-package.

Add license text file for Apache 2.0 license.