Sat, 06 Dec 2008 21:32:36 +0000 Fix imports sorting in soc.views.models.organization.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 21:32:36 +0000] rev 690
Fix imports sorting in soc.views.models.organization. Patch by: Pawel Solyga
Sat, 06 Dec 2008 21:27:47 +0000 Add missing dots in docstrings in modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 21:27:47 +0000] rev 689
Add missing dots in docstrings in modules. Patch by: Pawel Solyga
Sat, 06 Dec 2008 21:05:17 +0000 Changed generic_name to group_label in models/program.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 21:05:17 +0000] rev 688
Changed generic_name to group_label in models/program.py. Also I've updated the comments and help text to explain the meaning of this field. Patch by: Lennard de Rijk
Sat, 06 Dec 2008 19:25:01 +0000 Updated to the latest version of upload.py
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 19:25:01 +0000] rev 687
Updated to the latest version of upload.py Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 16:52:21 +0000 Load ../../google_appengine_1.1.7/ into
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 16:52:21 +0000] rev 686
Load ../../google_appengine_1.1.7/ into trunk/thirdparty/google_appengine.
Sat, 06 Dec 2008 14:50:45 +0000 Comment fixes for state in group and role model.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 14:50:45 +0000] rev 685
Comment fixes for state in group and role model. Patch by: Lennard de Rijk
Sat, 06 Dec 2008 14:46:19 +0000 Fix for randomely ocurring bug
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:46:19 +0000] rev 684
Fix for randomely ocurring bug The bug and it's fix are described by the first comment from Guido in http://code.google.com/p/googleappengine/issues/detail?id=772. Patch by: Guido van Rossum
Sat, 06 Dec 2008 14:44:02 +0000 Changed state property for models/group.py to be optional as the description states.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 14:44:02 +0000] rev 683
Changed state property for models/group.py to be optional as the description states. Patch by: Lennard de Rijk
Sat, 06 Dec 2008 14:25:24 +0000 Added organizations
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:25:24 +0000] rev 682
Added organizations Really basic for now, next stop is to have a proper document selector for the Presences. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:24:50 +0000 Cleanups in group and program
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:50 +0000] rev 681
Cleanups in group and program The missing super call in group prevented the scope from being set as it should be. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:24:26 +0000 Added a new create regexp in urls for just scope_path
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:26 +0000] rev 680
Added a new create regexp in urls for just scope_path Now that scope_path is properly defined we can add a url matching just the scope path. This allows some other custom create regexps to be removed/rewritten. Note: It needs to be -after- the full key_name regexp, since for arbitrarily nested scopes it would always match as just scope_path, even if there are other fields needed after the scope. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:23:53 +0000 Introduce dynamic scope_path regexps
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:53 +0000] rev 679
Introduce dynamic scope_path regexps Instead of relying on scope_path's being "one slash deep", we should instead allow for either: 1. scope_paths that have a pre-defined depth 2. scope_paths that can be arbitrarily deep We achieve 1 by setting an entities scope_logic to another logic module. We then recursively call getScopeDepth until we get to the topmost entity (that is, an unscoped entity). A little different is the solution to 2, since some entities can have an arbitrarily deep scope (such as Documents), we need to have some way of signaling this to getScopePattern. A clean solution is to return None, rather than a number. If None is returned, the SCOPE_PATH_ARG_PATTERN is returned as regexp instead, which will match an arbitrarily deeply nested scope. The solution for 2 requires that we return None somewhere in the scope_logic chain, the most straight forward method to do so is to override getScopeDepth anywhere such a scope is needed and make it return None. A more elegant solution however, is to set the scope_logic to that module in all entities that require it. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:23:25 +0000 Added a linkable logic module
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:25 +0000] rev 678
Added a linkable logic module The linkable logic module is used to signal the fact that the scope of an entity can be any linkable. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 12:13:19 +0000 Fix scope lookup for unscoped entities
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:13:19 +0000] rev 677
Fix scope lookup for unscoped entities As scope_logic is now always set (since r1250), we need to check if it is None, rather than check if it exists. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 12:12:58 +0000 Swap the order of request key fields
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:12:58 +0000] rev 676
Swap the order of request key fields This will make it easier to remove scope_path as explicit key field at some point by having it as inplicit key field for all entities. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:53:26 +0000 Use key().name() instead of link_id
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:53:26 +0000] rev 675
Use key().name() instead of link_id This is now possible because key_name is constructed purely from the key fields of an entity. It is not sufficient to use just link_id, that works only for single-scoped entities (e.g., those that either do not have a scope, or that have a scope which itself does not have a scope). It would break if there was an entity that has a scoped scope (it would only include the scope's link_id in the url, which made it impossible to look up the scope as we missed the link_id of the scope's scope). Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:53:05 +0000 More DI on scope_logic
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:53:05 +0000] rev 674
More DI on scope_logic Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:31:08 +0000 Partial revert
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:31:08 +0000] rev 673
Partial revert Last commit contained some changes that did not belong there, revert them for now. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:26:15 +0000 Some more cleanups in base.Logic
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:26:15 +0000] rev 672
Some more cleanups in base.Logic Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:21:41 +0000 Apply DI on the scope logic
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:21:41 +0000] rev 671
Apply DI on the scope logic Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:21:01 +0000 Removed unused file path_link_name
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:21:01 +0000] rev 670
Removed unused file path_link_name Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:20:44 +0000 Remove unneeded method getSuffixValues
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:20:44 +0000] rev 669
Remove unneeded method getSuffixValues Patch by: Sverre Rabbelier
Fri, 05 Dec 2008 22:54:43 +0000 Some style and typo fixes in different modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:54:43 +0000] rev 668
Some style and typo fixes in different modules. Patch by: Pawel Solyga
Fri, 05 Dec 2008 22:27:04 +0000 Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:27:04 +0000] rev 667
Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module. Patch by: Pawel Solyga
Fri, 05 Dec 2008 22:25:57 +0000 Fix import sorting and docstring typos in soc.views.models.program module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:25:57 +0000] rev 666
Fix import sorting and docstring typos in soc.views.models.program module. Patch by: Pawel Solyga
Fri, 05 Dec 2008 22:25:08 +0000 Fix import sorting in soc.views.sitemap.build module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:25:08 +0000] rev 665
Fix import sorting in soc.views.sitemap.build module. Patch by: Pawel Solyga
Fri, 05 Dec 2008 12:24:02 +0000 Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 12:24:02 +0000] rev 664
Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template. Patch by: Pawel Solyga
Thu, 04 Dec 2008 10:09:38 +0000 Make base.View.create lookup the scope if appropriate
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 04 Dec 2008 10:09:38 +0000] rev 663
Make base.View.create lookup the scope if appropriate Also re-introduce the custom description of the list selection for the redirection. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 23:49:10 +0000 Make use of the new generic key_name by lookup up scope_path
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:49:10 +0000] rev 662
Make use of the new generic key_name by lookup up scope_path This way base classes do not have to look up the 'scope' property, instead they can rely on the base class to do it for them provided they define the 'scope_logic' param. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 23:48:33 +0000 Change the key name to not include entity type
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:48:33 +0000] rev 661
Change the key name to not include entity type This allows for direct lookup by scope_path, rather than having to do more complex things. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 23:48:10 +0000 Introduced django_extra_patterns
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:48:10 +0000] rev 660
Introduced django_extra_patterns This way no classes ever need to override the getDjangoURLPatterns, which results in less code, which is also more clear (that is, it is immediately obvious that a View adds an extra mapping if it sets the new django_extra_patterns value, or that it overrides the mapping when it sets django_patterns_defaults. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:28:16 +0000 Make scope_path required for program
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:28:16 +0000] rev 659
Make scope_path required for program Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:27:52 +0000 Factor out the Group part of Sponsor
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:52 +0000] rev 658
Factor out the Group part of Sponsor This makes it possible to reuse the Group logic. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:27:27 +0000 Rename role.RoleView to role.View
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:27 +0000] rev 657
Rename role.RoleView to role.View Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:27:01 +0000 Cleanups in the views module
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:01 +0000] rev 656
Cleanups in the views module Mainly rename from original_params to new_params (so that the keyword argument in the __init__ method is the same for all). Also use super(View, self) where appropriate. Patch by: Sverre Rabbelier
Wed, 03 Dec 2008 21:26:16 +0000 Cleanups to the logic module
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:26:16 +0000] rev 655
Cleanups to the logic module Mainly converting to super(Logic, self) and adding some missing empty lines while at it. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:05:13 +0000 Fixed the 'New Host' link
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:05:13 +0000] rev 654
Fixed the 'New Host' link Also removed the 'Invite Host' button from the Sponsor view now that the link is working. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:04:38 +0000 Make the 'select entity' View generic
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:04:38 +0000] rev 653
Make the 'select entity' View generic This allows the selection of any entity from an arbitrary View by specifying the 'target view' and the redirect function. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:04:15 +0000 Cleanups in preparation of general selector view
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:04:15 +0000] rev 652
Cleanups in preparation of general selector view Renamed LIST... to DEF_LIST since it is a global definition. Renamed getCreateProgramRedirect to getCreateRedirect since it will work on all entities as it uses params. Added a getParams method to base.View Updated selectSponsor as appropriate. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 22:03:46 +0000 Remove the logic parameter from getListContent
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:03:46 +0000] rev 651
Remove the logic parameter from getListContent Now that params always has a 'logic' attribute, we can use that instead of requiring that it is passed as argument. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 20:14:14 +0000 Changed clean_link_id to convert the input to lower characters for user comfort.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 02 Dec 2008 20:14:14 +0000] rev 650
Changed clean_link_id to convert the input to lower characters for user comfort. It has been changed in a couple of files, most importantly in logic/cleaning.py wich will be used by future forms to do their cleaning. Patch by: Lennard de Rijk
Tue, 02 Dec 2008 20:10:23 +0000 Finish Program
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 20:10:23 +0000] rev 649
Finish Program Added some fields, and made TinyMCE the editor for the description field. Also updated the public page to show these new fields. We really need generic public views... Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 18:48:42 +0000 Brown paperbag fix in recent cycle breaking
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 18:48:42 +0000] rev 648
Brown paperbag fix in recent cycle breaking Self is no longer used, 'error' should be used instead. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 17:59:44 +0000 Swap order of merged params to fix sponsor select view
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 17:59:44 +0000] rev 647
Swap order of merged params to fix sponsor select view The sponsor select view (in 'create new program') was showing the wrong information (and also using the wrong list template) because the order in which the params were merged was wrong way around. This fixes that and at the same time fixes the 'instruction_text' attribute, which should be named 'list_description' instead. At the same time we lookup and set Sponsor as the scope of the newly created program. Patch by: Sverre Rabbelier
Tue, 02 Dec 2008 17:14:18 +0000 Remove cyclic imports by moving response method of out_of_band.Error class to soc.views.helper.responses module as errorResponse function. Apply changes to affected files.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Dec 2008 17:14:18 +0000] rev 646
Remove cyclic imports by moving response method of out_of_band.Error class to soc.views.helper.responses module as errorResponse function. Apply changes to affected files. Patch by: Pawel Solyga
Tue, 02 Dec 2008 11:20:08 +0000 Remov unused import from Quiz model and add missing blank line.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Dec 2008 11:20:08 +0000] rev 645
Remov unused import from Quiz model and add missing blank line. Patch by: Pawel Solyga
Tue, 02 Dec 2008 10:44:56 +0000 Remove Great Britain from country list. Great Britain was included as a country, although it has a country code (.gb) it's not a state. United Kingdom is correct and remains in the list.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Dec 2008 10:44:56 +0000] rev 644
Remove Great Britain from country list. Great Britain was included as a country, although it has a country code (.gb) it's not a state. United Kingdom is correct and remains in the list. Patch by: Matthew Wilkes Review by: Pawel Solyga
Mon, 01 Dec 2008 21:38:25 +0000 Added programs
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 01 Dec 2008 21:38:25 +0000] rev 643
Added programs Currently the programs are somewhat of empty, but due to the ease with which we can add new fields later, it is acceptable to commit it in it's current form. Patch by: Sverre Rabbelier
Mon, 01 Dec 2008 21:37:27 +0000 Allow for extra dynamic fields for the create form
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 01 Dec 2008 21:37:27 +0000] rev 642
Allow for extra dynamic fields for the create form Also some minor cleanups, such as making base.Logic inherit from object, as per the style guide. Patch by: Sverre Rabbelier
Mon, 01 Dec 2008 21:30:01 +0000 Fixed a styling error.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 01 Dec 2008 21:30:01 +0000] rev 641
Fixed a styling error. Patch by: Lennard de Rijk
Mon, 01 Dec 2008 21:03:20 +0000 Added User welcome message.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 01 Dec 2008 21:03:20 +0000] rev 640
Added User welcome message. Added templates/soc/mail/welcome.html as a template for the message. Also fixed a cyclic import that was about to happen in notifications.py.
Mon, 01 Dec 2008 12:37:16 +0000 Some docstring fixes in few modules (soc.views.helper soc.views.models.base).
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Dec 2008 12:37:16 +0000] rev 639
Some docstring fixes in few modules (soc.views.helper soc.views.models.base). Patch by: Pawel Solyga
Mon, 01 Dec 2008 12:35:56 +0000 Add missing dot and correctly sort imports in soc.logic.helper.notifications module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Dec 2008 12:35:56 +0000] rev 638
Add missing dot and correctly sort imports in soc.logic.helper.notifications module. Patch by: Pawel Solyga
Mon, 01 Dec 2008 12:34:55 +0000 Some docstring and missing blank lines fixes in soc.views.sitemap modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Dec 2008 12:34:55 +0000] rev 637
Some docstring and missing blank lines fixes in soc.views.sitemap modules. Patch by: Pawel Solyga
Sun, 30 Nov 2008 22:30:01 +0000 Sponsor name now shows in List Hosts.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 22:30:01 +0000] rev 636
Sponsor name now shows in List Hosts. Patch by: Lennard de Rijk
Sun, 30 Nov 2008 22:15:39 +0000 Moved sendInviteMessage to a new module in logic/helper/notifications.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 22:15:39 +0000] rev 635
Moved sendInviteMessage to a new module in logic/helper/notifications.py. Renamed sendInviteMessage to sendInviteNotification. Removed the now obsolete imports in logic/models/request.py. This has been done to keep the models/logic modules clean.
Sun, 30 Nov 2008 21:49:14 +0000 Changed email address in logic/models/base.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 21:49:14 +0000] rev 634
Changed email address in logic/models/base.py. Patch by: Lennard de Rijk
Sun, 30 Nov 2008 21:28:25 +0000 Allow developers access to anything that does a checkIsInvited.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 21:28:25 +0000] rev 633
Allow developers access to anything that does a checkIsInvited. Patch by: Lennard de Rijk
Sun, 30 Nov 2008 17:37:06 +0000 Remove unused imports from some modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:37:06 +0000] rev 632
Remove unused imports from some modules. Patch by: Pawel Solyga
Sun, 30 Nov 2008 17:35:48 +0000 Fix typo and too long lines in soc.logic.models.request module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:35:48 +0000] rev 631
Fix typo and too long lines in soc.logic.models.request module. Patch by: Pawel Solyga
(0) -300 -100 -60 +60 +100 +300 +1000 tip