Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Jul 2009 11:59:00 +0200] rev 2584
Fixed GradingRecord and GradingSurveyRecord Logic to load the correct Model.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Jul 2009 11:39:41 +0200] rev 2583
Added denySidebar to several access checks.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 23:50:21 +0200] rev 2582
Added Surveys to sidebar menu.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 14:00:59 +0200] rev 2581
Changed title entry in GradingSurveyGroup's public template to name.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 11:52:35 +0200] rev 2580
Added skeleton view and templates for GradingSurveyGroup.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 11:47:31 +0200] rev 2579
Added name property to GradingSurveyGroup.
This can be used (by humans :D) to easily identify different instances of this model.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 11:00:17 +0200] rev 2578
Added missing blank line to GradingSurveyGroup logic.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 10:52:19 +0200] rev 2577
Added logic for GradingRecord and GradingSurveyGroup.
Daniel Diniz <ajaksu@gmail.com> [Thu, 09 Jul 2009 10:39:30 +0200] rev 2576
Removed results list from Survey edit.
Some changes to the Survey Result page have also been made, however the results viewer and the CSV export are not working properly in that View.
Reviewd by: Lennard de Rijk
Mario Ferraro <fadinlight@gmail.com> [Thu, 09 Jul 2009 10:16:29 +0200] rev 2575
Extended tooltip timeout to 10 seconds for all fields.
This is because the tooltip currently timesout to fast for people to read the whole stories they can contain. Especially because Surveys can have custom tooltips.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 15:45:53 +0200] rev 2574
Minor stylefix to StudentProject model.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 15:44:54 +0200] rev 2573
Changed the StudentProject model to handle a dynamic amount of GradeRecords.
This allows for a dynamic amount of moments where a StudentProject can be evaluated.
Also included in this patch are changes to the status property that will help to enable PA's to withdraw StudentProjects from the program without the need for a developer to step in.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 11:50:02 +0200] rev 2572
Renamed several files due to recent changes.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 10:45:49 +0200] rev 2571
Style fixing in GradeRecord model
Daniel Diniz <ajaksu@gmail.com> [Wed, 08 Jul 2009 10:40:46 +0200] rev 2570
Several Survey UI fixes.
Fixes:
Too narrow fieldsets in new question/option dialogs.
Survey submit (on take view) and save/export/etc. buttons at weird places, instead of at bottom.
Weird placement of radio buttons in Opera.
Too narrow selects in IE.
Broken images in edit view in IE and Opera.
Reviewed by: Lennard de Rijk (Only on IE)
Madhusudan C.S. <madhusudancs@gmail.com> [Tue, 07 Jul 2009 21:16:57 +0200] rev 2569
Fixed base template URL to tagged version of the deployed source code.
The old link revered to SVN based projects.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 07 Jul 2009 20:02:27 +0200] rev 2568
Fixed imports for Survey logic.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 07 Jul 2009 18:46:47 +0200] rev 2567
Added skeleton models for GradingSurveyGroup and Records.
SurveyRecordGroup has been renamed to GradingRecord.
GradingSurveyGroup will hold which Surveys should be linked. While the acompanying GradingRecords (with their reference to a GradingSurveyGroup) will hold the Records for each StudentProject that can take these Surveys.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 17:20:30 +0200] rev 2566
Added tag v0-5-20090706 for changeset c17b671e5657
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 17:19:57 +0200] rev 2565
Set new Melange version number to 0-5-20090706 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 17:18:41 +0200] rev 2564
Ensure that the Grade field data stays in clean_data.
This prevents a bug that happens when you pick an invalid entry in the choice a grade field. If this bug was triggered the value of the survey_record.grade was used. Now however a proper ValidationError is raised.
Daniel Diniz <ajaksu@gmail.com> [Mon, 06 Jul 2009 17:03:19 +0200] rev 2563
Add missing import to Project Survey view.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 16:32:14 +0200] rev 2562
Renamed several files due to recent changes.
Mario Ferraro <fadinlight@gmail.com> [Mon, 06 Jul 2009 16:21:51 +0200] rev 2561
Now properly escaping JS and converting new lines into br for Tooltips.
Patch by: Mario Ferraro, Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Mon, 06 Jul 2009 16:13:27 +0200] rev 2560
Added ability to add custom tooltips and UI improvements.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 15:06:05 +0200] rev 2559
Public Survey template now resembles the take template more closely.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 14:58:46 +0200] rev 2558
Added the possiblitity to add a description to the top of the Survey.
Thie uses the content property which has been inherited from the Work model.
James Levy <jamesalexanderlevy@gmail.com> [Mon, 06 Jul 2009 13:19:00 +0200] rev 2557
Use CSS instead of JS for Survey layout.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Mon, 06 Jul 2009 12:06:28 +0200] rev 2556
Remove the custom propmpt inside textareas and input fields.
This will hopefully be replaced with custom tooltips. Two reasons for this are that the tooltips will still be readable once your start typing and this way we avoid a bug that caused a textarea to go into prompt mode on some form validation errors.
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 06 Jul 2009 00:54:48 +0200] rev 2555
Fix HtmlSanitizer to return cleaned string in proper encoding.
This fix prevent HtmlSanitizer from throwing UnicodeDecodeError exception.
James Levy <jamesalexanderlevy@gmail.com [Mon, 06 Jul 2009 00:31:48 +0200] rev 2554
Added clear:right property to submit button in Survey take form.
Reviewed by: Lennard de Rijk
Mario Ferraro <fadinlight@gmail.com [Mon, 06 Jul 2009 00:29:30 +0200] rev 2553
Fix button layout on Safari 4.0 for Survey take page.
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 06 Jul 2009 00:16:47 +0200] rev 2552
Fix comment indention in survey-take javascript file.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 23:45:57 +0200] rev 2551
Renamed survey-take-090627.js to survey-take-090705.js.
James Levy <jamesalexanderlevy@gmail.com> [Sun, 05 Jul 2009 23:43:57 +0200] rev 2550
Increased bottom margin on comments for better grouping.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 13:31:34 +0200] rev 2549
Changed the filter for getting a SurveyRecord for a ProjectSurvey
ProjectSurveyRecords are characterized by the Survey and a Project entity. The user property is just there to state who last submitted the Survey.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 13:00:08 +0200] rev 2548
Added tag v0-5-20090705p1 for changeset c7726e3ab173
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 12:59:33 +0200] rev 2547
Set new Melange version number to 0-5-20090705p1 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 12:57:09 +0200] rev 2546
Ensure that accessViolations for Survey menu items get captured.
(Also ensure that you think before committing something you broke yourself :()
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 05 Jul 2009 12:19:19 +0200] rev 2545
Added tag v0-5-20090705 for changeset 8f3a8e066111
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 05 Jul 2009 12:18:31 +0200] rev 2544
Set new Melange version number to 0-5-20090705 in app.yaml.template.
James Levy <jamesalexanderlevy@gmail.com> [Sun, 05 Jul 2009 11:32:26 +0200] rev 2543
Added Menu items for all three kinds of Surveys to the program menu.
The menu items turn red when the user has not taken the Survey yet.
Patch by: James Levy, Lennard de Rijk
Reviewed by: to-be-reviewed
Daniel Diniz <ajaksu@gmail.com> [Sun, 05 Jul 2009 00:57:03 +0200] rev 2542
POST data always overwrites survey_record data when used to populate form.
It also fixes validation errors on takeGet.
Patch by: Daniel Diniz, Lennard de Rijk
Reviewed by: to-be-reviewed
Mario Ferraro <fadinlight@gmail.com> [Sat, 04 Jul 2009 18:48:58 +0100] rev 2541
Fixes bug when option name contains double quotes.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 18:53:37 +0200] rev 2540
Several style fixes due to code reviews.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 17:23:19 +0200] rev 2539
Ensure that long questions and comments are stored as db.Text.
This is done by adding the setCleaners methods which sets the appropriate cleaners for dynamic fields.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 17:16:16 +0200] rev 2538
Style fix in access module.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 17:02:51 +0200] rev 2537
Returned ProjectSurvey create to checkIsUser.
The access protection is properly done by the form validator.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 16:44:08 +0200] rev 2536
Added access checks for taking a Project(Grading)Survey.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 16:23:00 +0200] rev 2535
Brown paper bag fix for using non-existing logic in ProjectSurvey views.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:59:19 +0200] rev 2534
Fixed basic Survey access check.
Also enabled this check for all relevant Views. However ProjectSurveys and subclasses still need an additional check. A stub for this has been added to the access module.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 15:30:08 +0200] rev 2533
Fixed broken selection questions from refactoring SurveyForm.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:16:54 +0200] rev 2532
Fixed showing the correct list of projects for taking a Grading Project Survey.
Note that when a user is a mentor for a lot of Organizations the amount of subqueries might exceed the allowed amount. A TODO has been added to fix this issue. However this will hopefully not be a problem that pops up soon.
Also some minor docstring addition to Project Survey view.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:08:28 +0200] rev 2531
Refactored filter construction to _constructFilterForProjectSelection.
This allows Grading Project Survey to overwrite this method and create its own filter.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:29:13 +0200] rev 2530
Make sure that radio button questions validate correctly and allow only one choice.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:22:02 +0200] rev 2529
Added Daniel Diniz and Zachary Voase to the AUTHORS file.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:19:39 +0200] rev 2528
Added Daniel Diniz to authors for Grading Project Survey View.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 14:15:11 +0200] rev 2527
Add a grade field to the Grading Project Survey form.
This also takes care of validating and transforming the data into True(pass) or False(fail). GradingProjectSurveys are hereby working for developers.
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sat, 04 Jul 2009 13:53:17 +0200] rev 2526
Survey editing/taking Javascript and CSS fixes.
This patch adds some cosmetic changes and functional fixes:
- UI now removes all of the field content when a field is deleted,
- CSS tweaks, and jQuery hack to specialize comment CSS,
- fixed JS path in take.html.
Reviewed by: Pawel Solyga (with some small changes)
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 04 Jul 2009 12:07:27 +0200] rev 2525
Remove public role type from SURVEY_TAKING_ACCESS in Survey model.