Excluded the new StudentProject failed_evaluations property from Forms. (Something went wrong on my side this should have been in before the tag)

Added tag v0-5-20090713 for changeset 51d83d0572ec

Set new Melange version number to 0-5-20090713 in app.yaml.template.

Added failed_evaluations property to StudentProject model. This is used to store GradingRecords which state a fail for this project. It's a list because manual changes in GradingRecords might force multiple GradingRecords to state a fail. Also it needs to be clear which GradingRecords have been processed and with which grade_decision.

Changed GradingRecord heading/row templates to give more useful info.

Added view for editing GradingRecords. This view shows a list of GradingRecords if the id param is not present in the GET data. Also renamed grading_record to view_records and fixed the redirect for that page to also point to the GradingRecord edit page.

Fixed style error in GradingSurveyGroup Task model.

Made the locked property non-required. This makes it easier to generate a Form that can properly deal with GradingRecords. Since required boolean properties can only be set to true by such an automatically generated form.

Added template for editing GradingRecords.

Added getRecordLogic method to GradingSurveyGroup Logic.

Added redirect for editing a GradingRecord. The view for this will be added in a later commit.

Fixed bug where grade_decision would not be properly set in 2 out of 4 cases.

Style fix in callback.py

Fixed issue with opening items on survey lists while pressing ctrl button

Added messages to the Records page when a task has been successfully started.

Style fixes in GradingRecord Logic.

Changed GradingRecord list templates to show more info. They now show wether or not a Mentor/Student eval has been found.

Added GradingSurveyGroup tasks to the core URL's.

The buttons on the GradingSurveyGroup record page now enqueue Tasks.

Added Tasks to update/create GradingRecords for a given GradingSurveyGroup. Also added a stub to update StudentProjects for a given GradingSurveyGroup.

Added methods to GradingRecord Logic to facilitate creating/updating them. UpdateOrCreateRecordsFor will batch put GradingRecords for a given SurveyGroup and StudentProject. getFieldsForGradingRecord will return the fields that need to be set for a single GradingRecord entity given a StudentProject, GradingSurveyGroup and if it is an update a GradingRecord entity.

Added buttons to start tasks to GradingSurveyGroup Record view. Also fixed an error in the GradingRecord row template.

Fixed errors in comments and docstring for the Surveys Task module.

Refactored logErrorAndReturnOK into separate module.

buildout.cfg: We require nose as well for tests.

Added view to GradingSurveyGroup to list all records for a specified group. This view will later be extended with options to start Tasks for collecting the data and processing it.

Added listing templates for GradingRecords.

Add scope view for GradingSurveyGroup and set access checks. The access checks are now properly set for create, edit and show. To facilitate the scope view the access check have an extra check built in to ensure that a scope is actually present before cheking for an existing Program.

Fixed passing along empty params to scope selection view.

Renamed tag for latest version to match the app.yaml version entry. Thanks to Madhusudan C.S. for noticing this.

Added tag 0-5-20090711p1 for changeset 03aa33e8600b

Set new Melange version number to 0-5-20090711p1 in app.yaml.template.

Removed several sidebar entries for Surveys which where not properly working.

Added tag v0-5-20090711 for changeset 4db295c3fbb3

Set new Melange version number to 0-5-20090711 in app.yaml.template.

Fixed typo in ProjectSurvey reminder mail.

Fixed the redirect for Survey reminder emails.

Fixed typo in GradingProjectSurvey reminder email.

Add queue.yaml to build scripts.

Changed URL pattern for starting sending out survey reminders.

Added the Surveys Tasks to the registered URL patterns.

Added a view to start sending out a reminder. Note that this view is currently developer-only.

Added Surveys Tasks module to send reminders. All reminders are CC'ed to the org admins. Also added an index property on StudentProjects which is required for the reminder Tasks.

Added empty Tasks package and queue.yaml. Also reserved an admin only URL space for use by Tasks.

Edited help text to be more clear when a Survey has been submitted.

Add setOrganizationInSurveyRecords function to stats.py script. setOrganizationInSurveyRecords will iterate thru all ProjectSurveyRecords and GradingProjectSurveyRecords and set the organization property in the record model.This will be useful later for showing Org admins their mentors and students surveys list and results.

Add Organization reference property to ProjectSurveyRecord. Also update ProjectSurvey view _takePost method to set this property everytime survey is taken.

Fix indention and add missing dot in docstring in survey models.

GradingSurveyGroup now uses DynaForm for its forms.

Indention fixes and adding "reference_class=" in ReferenceProperty params.

Start using buildout to bring in external dependencies. This makes running tests easier in situations where dependencies are not always available, such as buildbot. Thanks to Matthew Wilkes <matthew@matthewwilkes.co.uk> for help and moral support.

Added GradingSurveyGroup to the sitemap and sidebar.

Completed the Create and Edit view for GradingSurveyGroup. Note that I've added a TODO to redo _editPost to give us kwargs. Would also get rid of hidden fields elsewhere. Reviewed by: Lennard de Rijk

Fixed GradingRecord and GradingSurveyRecord Logic to load the correct Model.

Added denySidebar to several access checks.

Added Surveys to sidebar menu.

Changed title entry in GradingSurveyGroup's public template to name.

Added skeleton view and templates for GradingSurveyGroup.

Added name property to GradingSurveyGroup. This can be used (by humans :D) to easily identify different instances of this model.

Added missing blank line to GradingSurveyGroup logic.

Added logic for GradingRecord and GradingSurveyGroup.

Removed results list from Survey edit. Some changes to the Survey Result page have also been made, however the results viewer and the CSV export are not working properly in that View. Reviewd by: Lennard de Rijk

Extended tooltip timeout to 10 seconds for all fields. This is because the tooltip currently timesout to fast for people to read the whole stories they can contain. Especially because Surveys can have custom tooltips. Reviewed by: Lennard de Rijk

Minor stylefix to StudentProject model.

Changed the StudentProject model to handle a dynamic amount of GradeRecords. This allows for a dynamic amount of moments where a StudentProject can be evaluated. Also included in this patch are changes to the status property that will help to enable PA's to withdraw StudentProjects from the program without the need for a developer to step in.

Renamed several files due to recent changes.

Style fixing in GradeRecord model

Several Survey UI fixes. Fixes: Too narrow fieldsets in new question/option dialogs. Survey submit (on take view) and save/export/etc. buttons at weird places, instead of at bottom. Weird placement of radio buttons in Opera. Too narrow selects in IE. Broken images in edit view in IE and Opera. Reviewed by: Lennard de Rijk (Only on IE)

Fixed base template URL to tagged version of the deployed source code. The old link revered to SVN based projects. Reviewed by: Lennard de Rijk

Fixed imports for Survey logic.

Added skeleton models for GradingSurveyGroup and Records. SurveyRecordGroup has been renamed to GradingRecord. GradingSurveyGroup will hold which Surveys should be linked. While the acompanying GradingRecords (with their reference to a GradingSurveyGroup) will hold the Records for each StudentProject that can take these Surveys.

Added tag v0-5-20090706 for changeset c17b671e5657

Set new Melange version number to 0-5-20090706 in app.yaml.template.

Ensure that the Grade field data stays in clean_data. This prevents a bug that happens when you pick an invalid entry in the choice a grade field. If this bug was triggered the value of the survey_record.grade was used. Now however a proper ValidationError is raised.

Add missing import to Project Survey view. Reviewed by: Lennard de Rijk

Renamed several files due to recent changes.

Now properly escaping JS and converting new lines into br for Tooltips. Patch by: Mario Ferraro, Lennard de Rijk

Added ability to add custom tooltips and UI improvements. Reviewed by: Lennard de Rijk

Public Survey template now resembles the take template more closely.

Added the possiblitity to add a description to the top of the Survey. Thie uses the content property which has been inherited from the Work model.

Use CSS instead of JS for Survey layout. Reviewed by: Lennard de Rijk

Remove the custom propmpt inside textareas and input fields. This will hopefully be replaced with custom tooltips. Two reasons for this are that the tooltips will still be readable once your start typing and this way we avoid a bug that caused a textarea to go into prompt mode on some form validation errors. Reviewed by: Lennard de Rijk

Fix HtmlSanitizer to return cleaned string in proper encoding. This fix prevent HtmlSanitizer from throwing UnicodeDecodeError exception.

Added clear:right property to submit button in Survey take form. Reviewed by: Lennard de Rijk

Fix button layout on Safari 4.0 for Survey take page. Reviewed by: Lennard de Rijk

Fix comment indention in survey-take javascript file.

Renamed survey-take-090627.js to survey-take-090705.js.

Increased bottom margin on comments for better grouping. Reviewed by: Lennard de Rijk

Changed the filter for getting a SurveyRecord for a ProjectSurvey ProjectSurveyRecords are characterized by the Survey and a Project entity. The user property is just there to state who last submitted the Survey.

Added tag v0-5-20090705p1 for changeset c7726e3ab173

Set new Melange version number to 0-5-20090705p1 in app.yaml.template.

Ensure that accessViolations for Survey menu items get captured. (Also ensure that you think before committing something you broke yourself :()

Added tag v0-5-20090705 for changeset 8f3a8e066111

Set new Melange version number to 0-5-20090705 in app.yaml.template.

Added Menu items for all three kinds of Surveys to the program menu. The menu items turn red when the user has not taken the Survey yet. Patch by: James Levy, Lennard de Rijk Reviewed by: to-be-reviewed

POST data always overwrites survey_record data when used to populate form. It also fixes validation errors on takeGet. Patch by: Daniel Diniz, Lennard de Rijk Reviewed by: to-be-reviewed

Fixes bug when option name contains double quotes.

Several style fixes due to code reviews.

Ensure that long questions and comments are stored as db.Text. This is done by adding the setCleaners methods which sets the appropriate cleaners for dynamic fields. Reviewed by: Lennard de Rijk

Style fix in access module.

Returned ProjectSurvey create to checkIsUser. The access protection is properly done by the form validator.

Added access checks for taking a Project(Grading)Survey.

Brown paper bag fix for using non-existing logic in ProjectSurvey views.

Fixed basic Survey access check. Also enabled this check for all relevant Views. However ProjectSurveys and subclasses still need an additional check. A stub for this has been added to the access module.

Fixed broken selection questions from refactoring SurveyForm. Reviewed by: Lennard de Rijk

Fixed showing the correct list of projects for taking a Grading Project Survey. Note that when a user is a mentor for a lot of Organizations the amount of subqueries might exceed the allowed amount. A TODO has been added to fix this issue. However this will hopefully not be a problem that pops up soon. Also some minor docstring addition to Project Survey view.

Refactored filter construction to _constructFilterForProjectSelection. This allows Grading Project Survey to overwrite this method and create its own filter.

Make sure that radio button questions validate correctly and allow only one choice. Reviewed by: Lennard de Rijk

Added Daniel Diniz and Zachary Voase to the AUTHORS file.

Added Daniel Diniz to authors for Grading Project Survey View.

Add a grade field to the Grading Project Survey form. This also takes care of validating and transforming the data into True(pass) or False(fail). GradingProjectSurveys are hereby working for developers. Reviewed by: Lennard de Rijk

Survey editing/taking Javascript and CSS fixes. This patch adds some cosmetic changes and functional fixes: - UI now removes all of the field content when a field is deleted, - CSS tweaks, and jQuery hack to specialize comment CSS, - fixed JS path in take.html. Reviewed by: Pawel Solyga (with some small changes)

Remove public role type from SURVEY_TAKING_ACCESS in Survey model.

try to fix the surveys-have-no-scope issue to-be-reviewed: also untested

addressed comments to previous version to-be-reviewed: still untested

return found entity for activity checks

survey access: stylefix and remove public role type

Style fixes in Survey helper.

Added _getSurveyTakeForm to the Survey view. Subclasses can overwrite this method to create their own form. ProjectGradingSurvey will likely be an example for this.

Only initialize a SurveyTakeForm in take instead of in takeGet and takePost. This will allow for other subclassed views to easily replace the form the view is using. Also small style fix in Survey helper.