Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 13:50:41 +0000] rev 1201
Added checkCanReviewGroupApp to acces.py.
To make this work allowSidebar decorator was added as well. This will make sure that the Review buttons show up in the sidebar.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 13:27:52 +0000] rev 1200
Added checkCanEditGroupApp to access.py.
Group Applications can now only be edited if they are either rejected or still in need of review.
Also fixed a bug in checkIsMyEntity.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 13:26:34 +0000] rev 1199
Fixed whitespace in /soc/models/group_app.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 09:20:09 +0000] rev 1198
Added some extra isUser checks to make sure that you have to accept the ToS before you can do anything concerning requests.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 08:36:05 +0000] rev 1197
Fixes a bug where notifications can't be deleted.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 08:33:46 +0000] rev 1196
Only do the update routine when the status changes for group_app's and role requests.
This helps prevent spamming multiple notifications.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 08:25:47 +0000] rev 1195
Fixed a bug where a GMAP error message would be displayed when the form was not valid.
The wrong params were used, so the wrong template was used to display the form. This also caused the instruction_text to dissapear.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Mon, 02 Feb 2009 22:58:57 +0000] rev 1194
The simplejson in Django is now used, so do not create a symlink in build.sh.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 21:48:37 +0000] rev 1193
Fixed a typo in getForCurrentAccount comment.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 21:46:01 +0000] rev 1192
Adds the possibility to exclude the user from the website.
getForCurrentAccount now only returns a user entity when it is valid.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 20:56:14 +0000] rev 1191
Fixed default value for write_access in Document model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 20:07:52 +0000] rev 1190
Probably fixed a bug on the live instance.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 17:02:31 +0000] rev 1189
More access related fixes
Also make it possible to do access checks for 'create'.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 16:57:21 +0000] rev 1188
Reset the RELEASE_TAG to None (unreleased) now that the 0.2-20090202 release
candidate branch has been created.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 16:44:17 +0000] rev 1187
Set RELEASE_TAG to 0.2-20090202rc for release candidate 02/02/2009.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 16:42:31 +0000] rev 1186
Fixed EOL errors.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 16:21:33 +0000] rev 1185
Create org_application now shows select program view.
Also fixed the menu heading.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 16:03:21 +0000] rev 1184
Use .logic in checkIsAllowedToManageRole at the caller
This is to be consistent with the rest of the module.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 15:39:22 +0000] rev 1183
Make getForFields work with no filter
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 15:34:45 +0000] rev 1182
Fixed EOL damage in org_app and access checks
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 15:04:04 +0000] rev 1181
Calling getForCurrentAccount where necessary.
Also fixed whitespace error in soc/views/models/user_self.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 15:00:43 +0000] rev 1180
Fixed club_app
The user could not edit their own club app due to a buggy check.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 14:47:09 +0000] rev 1179
Rewrite getForFields to use GQL instead of the Query API
Apparently the Query API does not support the IN statement.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 14:19:22 +0000] rev 1178
Removed work flow field from the check in getExtraMenus for program.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 14:09:24 +0000] rev 1177
More access related fixes
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 13:59:07 +0000] rev 1176
Fixed access related bugs
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 13:48:15 +0000] rev 1175
Make longitude and latitude hidden fields not required in soc.views.models.role module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:15:07 +0000] rev 1174
Fix broken Roles public templates. By mistake we used entity.user.public_name instead of entity.user.name.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:10:39 +0000] rev 1173
Changes in club_app and org_app public templates. Don't show email address in public template.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:09:18 +0000] rev 1172
Style fixes in soc.views.models.user module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:07:34 +0000] rev 1171
Style fixes in soc.logic.models modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:06:36 +0000] rev 1170
Fix missing indention in css file.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 23:36:50 +0000] rev 1169
Set the right field type in user_self to overcome confusion.
Also reverted a template change.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 23:27:28 +0000] rev 1168
Adding a hidden agreed_to_tos field when the user has signed the ToS.
This a more cleaner solution then r1774.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 22:51:14 +0000] rev 1167
Fix the JS but mentioned in the previous commit
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 22:48:48 +0000] rev 1166
Fix get args construction when there are multiple lists on the page
It is now possible to go back and forward through the liast, and
specify the limit (both offset and limit can be done per list).
The JS driving the list boxes is buggy, if visiting an url like:
http://localhost:8080/notification/list?limit_0=10
And then change the limit in the second checkbox, it directs to:
http://localhost:8080/notification/list?limit_1=25
Whereas it should redirect to:
http://localhost:8080/notification/list?limit_0=10&limit_1=25
The logic _does_ work properly when the limit of the changed list
is already present in the url.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 22:44:14 +0000] rev 1165
Unify 'getForFields' and 'getForLimitAndOffset'
This also fixes the broken list views for filtered lists.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 22:35:35 +0000] rev 1164
User profile now shows the time on which you signed the ToS.
Note that this solution is temporary and a hidden_field_as_table_row will be made by Pawel soon.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 20:44:47 +0000] rev 1163
Cleaned up access.py
Removed a lot of duplicate code and added more generic checkers in
their place.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 20:41:58 +0000] rev 1162
Do not return empty menu's in program.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 17:52:12 +0000] rev 1161
This patch prohibits changing of agreed_to_tos and agreed_to_tos_on by the Logic module.
This is used so that legally the agreed_to_tos fields can never change in the User model once set.
Patch by: Haoyu Bai
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 17:40:26 +0000] rev 1160
Add publish_location boolean property to Role model. This field indicates whether the User has agreed to publish his location. It is not supported yet in any logic, views or templates but we won't want to change models later so it's being added now.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 17:31:09 +0000] rev 1159
Fixes an error occurring when editing a User as Developer when the ToS have been signed.
By disabling the input of the field Django will not attempt to wrongly parse it as a DateTime instance.
Patch by: Haoyu Bai
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 17:21:46 +0000] rev 1158
ReadOnlyInput widget now shows text instead of a greyed-out input box.
Patch by: Haoyu Bai
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 17:14:42 +0000] rev 1157
Added status property to the user model.
This is to accommodate the ability to exclude users from using the website.
Note that since the access modules is currently undergoing some reconstruction changing the status will not actually effect the User yet.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:18:04 +0000] rev 1156
Fixed EOL and whitespace in org_app templates
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 16:14:25 +0000] rev 1155
Update error message that shows when Google Maps API key is missing.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:14:09 +0000] rev 1154
Implement the last step in the org application process.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:11:54 +0000] rev 1153
Refactored applicant from club view to group view.
This is to accommodate the OrgApplication Process.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 16:10:20 +0000] rev 1152
Add Google Maps integration for Role profiles create/edit views.
Now when editing/creating your Role Profile page Google Maps widget will show up at the bottom of the form as "Location" field. When you type in your Street, City, Country or State it will automatically update the map with the location based on your address. The zoom level depends on the address information you provided. So for example if you just select Country it will be different then when you select both Country and City. The longitude and latitude fields are hidden and are updated with the coordinates from the address you provided. Also if the map is not accurate enough you can adjust your location by dragging the red market, which will change your location and save new coordinates into hidden fields. This patch also includes some style fixes in soc.views.models.role module.
Patch by: Mario Ferraro & Pawel Solyga
Reviewed by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:09:43 +0000] rev 1151
Added org_app view and templates.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:07:37 +0000] rev 1150
Changed club_app review template to use key.name.
This will ensure that if we ever decide to change it to a scoped entity the review template will not break.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:06:22 +0000] rev 1149
Changed some errors in the org_app model.
The backup_admin property has been removed because it's present in the group_app model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:04:31 +0000] rev 1148
Added org_app logic.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:03:58 +0000] rev 1147
Changed group_app to use scope_logic in constructor.
This is so org_app logic can use a scope_logic.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:00:42 +0000] rev 1146
Changed getApplicantRedirect to use the key_name instead of just a link_id.
This is to make it work with OrgApplication.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:33:48 +0000] rev 1145
Fix import sorting in soc.views.models.document module to comply with our style guide.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:29:34 +0000] rev 1144
Rename 'Create a new document' links to 'Create a New Document', also rename 'Create a new Program' to 'Create a New Program' in soc.views.models modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:26:25 +0000] rev 1143
Fix missing dots and blank lines to soc.logic modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:25:27 +0000] rev 1142
Fix missing dot and wrong import sorting in soc.views.helper.access module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:24:43 +0000] rev 1141
Style fixes in soc.models.document module (adding of missing whitespaces).
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:24:00 +0000] rev 1140
Style fixes in soc.logic.models modules (basically removing of extra whitespaces).
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 13:07:12 +0000] rev 1139
Changed the url regexpr for review and added 2 missing imports.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 09:55:02 +0000] rev 1138
Refactored review and reviewoverview out of club_app.py
This is to help accomodate the upcoming OrgApplication.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 09:11:39 +0000] rev 1137
Added view for mentors.
This one is for real.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 22:59:27 +0000] rev 1136
Added two forgotten comments in rights.Checker
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 22:32:54 +0000] rev 1135
Hook up the ACL system for documents.
Org access checks are left unimplemented as they are not done yet.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 22:32:21 +0000] rev 1134
Final changes to the document model
With a seperate set of read and write permissions it is possible to
very accurately specify the ACL of the document.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 22:32:01 +0000] rev 1133
Added a rights module
The purpose of this module is to translate from document prefix
and status to a set of access checks.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 22:23:23 +0000] rev 1132
Replace name_on_certificates property with name_on_documents, since mentors, club admins, hosts and org admins don't get certificates it's better to name it 'Name on documents' which can indicate any kind of documents including awards certificates. Also don't show name_on_documents in public Role profiles, instead show user public name in that place.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 21:32:29 +0000] rev 1131
Changed display_name to name_on_certificates in models/role.py.
This is to make the intention of this property more clear as to display_name which would remind people of for instance nicknames or a replacement for their public name for this role.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 19:46:55 +0000] rev 1130
Added view and templates for mentors.
Mentors can be invited or send a request to become a mentor for a specific org.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 19:33:40 +0000] rev 1129
Fixed a bug in soc/views/models/role.py.
This bug allowed the creation of only invalid requests opposed to valid requests.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 19:02:53 +0000] rev 1128
Added a view and templates for the organization admin.
This means that org admins can now be created/invited.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:58:09 +0000] rev 1127
Fixed two small errors.
Removed an unnecessary edit_extra field in club.py.
And made group.py call getForCurrentAccount where necessary.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:55:34 +0000] rev 1126
Added organization view and templates.
Also added TODO's so it's clear what still needs to be done to make this work.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:44:00 +0000] rev 1125
Removed obsolete _editPost and _editGet in soc/views/models/club.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:25:11 +0000] rev 1124
Reverting a change from r1732 for reasons stated in soc/logic/models/group.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:06:34 +0000] rev 1123
Changed scope_logic for requests to linkable_logic.
This makes the scope_path for a requests of a variable length which is needed for reuse.
Patch by: Sverre Rabbelier and Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 17:01:56 +0000] rev 1122
Removed workflow type as keyfield from program.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:20:11 +0000] rev 1121
Added mentor and org_admin logic.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 16:16:44 +0000] rev 1120
Add an 'unread' style and add 'new document' link for user
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:15:53 +0000] rev 1119
Fixed a string formatting bug in soc/views/models/role.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:07:30 +0000] rev 1118
When moving stuff please make sure that all your belongings are safely secured.
Brown Paper Bag fix.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:04:22 +0000] rev 1117
Fixed a bug in role.py that made it call the wrong superclass.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:03:14 +0000] rev 1116
Moved create_extra_dynafields from club_admin and member to role.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 15:41:45 +0000] rev 1115
Cleanups in base.Logic
* Use regular kwargs instead of **kwargs
* Fold getKeyNameFromFields into _keyName
* Fold getIfFields into getFromFieldsOr404
* Rename getKeyValues to getKeyValuesFromEntity
* Rename getKeyFieldsFromDict to getKeyFieldsFromFields
* Rename getFromFieldsOr404 to getFromKeyFieldsOr404
* Rename getKeyValues to getKeyValuesFromEntity
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 15:40:32 +0000] rev 1114
Add checkIsProgramActive to the rights flushing
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 14:39:05 +0000] rev 1113
Small changes in Mentor model (we don't inherit from Reviewer anymore since model inheritance is not supported in datastore).
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 14:38:04 +0000] rev 1112
Add Organization Administrator model.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 14:37:39 +0000] rev 1111
Remove not used Administrator model that is replaced by Host model.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 14:18:02 +0000] rev 1110
soc/views/models/club.py now uses getForCurrentAccount where necessary.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 13:59:49 +0000] rev 1109
Edited the access check for show in site settings.
Not everyone should see our keys :).
And also moved the template to site folder and changed presence back to the way it should be.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 13:49:50 +0000] rev 1108
Added rights to soc/views/models/timeline.py.
Only a developer or a host for the program this timeline is for can edit it now.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 13:48:48 +0000] rev 1107
Added status to program.
Also added a new access_check and changed the program edit template to the basic one without edit timeline button.
Changed the program menu to show more helpful links like Edit Timeline.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:59:52 +0000] rev 1106
Flush sidebar when creating a new entity
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:36:07 +0000] rev 1105
Update site/home.html to match the new document structure
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 12:36:06 +0000] rev 1104
Added a Create a New Program link to the Program Owners's menu.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:35:40 +0000] rev 1103
Flush sidebar when creating site entity
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:22:01 +0000] rev 1102
Brown paper bag fix
We can only add the create link if there is a site entity.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:12:05 +0000] rev 1101
Made presence document retrievel specify prefix
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:11:34 +0000] rev 1100
Added a 'create new document' link to site
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 11:28:05 +0000] rev 1099
Remove simplejson module from our repository since it's a duplicate of django.utils.simplejson.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 11:25:53 +0000] rev 1098
Use django.utils.simplejson in soc.views.models.base pick method instead of our standalone simplejson module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:02:20 +0000] rev 1097
Add a 'Create new document' link for clubs, sponsors and programs
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:01:52 +0000] rev 1096
Added a getCreateDocumentRedirect
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:01:27 +0000] rev 1095
Add access control to document model and view
The access checks are not yet written, but at least the model is
stable from now on.
Also converted the document view to dynaform while at it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:00:49 +0000] rev 1094
Factor out the getPattern logic from params
This is to facilitate it's use by the document view later on.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:00:23 +0000] rev 1093
Made the /create/<scope> url conditional
The 'no_create_with_scope' parameter can be used to disable it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:00:01 +0000] rev 1092
Removed unused key_fields_prefix variable
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 21:59:38 +0000] rev 1091
Moved is_featured property to Document
Only Documents can be featured in the sidebar, as such it makes sense
to have this property in the Document model.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 21:59:13 +0000] rev 1090
Added missing dot.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 21:58:53 +0000] rev 1089
Copy the default django patterns rather than modifying them
This prevents an ever-growing list of urls in the case that
getDjangoURLPatterns is called multiple times.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 21:58:31 +0000] rev 1088
Added a clean_scope_path to cleaning
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 30 Jan 2009 20:16:53 +0000] rev 1087
Fix the notification bar messages that show up when you click 'Save Changes' button. It only works on Edit views right now.
Patch by: Madhusudan C.S
Reviewed by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 17:44:31 +0000] rev 1086
^_^, fixed header in templates/soc/request/list/heading.html.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 17:38:28 +0000] rev 1085
Renamed state to status where appropriate.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 17:23:19 +0000] rev 1084
Requests can now not be created when you already have a similar request or already have the role the request is for.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:46:08 +0000] rev 1083
Moved clean_club_app_link_id to cleaning.
This method is now also used by the club create_form. Which means that you cannot create a new club with an already reserved link_id until the club application has been rejected.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:30:43 +0000] rev 1082
Changed group_app logic to support scope_path.
Moved link_id only as keyvalues to club_app.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:16:48 +0000] rev 1081
Added a cleaning method to club_app view.
This ensures that you can't create a application for an already taken Link ID.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:15:26 +0000] rev 1080
Changed status in group app model to state.
Also changed it wherever needed to increase consistency.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 10:36:23 +0000] rev 1079
Changed clean_link_id to be in a wrapper form as well.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 09:44:46 +0000] rev 1078
Deleted soc/models/member.py since it's the equivalent of club_member.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 09:43:11 +0000] rev 1077
docstring fix in soc/models/student.py.
Patch by: Haoyu Bai
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 09:31:56 +0000] rev 1076
Added agreed_to_tos_on field in user and role model.
Also the user and user_self view no properly handle this new field.
The ToS will be shown on-screen (not in a nice way) only if it is in effect and a user has not signed it yet.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:07:04 +0000] rev 1075
Cleaned up overly enthousiastic comments
From the styleguide:
On the other hand, never describe the code. Assume the person reading
the code knows Python (though not what you're trying to do) better
than you do.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:05:37 +0000] rev 1074
Properly check if a program is active
Also cleaned up checkIsHost, which got merge-mangled when refactoring
the access module.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:04:12 +0000] rev 1073
Factor out the allowIfCheckPasses logic
Keep allowDeveloper around as convenience method though.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:02:47 +0000] rev 1072
Fix EOL damage and add link to first row item for notifcations
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 20:40:34 +0000] rev 1071
Added menu entries for a specific Sponsor Entity.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 20:29:07 +0000] rev 1070
Fixed rights flushing
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:26:03 +0000] rev 1069
Added resign as club admin and club member links to the club entity menu.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:18:20 +0000] rev 1068
Changed docstring for checkIsAllowedToManageRole.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:13:21 +0000] rev 1067
Added manage view for Club Admins, Club Members and Hosts.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:11:11 +0000] rev 1066
Added checkIsAllowedToManageRole to access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:10:21 +0000] rev 1065
Added manage redirect.
Also changed the menu layout for group entities.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 16:12:57 +0000] rev 1064
Edited existing templates to deal with the new fields in group model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:55:40 +0000] rev 1063
Redone access checks in club and sponsor model to deal with state property in their model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:54:50 +0000] rev 1062
Creating a new host or club_admin will set the group state to active if it's new.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:53:35 +0000] rev 1061
Redone access checks concerning groups to deal with the state property.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:46:33 +0000] rev 1060
Added state and shipping address fields to group model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:38:41 +0000] rev 1059
prefixing the link_id of a notification with a t for time to agree to the new link_id pattern.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 29 Jan 2009 09:33:50 +0000] rev 1058
Fix regexp for link id format validation. Link id needs to start with ASCII lowercase and not with digit, which caused User Profile view to crash.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 29 Jan 2009 08:14:46 +0000] rev 1057
Fix typos in comments and help text in soc.models.program module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 01:39:31 +0000] rev 1056
Added a simple slot allocation algorithm
Comes with a whole bunch of tests, but not nearly enough.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 23:52:25 +0000] rev 1055
Update test to match new sidebar caching signature
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 23:49:45 +0000] rev 1054
Add forgotten __init__.py to pymox
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Wed, 28 Jan 2009 21:01:37 +0000] rev 1053
Rename the confusing Tossed Model class to PresenceWithToS.
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 20:27:16 +0000] rev 1052
Added a 'allocations_visible' property to program
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 20:21:15 +0000] rev 1051
Create a new Tossed layer in the MVC
Also move is_enabled to program instead of presence.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 18:24:20 +0000] rev 1050
Add 'Flush Cache' button next to Admin link. It's visible only when working on dev_appserver locally. This is a quick way of flushing memcache.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 18:23:45 +0000] rev 1049
Fixed the edit site view having a delete button
Also a minor cleanup in group.py.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 17:33:05 +0000] rev 1048
Changed access.py to comply more with the style of the module.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 17:31:02 +0000] rev 1047
Changed the Terms Of Service boolean so that it is None as long as the user owning the account has not Agreed to it.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 16:50:54 +0000] rev 1046
Changed the verbose name for agrees_to_tos to I agree to the Terms of Service.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 16:48:41 +0000] rev 1045
Removed default value for agrees_to_tos in soc/models/user.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 16:40:16 +0000] rev 1044
Reverted r1646.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:43:30 +0000] rev 1043
Redone the user's profile page.
A user can now create his profile on /user/create_profile.
A user can edit his profile on /user/edit_profile.
Created new access checks to correctly allow access to the new profile page.
Changed the /user/edit_self.html template to /user/edit_profile.html.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:40:44 +0000] rev 1042
Renamed _getToSExampleText to getToSExampleText in soc/views/models/user.py.
Removed a TODO that has already been done.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:33:53 +0000] rev 1041
Added default values to the User model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:32:57 +0000] rev 1040
Added a TODO to soc/logic/models/site.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:31:54 +0000] rev 1039
Added new clean_agrees_to_tos to cleaning.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 15:25:50 +0000] rev 1038
Allow for a program on/off switch
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 15:24:02 +0000] rev 1037
Fix wrong order of decorators and some cleanup
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 15:22:34 +0000] rev 1036
Add an 'edit' link to the program menu
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 14:18:31 +0000] rev 1035
Allow for setting a edit_cancel_redirect
Defaults to list view for the entity but can be overriden by setting
the parameter manually. Falls back to history.go(-1) if not set.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 14:16:46 +0000] rev 1034
Make the user/edit.html template derive from soc/models/edit.html
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 14:15:00 +0000] rev 1033
Also flush the user's ACL's when flushing the sidebar
It is pretty pointless to flush the sidebar if the same ACL's will
be re-used anyway, so make sure the ACL's are flushed as well.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:26:47 +0000] rev 1032
Style fixes in soc.views.helper.redirects and soc.models.base modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:26:00 +0000] rev 1031
Add gmaps_api_key to context is settings entity exists.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:24:34 +0000] rev 1030
Style fixes in soc.views.models modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:23:19 +0000] rev 1029
Style fixes in soc.cache modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:22:41 +0000] rev 1028
Style fixes in soc.logic.cleaning module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:21:58 +0000] rev 1027
Style and import sorting fixes in tests modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 11:15:32 +0000] rev 1026
Fixed typo's in soc/views/helper/dynaform.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 02:28:52 +0000] rev 1025
Add grouping to the existing views
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 02:27:25 +0000] rev 1024
Group dynamically generated menu items
Also allow for grouping other views by setting the 'sidebar_grouping'
param to a value another than 'main'.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 02:25:51 +0000] rev 1023
Bugfixes after recent refactoring
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 02:24:13 +0000] rev 1022
Added Haoyu Bai to the AUTHORS file
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 00:45:35 +0000] rev 1021
Allow appending to dynainclude/-exclude
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 00:36:30 +0000] rev 1020
Reduce caching time of sidebar to 3 minutes
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 00:35:11 +0000] rev 1019
Flush cache if user makes a document featured
Also flush it if a new document is created as featured.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 00:33:47 +0000] rev 1018
Make tooltips work when tabbing
Fixed the tooltips on IE, and changed the background colour to be
nicer on Firefox.
Patch by: Haoyu Bai <baihaoyu@gmail.com>
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 22:59:01 +0000] rev 1017
Cache access checks and disable sidebar caching
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 22:57:19 +0000] rev 1016
Create a decorator for allowDeveloper
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 27 Jan 2009 21:56:32 +0000] rev 1015
Add profiling support to Melange. By assigning profile_main_as_logs or profile_main_as_html to main variable you can turn on profiling. profile_main_as_logs will log profile data to App Engine console logs, profile_main_as_html will show profile data as html at the bottom of the page. If you want to profile app on deployed app just set the profiling function and deploy it.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 27 Jan 2009 20:30:26 +0000] rev 1014
soc/views/models/user.py now uses dynaform and appropriate cleaning methods.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 27 Jan 2009 20:27:50 +0000] rev 1013
Added new clean methods in preparation for new User View.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 13:36:45 +0000] rev 1012
Fold checkAgreesToSiteToS into checkIsUser
No use in having a check that's not used except in another checker
anyway, so might as well fold it in.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 27 Jan 2009 12:47:28 +0000] rev 1011
Removed unused URL pattern in soc/views/models/request.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 11:17:18 +0000] rev 1010
Fixed two access related bugs
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 11:15:49 +0000] rev 1009
Added some very basic tests for the sidebar and access modules
Also updated run.py to set the USER_EMAIL variable.
Patch by: Sverre Rabbelier
Augie Fackler <durin42@gmail.com> [Tue, 27 Jan 2009 04:09:57 +0000] rev 1008
Fix testing views, which broke because now we need to register a proxy for the
memcache API as well.
Patch By: Augie Fackler <durin42@gmail.com>
Review By: TBR
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 26 Jan 2009 23:32:10 +0000] rev 1007
Major refactor of the access module
The first step to sanity is a leap into the unknown? Create an object
to represent the access checks for each module instead of a bunch of
loose functions.
Converted all views and params.py to use the new access checker.
Main differences:
* arguments to a checker can be passed by using a tuple
* checkers are referenced by string, rather than directly
* the Checker constructor handles merging with child views
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 21:22:53 +0000] rev 1006
Added a sidebar link for all users that accepted the ToS to a view that allows you to choose a club which you want to become a member for.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 20:33:20 +0000] rev 1005
Changed method name in access.py to fix overwriting another method.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 17:19:14 +0000] rev 1004
Fixed typo in club sidebar entry.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 17:11:54 +0000] rev 1003
Added sidebar entries for club entities.
Added the right['home'] to club and sponsor view.
Fixed some comments in the group view.
Also added a TODO for the sponsor sidebar entries.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 17:08:27 +0000] rev 1002
Added sidebar support for group instances.
Also group now properly inherits from the presence view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 16:11:50 +0000] rev 1001
Flush the sidebar cache when a new active role entity has been created.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 26 Jan 2009 16:04:19 +0000] rev 1000
Add pymox to tests folder.
Requested by Sverre.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 14:51:07 +0000] rev 999
Developers are hosts for every sponsor now.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 09:44:00 +0000] rev 998
Implemented the listing of all the roles in for a specific group.
Removed a TODO about removing the tolist assignment in soc/views/models/host.py because this list is now obsolete.
Added a TODO to change the redirect of the member listing once the manage page is done.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 23:35:39 +0000] rev 997
Added flushing the sidebar when dealing with notifications.
On request from Pawel Solyga.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 22:42:09 +0000] rev 996
Renamed checkIsHostForProgram to checkIsHostForSponsor.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 22:30:42 +0000] rev 995
Added rights check to sponsor.py.
In the process of doing so also fixed checkIsHostForProgram method in access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 22:15:13 +0000] rev 994
listRequests now only shows the requests that concerns the given group.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 22:05:25 +0000] rev 993
Renamed role_names to role_logic and made it a dictionary.
It now maps a role_name to role_logic. This will be useful for listing for instance club members.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 21:52:35 +0000] rev 992
Fixed a bug in access.py.
Context was not assigned to a variable during a redesign of access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 21:03:12 +0000] rev 991
Added cache flush for the user who creates a group and the user whose role has been activated.
As requested by Sverre Rabbelier.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 16:50:24 +0000] rev 990
Added two needed redirects in role.py.
To make this work properly group_view was added to params in club_admin and club_member.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 16:43:15 +0000] rev 989
Moved listRequests from club to group view.
Added a TODO for adding request list to sidebar entry for every group. And for setting the rights for Sponsor view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 16:29:36 +0000] rev 988
Flush the sidebar if a user's rights change
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 16:28:07 +0000] rev 987
Cache sidebar with a simple caching API
We cache the sidebar once for every user, the downside is that once
the user meets new access criteria, their sidebar does not get
updated. This can be fixed by calling soc.cache.sidebar.flush() when
appropriate.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 16:25:17 +0000] rev 986
Rename ModelProperties to EntityProperties
We use 'model' when referring to the db.Model, the context in which
'ModelProperties' was used we really mean 'entity', which refers to
an instantiation of the model.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 16:17:33 +0000] rev 985
Added getListRequestsRedirect to redirects.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 15:09:10 +0000] rev 984
Forgotten in last commit, the json template
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 15:03:12 +0000] rev 983
Added request listing for Club Admins.
This page will redirect them to the Request Processing page.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 15:01:55 +0000] rev 982
Changed the title for the process_request webpage.
Also removed some whitespace.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 14:43:49 +0000] rev 981
Added getProcessRequestRedirect method to redirects.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 12:28:26 +0000] rev 980
Added Club Members to SoC.
Every user can request to become a Club Member. Club Admins can invite users.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 12:22:53 +0000] rev 979
Added checkCanMakeRequestToGroup to access.py.
Note that states for a group have not been implemented yet, so a TODO has been added for this check.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 12:20:35 +0000] rev 978
Moved getGroupEntityFromScopePath to logic/models/role.py.
Also removed a TODO that has been done :).
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 11:44:25 +0000] rev 977
Have /entity/pick return a JSON object instead of a user view
This is in preparation of a patch that will add a more fancy picker
with JS.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 25 Jan 2009 11:31:40 +0000] rev 976
Add simplejson folder to build.sh script.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 25 Jan 2009 11:31:15 +0000] rev 975
Add simplejson library to app folder.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 09:10:23 +0000] rev 974
Removed unused method from access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 00:04:11 +0000] rev 973
Do not pass around request anymore in buildSidebar
It is no longer needed since checkAccess doesn't require it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 00:02:41 +0000] rev 972
Remove the request and arg parameter from the checkAccess call
They are obsolete with the introduction of kwargs (args was never
needed in the first place).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 00:01:19 +0000] rev 971
Use getSingleton in getUniversalContext
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 24 Jan 2009 23:56:34 +0000] rev 970
Use ugettext instead of ugettext_lazy
Reports from Matthew Wilkes indicate that the regular form of
ugettext works just fine. The downside of ugettext_lazy is that it
prevents pages containing ugettext_lazy-ed text cannot be memcached,
since they cannot be pickled.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 21:38:28 +0000] rev 969
Brown paper bag fix.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 20:51:51 +0000] rev 968
Fixed a bug in _editPost for club_admin and host.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 20:44:32 +0000] rev 967
Changed clean_url to work with dynaform.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 20:17:35 +0000] rev 966
Fixed a bug in _oncreate in soc/logic/models/club.py.
Non-existing fields were set.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 18:21:50 +0000] rev 965
Changed user_logic call to it's convenience function getForCurrentAccount.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 17:09:02 +0000] rev 964
Coding style fix in views/models/role.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 17:07:26 +0000] rev 963
Parameterized patterns in role.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 16:39:34 +0000] rev 962
Added request creation and processing to role.py.
This is used if you want to request to become a certain role for a group. For instance becoming a club member.
The process request view will also be used to cancel outstanding invites might this be necessary.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 14:14:14 +0000] rev 961
Add Madhusudan.C.S to AUTHORS. Fix docstring parameters list in soc.logic.models.base module Base class getForFields method.
Patch by: Madhusudan.C.S
Reviewed by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 14:14:11 +0000] rev 960
Added checkCanProcessRequest in access.py.
This is used in the upcoming Request patch.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:54:59 +0000] rev 959
Some style guide fixes, docstring fixes and removal of unused imports in different modules. Rename acceptInvite view variable to accept_invite in soc.views.models.host module to comply to our style guide.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:51:47 +0000] rev 958
Fix some missing dots in access and club_admin modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:50:59 +0000] rev 957
Add missing parameter description to docstring of soc.views.models.base module methods.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:47:21 +0000] rev 956
Make select link in _as_table_row.html a nice button instead of <a href>.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:45:57 +0000] rev 955
Remove extra whitespaces and fix too long lines in soc.logic.helper.request module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:25:15 +0000] rev 954
Remove unused imports from soc.models.club_admin model.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:24:45 +0000] rev 953
Remove extra blank lines in soc.views.models.request module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:24:07 +0000] rev 952
Rename acceptInvite view variable to accept_invite to comply to our style guide. Remove unused imports. Add missing blank lines in soc.views.models.club_admin module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:12:07 +0000] rev 951
Rename processInvite view variable to process_invite to comply to our style guide. Remove some not needed whitespaces. Fix listSelf method parameters docstring in soc.views.models.request module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 11:10:22 +0000] rev 950
Added missing dot to access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:07:16 +0000] rev 949
Check if timeline exists and when somebody tries to edit non existing timelime display error message. Add TODO regarding error message customization for Timeline. Add support for calendar widget in timeline for both gsoc and ghop programs (gsoc was hardcoded before).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:04:15 +0000] rev 948
Add missing blank lines and remove unused checkIsInvited function from soc.views.helper.access module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 10:59:28 +0000] rev 947
Rename soc/request/list/row.html template column class "to" to "for" since the name changed in header template.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 10:57:53 +0000] rev 946
Add missing dots in soc.views.helper.redirects module function docstrings.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 10:56:18 +0000] rev 945
Little change in soc.logic.hlper.request module completeRequestForRole function docstring.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 10:19:17 +0000] rev 944
Refactored invite system from club_admin to role to make the system work with host as well.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 10:18:30 +0000] rev 943
Fixed an access related bug in checkIsClubAdminForClub.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 00:27:36 +0000] rev 942
Fixed bug in access.py concerning host checks.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 24 Jan 2009 00:07:34 +0000] rev 941
Add a warning about discarding unsaved changes
Also set the colspan of the label (on seperate row) to max.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 23:42:07 +0000] rev 940
Changed the access checks to comply with state in request.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 22:57:10 +0000] rev 939
Make reference picker work for create too
Caveat, it only works for one reference atm.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 22:20:20 +0000] rev 938
Brown paper bag fix
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 22:17:49 +0000] rev 937
Do not crash if an invalid field name is entered
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:22:09 +0000] rev 936
Enable pick links for all the references we have
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:20:33 +0000] rev 935
Adust the as_table tag to render a pick link if appropriate
The templates are adjusted to pass on a 'reference' value, which
is the url_name of the view from which the entity should be picked.
The as_table (and related) function(s) construct and then pass on
this argument and enable takes_contex so that we have access to the
context of the enclosing template.
We only extract ReferenceProperties that end with '_link_id' since
that is how all RP's are currently named. It is not possible to
create a field with the same name as the RP, as GAE will try to
interpret it's contents as the key of an entity before even calling
any function we can override.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:18:39 +0000] rev 934
Add a 'pick' view to the appropriate views
Only views that represent entities that are pointed to by a
ReferenceProperty at some point are considered 'appropriate'.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:17:01 +0000] rev 933
Added a 'pick' view
This view can be used to pick a specific document and then redirect
to another view.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:15:16 +0000] rev 932
Add redirects for the new pick view
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:04:45 +0000] rev 931
Add a simple access check for a picker
The picker page should not be accessible if the required GET args are
not present.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 17:51:35 +0000] rev 930
Added missing changes from r1522.
Eclipse found it funny not to save resources ^_^.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 17:41:30 +0000] rev 929
Renamed redirect methods to comply with the rest of the module.
Added use for getInviteAcceptedRedirect in the soc/views/models/request.py process_invite view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 17:07:54 +0000] rev 928
Replaced the boolean properties in soc/models/request.py with a state property.
new : new Request
group_accepted : The group has accepted this request
completed : This request has been handled either following a creation of the role entity
rejected : This request has been rejected by either the user or the group
ignored : The request has been ignored by the group and will not give the user access to create the role
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 16:54:46 +0000] rev 927
Restore context in deny() page
Now that we know when the sidebar is doing the access checks we can
safely construct a new context in deny (without having to worry that
it will try to do more access checks that result in deny, which will
call for a new context... etc).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 16:53:19 +0000] rev 926
Bugfixes to last commit
Access rights for 'home' pages and an errornous endif tag.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 16:23:01 +0000] rev 925
Removed club property from club_admin model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 16:21:28 +0000] rev 924
Generate proper html instead of having nested <td> tags
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 15:32:58 +0000] rev 923
Hook up the 'home' view for site and program
Also point to it in the sidebar's "home" link.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 15:31:13 +0000] rev 922
Generate the 'edit settings' link dynamically
We used to point to '/site/edit', which is rather lame for a generic
presence template (especially since site has it's own template).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 15:29:42 +0000] rev 921
Create a new 'home' view for Presences
This also restores the 'show' view for Presences as there is no
need to hide it with the 'home' view anymore.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 12:00:48 +0000] rev 920
Added the new way to process invites for club_admin only.
This patch contains the separability needed to ensure that we can successfully do the access checks we need.
Host invites can for the time being only be completed by developers due to the reorganization.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:40:35 +0000] rev 919
Added missing comment to soc/views/models/club.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:39:14 +0000] rev 918
Changed the request templates to match the changes to the model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:38:24 +0000] rev 917
Added missing role_verbose.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:36:55 +0000] rev 916
Redid removeRequestForRole to completeRequestForRole.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:34:58 +0000] rev 915
Added verbose role name to the request model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:32:53 +0000] rev 914
Added various access methods in preperation for the new request system.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 09:08:26 +0000] rev 913
Added state property to role model.
This can be used when for instance a member has been removed from a club or a when a program has been marked inactive. Certain roles would then be shown on the upcoming roles page marked as previous roles. This would give us the archiving capability that was shown in the mockup.
Patch by: Lennard de Rijk
Reviewd by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 08:49:09 +0000] rev 912
Renamed org property in club_admin model to club.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 23:20:15 +0000] rev 911
Add slots and student applications/tasks limit integer properties to the Program model.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 22 Jan 2009 22:54:46 +0000] rev 910
Change build.sh to create a build/ output directory (rather than release/).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 22 Jan 2009 22:35:41 +0000] rev 909
Move make_release.sh to build.sh.
This script creates a "build" really, not a release. A separate release.sh
script should be written to automate the current manual release process (at
some point...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:04:00 +0000] rev 908
Remove unused decorators import from soc.views.models.role module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:03:32 +0000] rev 907
Fix idention in soc.views.models.club module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:02:40 +0000] rev 906
Fix missing dots in soc.views.helper.decoratos module docstrings.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:01:16 +0000] rev 905
Rename clean_existing_user_not_equal_to_current function to clean_users_not_same in soc.logic.cleaning module and fix affected files.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 17:26:14 +0000] rev 904
Hide the 'link_id' field for site
Also construct the scope_path from the fields in case the entity
has not yet been created.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 17:23:17 +0000] rev 903
Rename "site/settings" to "site"
The "/site/settings" view is not about the Site Settings an sich, but
more about the "site presence singleton". In this context it does not
make sense to call it "site/settings".
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 16:05:49 +0000] rev 902
Fixed one style error and one typo.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:04:48 +0000] rev 901
Presence is now a 'abstract' View, pull in members from program
This is signified by the removal of params['name'] and other values
that are required by params.py, but also by the removal of the 'view'
definition at the bottom of the file.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:03:17 +0000] rev 900
Extend dicts.merge to be (optionally) recursive
This is very useful when dealing for views that expect to be
inhereted from but wish to provide default values.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:01:51 +0000] rev 899
Fix form errors and hidden form errors
The conversion to django left out the 'prettyfying' of form and
hidden form errors, as these could occur when running live, restore
this behavior.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 13:50:25 +0000] rev 898
Added a cleaning method for a LinkProperty Field.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 00:07:36 +0000] rev 897
Fixed wrong conditional in soc/views/models/club_app.py.
Notifications will now be send again.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 00:03:28 +0000] rev 896
Fixed import sorting and indentation in soc/views/models/club.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 23:44:02 +0000] rev 895
Even developers need to agree to the terms of service for Melange
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 23:43:16 +0000] rev 894
Corrected the list index parameters in soc/views/models/club_app.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 23:18:39 +0000] rev 893
Added Ignored applications to the list view.
Also restored the New Club notification upon application acceptance. That broke in r1483.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 22:47:22 +0000] rev 892
Replaced boolean properties in soc/models/group_app with status property.
This property has 5 choices ['accepted','rejected','ignored','needs review','completed']
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 22:21:40 +0000] rev 891
Move getToSLink() to soc.views.helper.redirects.getToSRedirect().
Fixes a circular import problem that prevented the site-wide ToS link from
being displayed by checkAgreesToSiteToS(). This is now completely implemented.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:41:36 +0000] rev 890
Tighten more checkIsUser() access to checkAgreesToSiteToS() instead.
Update the checkIsHost() comment.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:32:51 +0000] rev 889
Make checkAgreesToSiteToS() the default access check for many other checks.
Replace checkIsUser() with the more-strict checkAgreesToSiteToS(). Also, add
missing args and kwargs parameters to checkAgreesToSiteToS() that were missed
in the merge right before commit.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:25:18 +0000] rev 888
Add checkAgreesToSiteToS() (partially implemented until circular import fixed).
Need to fix a circular import problem before the alternate message will
include a link to the site-wide ToS Document.
Also, fixed the descriptions in the first few check...() functions.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:09:52 +0000] rev 887
Take advantage of new "from ... import ... as ..." rules in the style guide.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 20:25:07 +0000] rev 886
Added clean_existing_user_not_equal_to_current to clean the backup Administrator field in an application.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:53:23 +0000] rev 885
Changed the redirect in club application overview to the correct page.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:45:13 +0000] rev 884
Changed checkIsClubAppAccepted into a more generic checkIsApplicationAccepted.
Also fixed a minor bug in club_app view.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:40:39 +0000] rev 883
Changed the collection name and help text for Organization member template.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:32:00 +0000] rev 882
Added club_app model and logic.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 18:50:22 +0000] rev 881
Added created and last modified timestamps to the group_app model.
Also edited the templates to show some extra information. The review template has the names for the new properties hard coded because the auto_add and auto_add_now datetimeproperties don't show up in the fields of the entity.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 18:25:37 +0000] rev 880
Fixed typo in r1446.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 16:13:51 +0000] rev 879
Changes in Role model.
Clarified that we are asking for a shipping adress. Also moved Agrees to ToS to the bottom.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:13:18 +0000] rev 878
Fix trailing whitespace and apply decorators
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:13:03 +0000] rev 877
Fix whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:48 +0000] rev 876
Make use of the new decorators in all applicable views
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:31 +0000] rev 875
Renamed showReviewOverview to review_overview and reviewOverview
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:16 +0000] rev 874
Fixed two trivial bugs
A "kwargs=kwargs" instead of **kwargs
Missing 'and entity' check
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:01 +0000] rev 873
Added a merge_params and check_access decorator
The merge_params decorator is very simple and takes self._params and
merges it with params. It's main purpose is to explicitly mark the
views in which it is intended that self._params is merged raw.
The check_access decorator factors out the access checking process
and passes args and kwargs to the access checking methods.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:11:47 +0000] rev 872
Prepare access to receive args and kwargs as argument
Also use two "magic values" when the sidebar is doing the access
checks, this might be useful later.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:35:10 +0000] rev 871
Reverted r1457.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:29:58 +0000] rev 870
Changed link in club_app accepted notification.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:11:45 +0000] rev 869
Added a new view to help with application -> group process.
The applicant view is available only when there is an accepted application present. This will be checked by the access checker in an upcoming patch. The view uses a special form so that certain fields cannot be edited by the user. These fields correspond to important fields filled in during the application process.
Create access for a club has now been set to Host level.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 14:57:12 +0000] rev 868
onCreate for a Club now marks any application for the same club as completed and invites the admins.
This is useful for when the club has been created without using the application.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 14:36:44 +0000] rev 867
Edited the method used to clean link_id in params.py.
Removed the clean_new_link_id from the logic/cleaning.py module because this is not used anymore.
This method should be replaced by a method that is used after all the fields have been cleaned so that the actual key_name of an entity can be constructed.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 13:55:06 +0000] rev 866
Fixed a typo in the comments of soc/views/helper/forms.py
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:39:29 +0000] rev 865
Fix missing import identified by pylint.
************* Module app.soc.logic.models.user
E0602: 99:Logic.agreesToSiteToS: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:37:43 +0000] rev 864
Fix missing import identified by pylint.
************* Module app.soc.logic.models.presence
E0602: 56:Logic.getToS: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:34:43 +0000] rev 863
Fix missing import identified by pylint.
************* Module app.soc.views.helper.responses
E0602:187:getToSLink: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:31:55 +0000] rev 862
Add agreesToSiteToS() logic method to indicate if User accepts site-wide ToS.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:18:07 +0000] rev 861
Give error messages more room in the existing form field "as_table" templates.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:14:05 +0000] rev 860
Add a clean_agrees_to_tos() validator that requires "Yes" if ToS exists.
Also, more user_logic.logic => user_logic fixes. If you are going to import
"as", you might as well make the renaming worthwhile. Maybe we need to add
a section on "import ... from ... as ..." in the style guide?
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:32:05 +0000] rev 859
Change "Show" to "Export" missed in r1446 commit.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:27:39 +0000] rev 858
Add an export() view, and implement it as text/text for Document.
For every Model except Document, the public() view is displayed for any
attempts to access the export() view.
Currently, the permissions for export() are the same as for public(). This
seems reasonable for Document, since anyone could extract the raw HTML from
the page source anyway. The permissions should probably be different for
other types of exports, such as vCard or iCard exports of profiles, CSV
exports of lists, etc.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:13:03 +0000] rev 857
If a site-wide ToS exist, display the User profile "Agrees to ToS" checkbox.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:01:24 +0000] rev 856
Set agrees_to_tos example text to link to site-wide ToS (or a warning message).
Also, since a renaming import statement is being used already, change
user_logic.logic to just user_logic.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:33:43 +0000] rev 855
Do not crash on *every* page load if there is no ToS Document.
'tos' ReferenceProperty might be present, but still be None.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:30:21 +0000] rev 854
A better way to add site-wide ToS link to *all* pages on the site.
getUniversalContext() already fetches a copy of the Site settings, so use that
to see if the site-wide ToS exist and produce a link.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:21:32 +0000] rev 853
Linux /bin/sh (GNU) is not the same as OS X /bin/sh (BSD), so use /bin/bash.
Fixes:
scripts/pylint/do_pylint.sh: 27: Syntax error: "(" unexpected
on Ubuntu (and possibly other Linux distros).
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 22:01:02 +0000] rev 852
Replace css class 'notice' that is used in User profile template field help text with new 'fieldhelptext' class. Notice is part of CSS for notification bar and we want width limit just for field help text not for notification bar text.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:48:28 +0000] rev 851
Add getSingleton() method to return the Site settings entity.
There is always only one Site entity, referred to by DEF_SITE_LINK_ID.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:37:30 +0000] rev 850
Return the ToS Document of the supplied Presence entity, if there is one.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:26:34 +0000] rev 849
Support HTML tags in form field example_text column.
Improve the Program Model example_text as an example.
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 21:00:55 +0000] rev 848
Disable R0801 messages in pylintrc. R0801 messages indicates that a set of similar lines has been detected among multiple file. This usually means that the code should be refactored to avoid this duplication but in our case it's useless since it shows a lot of imports code or authors.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 20:52:12 +0000] rev 847
Add calendar widget support for timeline fields. Fix docstring typo in soc.views.models.timeline module. Add timeline edit template which loads necessary javascript files for datetimepicker widget.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 20:49:49 +0000] rev 846
Remove member_template from extra_dynaexclude in soc.views.models.club since member_template is only available in Organization as of recent commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 20:16:07 +0000] rev 845
Add the agrees_to_tos property to Roles (as its own changeset this time...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 20:04:21 +0000] rev 844
Make getToSLink() an actual method for re-use by others.
Uses the views.helper.redirects module to create the /document/show path,
instead of hard-coding it as a format string.
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 19:40:41 +0000] rev 843
Fixed EOL and whitespace damage
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 17:56:10 +0000] rev 842
This file should not have been included in r1428. Reverting...
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 17:53:36 +0000] rev 841
Changing ReadOnlyBool to type "text" makes it display "True" or "False".
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 17:41:47 +0000] rev 840
When constructing the sidebar don't overide 'sidebar'
Instead specify 'sidebar_additional' and include it even if there
is a 'sidebar' defined.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:31:53 +0000] rev 839
Add datetimepicker javascript widget files and css file.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:27:36 +0000] rev 838
Set notice width to 450px. It was way too long. Notice is displayed with help text on yellow background in User profile.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:12:55 +0000] rev 837
Add missing blank line in soc.views.helper.params module. Fix docstring typo in soc.views.models.role module. Add missing dots at the end of sentences in soc.logic.cleaning and soc.view.models.user_self modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:10:04 +0000] rev 836
Add missing 'of' word to list description strings in soc.views.models.club_app module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:09:09 +0000] rev 835
Add missing blank lines and dots in soc.views.helper.templatetags.forms_helpers module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:08:16 +0000] rev 834
Move member_template property from Group to Organization model since it's Organization specific property.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:03:55 +0000] rev 833
Disable R0201 message in pylintrc since we allow for that kind of methods. R0201 tells us that method could be a function. Used when a method doesn't use its bound instance, and so could be written as a function.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:00:19 +0000] rev 832
Fix typo in settings.py (missing '>' character).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 15:59:07 +0000] rev 831
Add missing dots in docstrings. Add sendNotification parameters description to docstring in soc.logic.helper module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 20 Jan 2009 14:12:54 +0000] rev 830
Added missing import to views/models/notification.py
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 20 Jan 2009 14:09:39 +0000] rev 829
Users now have the right to delete their own notifications.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 13:19:45 +0000] rev 828
Load /Users/solydzajs/Downloads/google_appengine into
trunk/thirdparty/google_appengine.
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 01:12:43 +0000] rev 827
Split the notification list in read/unread
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:48:49 +0000] rev 826
Add an unread count indication next to the notification link
Similar to how this is done in gmail.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:48:30 +0000] rev 825
Use 'from .. import .. as ..' in user_self
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:48:16 +0000] rev 824
Fixed whitespace and EOL damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:11:38 +0000] rev 823
Add a 'pending/accepted/denied' seperation to club_app list
This is not only to make it easier to see which applictions have been
accepted, but also to make it possible to redirect to /club/create
for the accepted applications, rather than to /club_app/edit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:11:21 +0000] rev 822
Fixed whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:26:09 +0000] rev 821
Send a notifcation if a club application is accepted
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:25:49 +0000] rev 820
Factor out sendNotification from sendInviteNotification
This makes it easier to create different types of notifications,
such as a sendNewClubNotification.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:25:36 +0000] rev 819
Fixed whitespace and EOL damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:25:23 +0000] rev 818
Fixed whitespace damage
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 19 Jan 2009 16:23:37 +0000] rev 817
Added club_admin templates.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 16 Jan 2009 17:54:46 +0000] rev 816
Added Mario Ferraro to the AUTHORS list.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 16 Jan 2009 17:52:42 +0000] rev 815
Tooltips now properly disappear when another text box with a tooltip has been highlighted.
Also known as Issue 132.
Patch by: Mario Ferraro
Reviewed by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 15 Jan 2009 17:01:15 +0000] rev 814
Implement the checkIsClubAppAccepted function
Also added a stub for checkIsClubAdminForClub.
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 22:37:05 +0000] rev 813
Display state (but dis-allow edits) of User's agrees_to_tos boolean Property.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 22:30:24 +0000] rev 812
Add read-only boolean form field widget.
Developers should be able to view, but not change, the User's agrees_to_tos
state.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 22:02:39 +0000] rev 811
Add "agrees to site-wide Terms of Service" boolean property for all Users.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:56 +0000] rev 810
Hide 'tos' pull-down selector from Program profile forms.
Until a way to select Documents for use as the Terms of Service for a Program
exists (see http://code.google.com/p/soc/issues/detail?id=151), there is no
point in hacking in scope_path and link_id fields here. The per-Program ToS
feature will just be unavailable until an appropriate Document selector
exists.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:47 +0000] rev 809
Hide 'tos' pull-down selector from Group profile forms.
Until a way to select Documents for use as the Terms of Service for a Group
exist (see http://code.google.com/p/soc/issues/detail?id=151), there is no
point in hacking in scope_path and link_id fields here. The per-Group ToS
feature will just be unavailable until an appropriate Document selector
exists.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:34 +0000] rev 808
Hide 'tos' pull-down selector from Site Settings forms.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:24 +0000] rev 807
Hack in tos_scope_path and tos_link_id to select Terms of Service Document.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:05:15 +0000] rev 806
Show Terms of Service link in footer if tos_link is defined in the context.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:05:05 +0000] rev 805
Add a ReferenceProperty pointing to a Terms of Service Document.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 19:11:34 +0000] rev 804
Fixed a bug that was triggered on manual club creation without an application.
Now also sets the application_completed flag upon club creation.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 18:56:54 +0000] rev 803
Fixed missing params in views/models/club_app.py.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:18:10 +0000] rev 802
Added Club Admin model, logic, and view
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:17:44 +0000] rev 801
Invite (backup-)admin when creating a club
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:17:30 +0000] rev 800
Added a create method that uses an existing application
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:17:16 +0000] rev 799
Construct names automatically from base name.
Saves a lot of typing for the common case
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 14:49:45 +0000] rev 798
Fixed a wrong method being called when accepting/declyning an application.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 14:44:04 +0000] rev 797
Added basic review functionality for club applications.
The access rights are open for discussion.
The review page uses GET data to determine the decision made by the user.
For convenience the Review Club Applications button directs you to a multi-list view so you can see the state of different applications.
The review state will reset whenever the application has been changed using the edit form.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 14:14:38 +0000] rev 796
Fixed a typo in the comment in helper/access.py.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 13:50:41 +0000] rev 795
Added control fields to group_app.
Moved unnecessary fields containing questions about past participation from group_app to org_app.
Updated the club_app public page to show the correct information using twoline layout.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 13:28:04 +0000] rev 794
Added _readonly_field_as_twoline_table_row .
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 08 Jan 2009 21:44:03 +0000] rev 793
Resolved a bug when editing a timeline.
Scope path is now set correctly when editing a timeline.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:24:36 +0000] rev 792
Fixed line-ending and whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:24:27 +0000] rev 791
Added the club_app view, logic and model
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:24:10 +0000] rev 790
Removed unneeded params from club
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:52 +0000] rev 789
Moved the member_template field to app and removed 'optional'
Also shortened the verbose_name of the member_template field.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:42 +0000] rev 788
Factored out the clean_existing_user method
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:33 +0000] rev 787
Fix login link
Without the leading slash the link does not work on appspot.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:24 +0000] rev 786
Fixed a typo in the group_app model
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:15 +0000] rev 785
Added a twoline_edit.html page
An as_twoline_edit template tag was added for this purpose. This tag
renders the label field on a seperate line.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 08 Jan 2009 20:27:21 +0000] rev 784
Fix missing dots at the end of sentences in docstring and fix wrong import sorting in soc.logic.helper.notifications module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 08 Jan 2009 20:09:24 +0000] rev 783
Extract BSD license text into a separate file to make it easier to find.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 08 Jan 2009 17:22:37 +0000] rev 782
Fixed missing files in r1364.
Patch by: Lennard de Rijk
Augie Fackler <durin42@gmail.com> [Thu, 08 Jan 2009 15:31:41 +0000] rev 781
Fix the setup of the test environment, including clearing the datastore
between tests.
Augie Fackler <durin42@gmail.com> [Thu, 08 Jan 2009 15:31:33 +0000] rev 780
Add support for coverage to our testing system.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 07 Jan 2009 22:09:52 +0000] rev 779
Added support for creating clubs.
Patch by : Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 07 Jan 2009 21:58:43 +0000] rev 778
Added support for mutliple edit forms based on entity type
This makes it possible to have different edit forms in timeline based
on which workflow type is used.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 07 Jan 2009 21:57:48 +0000] rev 777
Added an 'edit timeline' button to the program edit page
Also made the create timeline functionality use the logic modules
introduced in the previous commit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 07 Jan 2009 21:57:12 +0000] rev 776
Started on edit timeline
Added a gsoc timeline logic module. Also added a scope_path as the
key_field to timeline. Updated the django_paterns to only include
the edit field and removed link_id as dynafield.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 07 Jan 2009 20:56:50 +0000] rev 775
Fixed missing import in soc/models/organization.py.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 07 Jan 2009 20:30:38 +0000] rev 774
Add hard-coded GroupApplication and OrgApplication Models.
These are being hard-coded because the "real" Question/Answer/Quiz/Response
implementation will not be ready any time soon.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 07 Jan 2009 20:24:38 +0000] rev 773
Mailing list EmailProperty should be StringProperty instead, so that it is
possible, for example, to supply a Google Group URL for sign-up purposes.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 07 Jan 2009 19:38:29 +0000] rev 772
Add IRC channel and mailing list properties to the Group and Organization
Models.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 07 Jan 2009 16:49:16 +0000] rev 771
Typo and style fixes.
Patch by: Pawel Solyga and Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 06 Jan 2009 21:21:09 +0000] rev 770
Fixed a bug where a new timeline would get created on every edit of an existing program.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 06 Jan 2009 20:56:48 +0000] rev 769
Added an elementary workflow choosing method to program creation.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 17:26:06 +0000] rev 768
Added logic and view classes for the Timeline model
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 17:25:54 +0000] rev 767
Sorted build.py's sitemap.addPages lines
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 16:55:27 +0000] rev 766
Made Program reference Timeline
Also made Timeline inherit from base like it should.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 16:01:16 +0000] rev 765
Copy/paste fix
Typo fix: s/founder/program
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 00:14:32 +0000] rev 764
Added a basic Timeline model
The timeline model will contain the deadlines and time ranges for the
individual programs.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Dec 2008 18:51:36 +0000] rev 763
Set no_create_with_key_fields paramater to True for Notifications.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 18 Dec 2008 09:52:20 +0000] rev 762
Revert "Overwrite default patterns in views/models/notification.py to disallow certain URL's."
This should instead be done by setting the no_create_with_key_fields
parameter to True.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 18 Dec 2008 09:52:04 +0000] rev 761
Allow disabling of the create url with key_fields
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 18 Dec 2008 07:02:48 +0000] rev 760
Overwrite default patterns in views/models/notification.py to disallow certain URL's.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 22:27:55 +0000] rev 759
Fixed a too long line in logic/helper/notifications.py
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 22:25:16 +0000] rev 758
Added base template for notification messages.
This makes the messages a bit more friendly by including a greeting and signature.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 22:15:21 +0000] rev 757
Added email message when receiving a notification.py
At the moment this only triggers when the new notification is your first unread message. Also fixed an url bug in the invite notification.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 19:33:03 +0000] rev 756
Changed invitation email and into a notification.
Also changed the public template for Notification to allow HTML code.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:15:32 +0000] rev 755
Remove unused imports and variables in different soc.views.models modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:13:07 +0000] rev 754
Remove unused import in soc.views.hlper.templatetags.forms_helpers module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:12:28 +0000] rev 753
Since DbModelForm has been renamed to BaseForm change super() call from BaseForm to djangoforms.ModelForm in soc.views.helper.forms module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:11:12 +0000] rev 752
Some docstring fixes and unused import removal in soc.logic.models.site module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:10:32 +0000] rev 751
Fix inheritance in soc.models.base module. FieldsProxy inherited from DbModelForm which was deleted in previous commits (replace that with BaseForm).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:08:16 +0000] rev 750
Fix too long lines in soc.logic.helper.notifications module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:07:18 +0000] rev 749
Remove unused import in soc.logic.accounts module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:06:13 +0000] rev 748
Remove unused imports in models modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:34:46 +0000] rev 747
In soc.views.models.notification module remove unused imports, add missing white space, change list() method definition to comply with base View list() method declaration. Add missing Meta class docstring.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:24:24 +0000] rev 746
Fix import sorting in soc.views.helper.access module and rename 'host' to 'Program Administrator'.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:22:50 +0000] rev 745
Remove not used TYPE_NAME, TYPE_NAME_SHORT and TYPE_NAME_PLURAL consts in all Group models.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:21:26 +0000] rev 744
Add missing dots, fix imports sorting and too long lines in different modules. Add TODO in soc.views.models.host module.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:51:03 +0000] rev 743
Have user/edit.html use the as_table tag as well
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:50:49 +0000] rev 742
Removed unused template
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:33:59 +0000] rev 741
Converted as_table to be a template tag
This allows us to move all the HTML from python code (which made it
extremely icky and unreadable) to Django templates, which is _a lot_
more readable, and makes it feasable for HTML/CSS experts to change
the way these tables are generated.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:33:41 +0000] rev 740
Added some example_text to program
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:33:29 +0000] rev 739
Added support for example texts
Initial patch by Benjamin, some minor fixes by Sverre.
Patch by: Benjamin Lyaunzbe, Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 18:21:35 +0000] rev 738
Brown-paper-bag fix in notification.py
Was missing a leading slash in the redirect.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 13 Dec 2008 14:55:00 +0000] rev 737
Notification property has_been_read changed into unread
Due to comments on r1309.
Patch By: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:28:01 +0000] rev 736
No override needed in notifications.py
The only downside is that the ?s=0 parameter will still be appended
but is not handled in list(). The right solution would be to update
list() so that it does say "Message Sent" or such, to give the user
an indication that their message was sent succesfully.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:27:40 +0000] rev 735
Make it possible to redirect anywhere after editPost
This makes it possible to not include the suffix in the redirect by
making it a named parameter.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:09:06 +0000] rev 734
Make the place of the rights declaration consistent
Other code places it at the top, so we should do that in notification
as well.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:08:45 +0000] rev 733
Remove custom override of django_patterns_defaults
Instead restrict access to the edit method, also, there is no need to
set the default access to allow.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:08:23 +0000] rev 732
Fix whitespace and EOL damage in notifcation.py
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:49:57 +0000] rev 731
Make use of readonly_field_as_table_row
Instead of manually typing out the <br /> etc.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:49:34 +0000] rev 730
Fix EOL-damage
We use \n for line endings, so remove the \r from public.html
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:49:11 +0000] rev 729
Make checkIsMyInvitation use Django to parse the URL
Using django is more reliable and makes the code easier to read as
there is no knowledge of the url layout required.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:48:49 +0000] rev 728
Added a readonly_multiline_field_as_table_row tag
This is useful when a field is allowed to include newlines.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 13 Dec 2008 11:02:08 +0000] rev 727
Using getForCurrentAccount where possible due to comments on r1309.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 12 Dec 2008 23:28:18 +0000] rev 726
Added Notifications.
Notifications will primarily be used to serve the user information message like "New Request Pending". The system can be expanded later on to a messaging system.
If you are a developer you can create message by going to notification/create . This has been done so the system can easily be tested. But will of course be visible in an easy-to-access location when the transition to a message system has been made.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:35:51 +0000] rev 725
Filter the "list Hosts" view
This way only those Hosts are shown that belong to a Sponsor the
user is a host for.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:35:28 +0000] rev 724
Allows a user object to be passed to accounts.isDeveloper
This saves a trip to the database if the user object has already
been retrieved.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:35:08 +0000] rev 723
Make getForFields use the db.Query API
While at it, add support for the IN statement in the form of a value
of the list type.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:34:39 +0000] rev 722
Added getForCurrentAccount to user.Logic
It returns the user entity associated with the currently logged in
user.
Patch by: Sverre Rabbelier