scripts/pylint/do_pylint.sh
author Daniel Bentley <dbentley@google.com>
Sun, 12 Apr 2009 09:06:45 +0000
branchgae-fetch-limitation-fix
changeset 2313 c39a81bce1bd
parent 2071 0aa24d8655ac
child 2328 e077dc264dff
permissions -rwxr-xr-x
Use offset_linkid instead of offset to scan >1000 entities. this is a first-cut. It works in all the ways I could make earlier versions fail. It passes link_id as URL parameters. It also has a new class LinkCreator which makes the main body of getListContents even easier to write. I wasn't sure if link_id's could have non alphanumeric characters; if so, they need to be URL encoded/decoded. I also need to go and remove any mention of raw offsets now, because we don't use them. I believe I've talked about this approach with a few of you and it sounded reasonable. Feel free to roll-back/fix/amend/comment-for-me-to-fix. This is my first big-logic-change to Melange. Patch by: Dan Bentley

#!/bin/bash
# Copyright 2008 the Melange authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#   http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# Set some environmental variables for pylint and run it on Melange code
# To disable some of the checks use options listed below:
# disable unused imports: --disable-msg=W0611
# disable TODO: --disable-msg=W0511
# disable cyclic imports: --disable-msg=R0401
# disable report: --reports=no
# disable similarity check: --disable-checker=similarities
#
# Checks listed above are disabled in silent mode 
# which can be run using --silent argument

SILENT_ARGS=""
ARGS=( "$@" )

if [ "$1" == "--silent" ]; then
  SILENT_ARGS="--disable-msg=W0511,R0401 --reports=no --disable-checker=similarities"
  ARGS[0]=""
fi

PROJ_DIR=$(dirname "$0")/../..
PROJ_DIR=$(cd "$PROJ_DIR"; pwd)
APP_DIR="${PROJ_DIR}/app"

# Note: We will add ghop and gsoc modules once there something in there
CHECK_MODULES="soc reflistprop settings.py urls.py main.py"

PYLINTRC=$(dirname "$0")/pylintrc
PYTHONPATH="${PYTHONPATH}:${PROJ_DIR}/app/:${PROJ_DIR}/thirdparty/google_appengine/"

export PYTHONPATH
export PYLINTRC

PYLINT_PATH=$(which pylint)

if [ "$PYLINT_PATH" = "" ]; then
  echo >&2 "Cannot find pylint. Make sure pylint is in your PATH variable."
  exit 1
fi

CHECK_MODULES_PATHS=""

for x in $CHECK_MODULES
do
    CHECK_MODULES_PATHS="${CHECK_MODULES_PATHS} ${APP_DIR}/${x}"
done

pylint $SILENT_ARGS $ARGS $CHECK_MODULES_PATHS