thirdparty/README
author Sverre Rabbelier <srabbelier@gmail.com>
Sat, 06 Dec 2008 14:23:53 +0000
changeset 679 77a286ff6667
parent 153 79d52c2d50a2
permissions -rw-r--r--
Introduce dynamic scope_path regexps Instead of relying on scope_path's being "one slash deep", we should instead allow for either: 1. scope_paths that have a pre-defined depth 2. scope_paths that can be arbitrarily deep We achieve 1 by setting an entities scope_logic to another logic module. We then recursively call getScopeDepth until we get to the topmost entity (that is, an unscoped entity). A little different is the solution to 2, since some entities can have an arbitrarily deep scope (such as Documents), we need to have some way of signaling this to getScopePattern. A clean solution is to return None, rather than a number. If None is returned, the SCOPE_PATH_ARG_PATTERN is returned as regexp instead, which will match an arbitrarily deeply nested scope. The solution for 2 requires that we return None somewhere in the scope_logic chain, the most straight forward method to do so is to override getScopeDepth anywhere such a scope is needed and make it return None. A more elegant solution however, is to set the scope_logic to that module in all entities that require it. Patch by: Sverre Rabbelier
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
153
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
     1
Third-party code that is *not* part of the application image (the Google App
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
     2
Engine SDK in trunk/thirdparty/google_appengine, for example) belongs in
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
     3
trunk/thirdparty.  For third-party code that *is* part of the application
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
     4
image, see the notes in trunk/app/README.
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
     5
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
     6
== THIRD PARTY LICENSES ==
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
     7
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
     8
Third-party code must also include a license text file, named LICENSE or
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
     9
COPYING, in the package subdirectory.  If the third-party package subdirectory
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
    10
is maintained automatically with a tool such as svn_load_dirs.pl (which
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
    11
removes files, such as license text files, that were added later to the
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
    12
"target" directory), place the license text file in the trunk/app directory
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
    13
and add the package name as a suffix.
79d52c2d50a2 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com>
parents:
diff changeset
    14