# HG changeset patch # User Pawel Solyga # Date 1224248691 0 # Node ID f90f9b22751aca70202cc380bdc168cf1785ca2e # Parent 5d5730f65fc89470a83c6229500fb5d0df3e7844 Move TODO about isDeletable Sponsor logic method to sponsor.py module and extend a little bit doc string. Patch by: Pawel Solyga Review by: to-be-reviewed diff -r 5d5730f65fc8 -r f90f9b22751a app/soc/logic/models/base.py --- a/app/soc/logic/models/base.py Fri Oct 17 12:52:02 2008 +0000 +++ b/app/soc/logic/models/base.py Fri Oct 17 13:04:51 2008 +0000 @@ -208,7 +208,7 @@ return self.updateModelProperties(entity, **properties) def updateOrCreateFromFields(self, properties, **kwargs): - """Like updateOrCreateFromKeyName, but resolves **kwargs to a key_name first + """Like updateOrCreateFromKeyName, but resolves **kwargs to a key_name first. """ # attempt to retrieve the existing entity @@ -217,11 +217,12 @@ return self.updateOrCreateFromKeyName(properties, key_name) def isDeletable(self, entity): - """Returns whether the specified entity can be deleted + """Returns whether the specified entity can be deleted. + + Args: + entity: an existing entity in datastore """ - - # TODO(pawel.solyga): Create specific delete method for Sponsor model - # Check if Sponsor can be deleted (has no Hosts and Programs) + return True def delete(self, entity): diff -r 5d5730f65fc8 -r f90f9b22751a app/soc/logic/models/sponsor.py --- a/app/soc/logic/models/sponsor.py Fri Oct 17 12:52:02 2008 +0000 +++ b/app/soc/logic/models/sponsor.py Fri Oct 17 13:04:51 2008 +0000 @@ -41,5 +41,13 @@ self._keyName = key_name.nameSponsor self._skip_properties = [] + def isDeletable(self, entity): + """Returns whether the specified Sponsor entity can be deleted. + + Args: + entity: an existing Sponsor entity in datastore + """ + # TODO(pawel.solyga): Check if Sponsor can be deleted (no Hosts, Programs) + return True logic = Logic()