# HG changeset patch
# User Sverre Rabbelier <srabbelier@gmail.com>
# Date 1235234422 0
# Node ID e9a2b1e87b1afb3fec0d39bd6294107cd119d7bd
# Parent  441a2b39f88be382de362ca7ef1b6f7cc0aa5c47
Added support for having a format string as scope_path filter

Patch by: Sverre Rabbelier

diff -r 441a2b39f88b -r e9a2b1e87b1a app/soc/views/helper/access.py
--- a/app/soc/views/helper/access.py	Sat Feb 21 16:39:46 2009 +0000
+++ b/app/soc/views/helper/access.py	Sat Feb 21 16:40:22 2009 +0000
@@ -85,6 +85,9 @@
 DEF_NOT_YOUR_ENTITY_MSG = ugettext(
     'This entity does not belong to you.')
 
+DEF_NO_ACTIVE_ENTITY_MSG = ugettext(
+    'There is no such active entity.')
+
 DEF_NO_ACTIVE_GROUP_MSG = ugettext(
     'There is no such active group.')
 
@@ -582,10 +585,15 @@
   @denySidebar
   def checkIsActive(self, django_args, logic,
                     field_name='scope_path', filter_field='link_id'):
-    """Raises an alternate HTTP response if Group status is not active.
+    """Raises an alternate HTTP response if the entity is not active.
 
     Args:
       django_args: a dictionary with django's arguments
+      logic: the logic that should be used to look up the entity
+      field_name: the name of the field that should be copied verbatim
+                  If a format string is specified it will be formatted with
+                  the specified django_args.
+      filter_field: the name of the field to which scope_path should be set
 
     Raises:
       AccessViolationResponse:
@@ -595,23 +603,27 @@
 
     self.checkIsUser(django_args)
 
-    if field_name and (field_name not in django_args):
-      self.deny(django_args)
-
     fields = {
         filter_field: django_args[filter_field],
         'status': 'active',
         }
 
     if field_name:
-      fields['scope_path'] = django_args[field_name]
+      # convert to a format string if desired
+      if field_name.find('%') == -1:
+        field_name = ''.join(['%(', field_name, ')s'])
+
+      try:
+        fields['scope_path'] = field_name % django_args
+      except KeyError, e:
+        self.deny(django_args)
 
     entity = logic.getForFields(fields, unique=True)
 
     if entity:
       return
 
-    raise out_of_band.AccessViolation(message_fmt=DEF_NO_ACTIVE_GROUP_MSG)
+    raise out_of_band.AccessViolation(message_fmt=DEF_NO_ACTIVE_ENTITY_MSG)
 
   def checkHasActiveRoleForScope(self, django_args, logic, field_name=None):
     """Checks that the user has the specified active role.