# HG changeset patch
# User Lennard de Rijk <ljvderijk@gmail.com>
# Date 1240137980 0
# Node ID df37a3ff8ed59878d19c3493aba25a1e418020a4
# Parent  9a47a64dcc08972605a0de55df0a54df80574652
Changed the type of Error occurring when no valid sender could be found to a FatalJobError in student_proposal_mailer.

This means that the job will be immediately aborted.

This patch is due to comments on r3000 by SRabbelier.

Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed

diff -r 9a47a64dcc08 -r df37a3ff8ed5 app/soc/cron/student_proposal_mailer.py
--- a/app/soc/cron/student_proposal_mailer.py	Sun Apr 19 10:37:10 2009 +0000
+++ b/app/soc/cron/student_proposal_mailer.py	Sun Apr 19 10:46:20 2009 +0000
@@ -121,7 +121,6 @@
     job_entity: a Job entity with key_data set to [student_key]
   """
 
-  from soc.cron.job import Error
   from soc.cron.job import FatalJobError
 
 
@@ -142,8 +141,9 @@
 
     if not default_sender:
       # no default sender abort
-      raise Error('No valid sender address could be found, try setting '
-                  'a no-reply address on the site settings page')
+      raise FatalJobError('No valid sender address could be found, try '
+                          'setting a no-reply address on the site settings '
+                          'page')
     else:
       (sender_name, sender) = default_sender