# HG changeset patch # User Lennard de Rijk # Date 1246626000 -7200 # Node ID c98bf890156e58d0a0af3d73ebcbf5f1e552182b # Parent 77ac8273f7a2b81bb3540ae931437d9c602e5ab9 Removed getSurveyResponseFromPost from Surveys helper. We will use the power of Django Forms instead of getting our own properties. This fits better into the rest of Melange which also uses this approach. diff -r 77ac8273f7a2 -r c98bf890156e app/soc/views/helper/surveys.py --- a/app/soc/views/helper/surveys.py Fri Jul 03 14:53:26 2009 +0200 +++ b/app/soc/views/helper/surveys.py Fri Jul 03 15:00:00 2009 +0200 @@ -774,50 +774,6 @@ return markup -def getSurveyResponseFromPost(survey, post_dict): - """Returns the data for a SurveyRecord that answer the questions - posed in the given Survey's schema. - - Args: - survey: a Survey entity - post_dict: dictionary with data from the POST request - """ - - # TODO(ljvderijk) deal with the comment fields neatly - - # get the schema for this survey - schema = SurveyContentSchema(survey.survey_content.schema) - schema_dict = schema.schema - - # fill a dictionary with the data to be stored in the SurveyRecord - response_dict = {} - - for name, value in post_dict.items(): - # make sure name is a string - name = name.encode() - - if name not in schema_dict: - # property not in survey schema ignore - continue - else: - pick_multi = schema.getType(name) == 'pick_multi' - - if pick_multi and hasattr(post_dict, 'getlist'): # it's a multidict - # validation asks for a list of values - value = post_dict.getlist(name) - - response_dict[name] = value - - # handle comments - if schema.getHasComment(name): - comment_name = COMMENT_PREFIX + name - comment = post_dict.get(comment_name) - if comment: - response_dict[comment_name] = comment - - return response_dict - - def getRoleSpecificFields(survey, user, this_project, survey_form, survey_record): """For evaluations, mentors get required Project and Grade fields, and