# HG changeset patch
# User Lennard de Rijk <ljvderijk@gmail.com>
# Date 1233652809 0
# Node ID 3318f8d006915920b531e6aee1585179ad12e896
# Parent  7785b5091f07c80aa641c9b5700a90aab33410a2
Added some extra isUser checks to make sure that you have to accept the ToS before you can do anything concerning requests.

Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed

diff -r 7785b5091f07 -r 3318f8d00691 app/soc/views/helper/access.py
--- a/app/soc/views/helper/access.py	Tue Feb 03 08:36:05 2009 +0000
+++ b/app/soc/views/helper/access.py	Tue Feb 03 09:20:09 2009 +0000
@@ -441,6 +441,8 @@
       django_args: the keyword args from django, only scope_path is used
     """
 
+    self.checkIsUser(django_args)
+
     if not field_name in django_args:
       self.deny(django_args)
 
@@ -571,12 +573,12 @@
     """Raises an alternate HTTP response if the specified group is not in an
     active status.
 
-    Note that status hasn't been implemented yet
-
     Args:
       group_logic: Logic module for the type of group which the request is for
     """
 
+    self.checkIsUser(django_args)
+
     group_entity = role_logic.getGroupEntityFromScopePath(
         group_logic.logic, django_args['scope_path'])
 
@@ -584,7 +586,7 @@
       raise out_of_band.Error(DEF_GROUP_NOT_FOUND_MSG, status=404)
 
     if group_entity.status != 'active':
-      # TODO tell the user that this group is not active
+      # tell the user that this group is not active
       raise out_of_band.AccessViolation(message_fmt=DEF_NO_ACTIVE_GROUP_MSG)
 
     return
@@ -623,6 +625,8 @@
        whenever the group in the request is not active.
     """
 
+    self.checkIsUser(django_args)
+
     fields = {
         'link_id': django_args['link_id'],
         'scope_path': django_args['scope_path'],