# HG changeset patch
# User Sverre Rabbelier <srabbelier@gmail.com>
# Date 1233589162 0
# Node ID 03db1f6d222ac79b8479c2900235e13d5eb46f83
# Parent  5bea281505f4ae9eef49d31fc617a33b852dbfb5
Make getForFields work with no filter

Patch by: Sverre Rabbelier

diff -r 5bea281505f4 -r 03db1f6d222a app/soc/logic/models/base.py
--- a/app/soc/logic/models/base.py	Mon Feb 02 15:34:45 2009 +0000
+++ b/app/soc/logic/models/base.py	Mon Feb 02 15:39:22 2009 +0000
@@ -284,35 +284,37 @@
       offset: the position to start at
     """
 
-    if not filter:
-      filter = {}
     if unique:
       limit = 1
 
-    format_eq = '%(key)s = :%(num)d'
-    format_in = '%(key)s IN (%(values)s)'
+    if filter:
+      format_eq = '%(key)s = :%(num)d'
+      format_in = '%(key)s IN (%(values)s)'
 
-    n = 1
-    conditionals = []
-    args = []
+      n = 1
+      conditionals = []
+      args = []
 
-    for key, value in filter.iteritems():
-      if isinstance(value, list):
-        count = len(value)
-        args.extend(value)
-        values = ', '.join([':%d' % i for i in range(n, n + count)])
-        sub = format_in % {'key': key, 'values': values}
-        n = n + count
-      else:
-        sub = format_eq % {'key': key, 'num': n}
-        args.append(value)
-        n = n + 1
-      conditionals.append(sub)
+      for key, value in filter.iteritems():
+        if isinstance(value, list):
+          count = len(value)
+          args.extend(value)
+          values = ', '.join([':%d' % i for i in range(n, n + count)])
+          sub = format_in % {'key': key, 'values': values}
+          n = n + count
+        else:
+          sub = format_eq % {'key': key, 'num': n}
+          args.append(value)
+          n = n + 1
+        conditionals.append(sub)
 
-    joined_pairs = ' AND '.join(conditionals)
-    condition = 'WHERE ' + joined_pairs
+      joined_pairs = ' AND '.join(conditionals)
+      condition = 'WHERE ' + joined_pairs
 
-    q = self._model.gql(condition, *args)
+      q = self._model.gql(condition, *args)
+    else:
+      q = self._model.all()
+
     result = q.fetch(limit, offset)
 
     if unique: