Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 17:21:41 +0000] rev 265
List views should have a selectable pagination "page" length:
http://code.google.com/p/soc/issues/detail?id=59
Patch by: Chen Lunpeng and Todd Larsen
Review by: Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/1201
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 07:03:11 +0000] rev 264
Change to imports to follow the style guide:
http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports
Specifically:
"Use from x import y only when x is a package and y is a module."
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 01:32:34 +0000] rev 263
Make findNearestUsers() code in soc/logic/site/id_user.py more generic and
move it to soc/logic/model.py. Orginal findNearest...() functions in
id_user.py are now convenience wrappers.
Add typed-query string construction functions to model.py.
Move getFulLClassName() from key_name.py model.py, since it has more to do
with Model types than key names.
Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also,
stop adding 1 inside the ...ForLimitAndOffset() functions and make the
callers do it (since it was being added for a very UI-specific reason of
whether or not to display a "Next>" link).
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1401
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 20:22:15 +0000] rev 262
Factor out an isIdAvailable() function from EditForm.clean_id() in
soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py.
Addresses some comments on r614.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1202
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:37:18 +0000] rev 261
Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:36:08 +0000] rev 260
Fix typo in recent validate.py changes (r682).
Patch by: Chen Lunpeng
Review by: Todd Larsen